You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/19 12:50:43 UTC
[GitHub] [flink] carp84 commented on a change in pull request #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
carp84 commented on a change in pull request #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#discussion_r368291470
##########
File path: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh
##########
@@ -47,7 +47,7 @@ ORIGINAL_DOP=$1
NEW_DOP=$2
STATE_BACKEND_TYPE=${3:-file}
STATE_BACKEND_FILE_ASYNC=${4:-true}
-STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-heap}
+STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-rocks}
Review comment:
Changing the default here to rocks makes sense, while I'm not sure the impact to e2e test (many cases will use rocksdb timer instead). Could you also include e2e tests in travis run to make sure no surprise? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services