You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/06 16:07:20 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6712: Refactor registry plugin and simplify its usage

kezhenxu94 commented on a change in pull request #6712:
URL: https://github.com/apache/dolphinscheduler/pull/6712#discussion_r744140739



##########
File path: .github/CODEOWNERS
##########
@@ -15,8 +15,6 @@
 # limitations under the License.
 #
 
-# This file is only to override the production configurations in standalone server.
-
-registry.plugin.dir=./dolphinscheduler-dist/target/dolphinscheduler-dist-2.0.0-SNAPSHOT/lib/plugin/registry/zookeeper
-registry.plugin.name=zookeeper
-registry.servers=127.0.0.1:2181
+dolphinscheduler/dolphinscheduler-e2e @kezhenxu94

Review comment:
       > is it necessary? '@kezhenxu94'
   
   This is an example to list "maintainers" for some specific modules, github will automatically request their review when these modules are modified in pull requests, you and other maintainers can also add the modules you are responsible for. Does it make sense to you?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org