You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/04/02 23:15:46 UTC
[GitHub] [hbase] gjacoby126 opened a new pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
gjacoby126 opened a new pull request #3120:
URL: https://github.com/apache/hbase/pull/3120
…branch-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] gjacoby126 commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813752239
@Reidddddd - yes, TestConnectionImplementation passed locally for me. The patch uses protobuf RPC calls because the original version of the test was exercising the protobuf interface (grabbing the Admin or Client service object).
The change is that some previous version of the Connection object internally made a call to verify the hostname upon a getAdmin or getClient call, and more recent versions appear to wait until the client makes their first call to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] gjacoby126 commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813181714
@Reidddddd - look for -Dtest.exclude.pattern in https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt to see TestConnectionImplementation is on the excluded list
Also the import order seems to be inconsistent (e.g HTablePool has the protobuf imports at the end, while HTable and many other classes have them alphabetized).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813156986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 5m 38s | Docker failed to build yetus/hbase:edccfe439a. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/3120 |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd merged pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd merged pull request #3120:
URL: https://github.com/apache/hbase/pull/3120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813256087
OK, LGTM. Failed test are not related.
One more thought, do we have to use protobuf.generated here? could we just general client api?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] gjacoby126 commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813156024
@Reidddddd - I fixed the checkstyle issue. I'm having trouble seeing which tests failed (only that some forks crashed), but since the change is only to a single test file, I don't see how this patch could be breaking anything else.
Unfortunately the test run did not exercise this test because it's in the exclusion list (I assume because it's been broken a long time.) Will that be removed from the exclusion list automatically if it starts passing or is that an extra step I need to take as part of this patch?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813177810
> because it's in the exclusion list
Where did you see it, could you point it out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] gjacoby126 commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813158083
The most recent failure appears to be a Yetus issue with setting up the docker container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813226842
> -Dtest.exclude.pattern in https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt
Oh, no worry about this.
> Also the import order seems to be inconsistent
I think some are legacy. Please put it at the bottom, we need to re-trigger the QA anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813227894
BTW, is it passed on your local laptop, after your fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] gjacoby126 edited a comment on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
gjacoby126 edited a comment on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813181714
@Reidddddd - look for -Dtest.exclude.pattern in https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt to see TestConnectionImplementation is on the excluded list
Also the import order seems to be inconsistent (e.g HTablePool has the Google protobuf imports at the end, while HTable and many other classes have them alphabetized).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-812777014
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 17s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 54s | branch-1 passed |
| +1 :green_heart: | compile | 0m 42s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | compile | 0m 46s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | checkstyle | 1m 53s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 21s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 49s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +0 :ok: | spotbugs | 3m 16s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 12s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 6s | the patch passed |
| +1 :green_heart: | compile | 0m 42s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javac | 0m 42s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | javac | 0m 45s | the patch passed |
| -1 :x: | checkstyle | 1m 44s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | findbugs | 3m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 111m 27s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 167m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3120 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f1fb37077ddf 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3120/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7851df7 |
| Default Java | Azul Systems, Inc.-1.7.0_272-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/diff-checkstyle-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/testReport/ |
| Max. process+thread count | 3320 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813174614
> I need to take as part of this patch?
No need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813253534
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 58s | branch-1 passed |
| +1 :green_heart: | compile | 0m 42s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | compile | 0m 47s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | checkstyle | 1m 56s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 22s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 47s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javadoc | 0m 43s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +0 :ok: | spotbugs | 3m 17s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 14s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 6s | the patch passed |
| +1 :green_heart: | compile | 0m 43s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javac | 0m 43s | the patch passed |
| +1 :green_heart: | compile | 0m 46s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | javac | 0m 46s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 46s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 59s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 |
| +1 :green_heart: | findbugs | 3m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 122m 14s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. |
| | | 167m 29s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| | hadoop.hbase.regionserver.TestHRegion |
| | hadoop.hbase.namequeues.TestSlowLogAccessor |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3120 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux bac2681f7538 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3120/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7851df7 |
| Default Java | Azul Systems, Inc.-1.7.0_272-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/testReport/ |
| Max. process+thread count | 3338 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813175156
Checked other classes, I think `com.google.` should be at the bottom of the import orders
Could you please update it and trigger QA again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #3120: HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on pull request #3120:
URL: https://github.com/apache/hbase/pull/3120#issuecomment-813149714
Is the unit failure related?
Please fix the checkstyle warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org