You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ferenc Szabo (Code Review)" <ge...@cloudera.org> on 2018/06/19 13:36:12 UTC

[kudu-CR] KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume

Ferenc Szabo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10753


Change subject: KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume
......................................................................

KUDU-2479 Flume sink should properly shade its dependencies
that are incompatible with flume

Adding relocation to maven shade plugin configuration

Change-Id: I107a119ecebecac377587037491716116263eff2
---
M java/kudu-flume-sink/pom.xml
1 file changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/10753/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I107a119ecebecac377587037491716116263eff2
Gerrit-Change-Number: 10753
Gerrit-PatchSet: 1
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>

[kudu-CR] KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10753 )

Change subject: KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume
......................................................................

KUDU-2479 Flume sink should properly shade its dependencies
that are incompatible with flume

Adding relocation to maven shade plugin configuration

Change-Id: I107a119ecebecac377587037491716116263eff2
Reviewed-on: http://gerrit.cloudera.org:8080/10753
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/kudu-flume-sink/pom.xml
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, but someone else must approve
  Mike Percy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I107a119ecebecac377587037491716116263eff2
Gerrit-Change-Number: 10753
Gerrit-PatchSet: 2
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10753 )

Change subject: KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107a119ecebecac377587037491716116263eff2
Gerrit-Change-Number: 10753
Gerrit-PatchSet: 1
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 19 Jun 2018 21:46:14 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10753 )

Change subject: KUDU-2479 Flume sink should properly shade its dependencies that are incompatible with flume
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107a119ecebecac377587037491716116263eff2
Gerrit-Change-Number: 10753
Gerrit-PatchSet: 1
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 19 Jun 2018 15:30:21 +0000
Gerrit-HasComments: No