You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2015/06/09 04:44:43 UTC
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/600
TAJO-1642: CatalogServer need to check meta table first.
I tested this patch on my laptop. When I tried to start up tajo-0.11.0-SNAPSHOT with the catalog-site.xml file for tajo-0.10.1-SNAPSHOT, TajoMaster printed following messages.
```
15/06/09 11:38:11 INFO store.MySQLStore: The meta table of CatalogServer already is created.
15/06/09 11:38:11 ERROR store.MySQLStore: Catalog version (2) and current driver version (4) are mismatch to each other
15/06/09 11:38:11 ERROR store.MySQLStore: =========================================================================
15/06/09 11:38:11 ERROR store.MySQLStore: | Catalog Store Migration Is Needed |
15/06/09 11:38:11 ERROR store.MySQLStore: =========================================================================
15/06/09 11:38:11 ERROR store.MySQLStore: | You might downgrade or upgrade Apache Tajo. Downgrading or upgrading |
15/06/09 11:38:11 ERROR store.MySQLStore: | Tajo without migration process is only available in some versions. |
15/06/09 11:38:11 ERROR store.MySQLStore: | In order to learn how to migration Apache Tajo instance, |
15/06/09 11:38:11 ERROR store.MySQLStore: | please refer http://s.apache.org/0_8_migration. |
15/06/09 11:38:11 ERROR store.MySQLStore: =========================================================================
```
And I found that existing column informations exists normally. For the reference, I succeed to test with only tajo-0.11.0-SNAPSHOT.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-1642
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #600
----
commit 97fb598fdd7826a5c4da4019bb2ecdc48e31d8cd
Author: JaeHwa Jung <bl...@apache.org>
Date: 2015-06-09T02:39:00Z
TAJO-1642: CatalogServer need to check meta table first.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/600#issuecomment-114068664
Hi @jihoonson
Thanks for your review.
I've just updated the patch using your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/600#issuecomment-112603544
@blrunner thanks for your patch.
I left one comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/600#issuecomment-114512668
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1642: CatalogServer need to check meta tab...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/600#discussion_r32583451
--- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java ---
@@ -344,6 +345,16 @@ public void upgradeBaseSchema(Connection conn, int currentVersion) {
CatalogUtil.closeQuietly(stmt);
}
+ public boolean catalogAlreadyExists(Connection conn) throws CatalogException {
+ boolean result = false;
+ try {
+ result = checkExistence(conn, DatabaseObjectType.TABLE, CatalogConstants.TB_META);
--- End diff --
I think that every database object should be checked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---