You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by GitBox <gi...@apache.org> on 2019/12/04 16:27:22 UTC

[GitHub] [metamodel] GerardDellemann opened a new pull request #234: MM-82 Detect Column Types

GerardDellemann opened a new pull request #234: MM-82 Detect Column Types
URL: https://github.com/apache/metamodel/pull/234
 
 
   Solves the column type detection for [METAMODEL-82](https://issues.apache.org/jira/browse/METAMODEL-82). You can now configure that you want to detect the Column Types and set how many rows you want to scan.
   
   I've tried to make everything backwards compatable. I've added 2 new test files. This resulted in also finding another minor bug in the current code: the number to string formatting was different between xls and xlsx when working with a dot to seperate thousands. This is fixed with the new method ExcelUtils#getNumericCellValueAsStringUsingBuildinFormat(...).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services