You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/10/31 20:29:03 UTC
[maven-project-info-reports-plugin] branch holy-moly updated: fix tables
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch holy-moly
in repository https://gitbox.apache.org/repos/asf/maven-project-info-reports-plugin.git
The following commit(s) were added to refs/heads/holy-moly by this push:
new 297b2d7 fix tables
297b2d7 is described below
commit 297b2d74c9a5ecf8e3fc9d91318155dfe8f590d4
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Mon Oct 31 21:28:52 2022 +0100
fix tables
---
.../maven/report/projectinfo/DependencyConvergenceReport.java | 8 ++++++++
.../projectinfo/dependencies/renderer/DependenciesRenderer.java | 6 +++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/maven/report/projectinfo/DependencyConvergenceReport.java b/src/main/java/org/apache/maven/report/projectinfo/DependencyConvergenceReport.java
index a04f8d6..14df342 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/DependencyConvergenceReport.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/DependencyConvergenceReport.java
@@ -300,6 +300,7 @@ public class DependencyConvergenceReport
private void generateDependencyDetails( Locale locale, Sink sink, List<ReverseDependencyLink> depList )
{
sink.table();
+ sink.tableRows( null, false );
Map<String, List<ReverseDependencyLink>> artifactMap = getSortedUniqueArtifactMap( depList );
@@ -314,6 +315,7 @@ public class DependencyConvergenceReport
sink.tableCell();
sink.table();
+ sink.tableRows( null, false );
for ( String version : artifactMap.keySet() )
{
@@ -328,11 +330,13 @@ public class DependencyConvergenceReport
sink.tableRow_();
}
+ sink.tableRows_();
sink.table_();
sink.tableCell_();
sink.tableRow_();
+ sink.tableRows_();
sink.table_();
}
@@ -518,6 +522,7 @@ public class DependencyConvergenceReport
private void generateLegend( Locale locale, Sink sink )
{
sink.table();
+ sink.tableRows( null, false );
sink.tableCaption();
sink.bold();
sink.text( getI18nString( locale, "legend" ) );
@@ -535,6 +540,7 @@ public class DependencyConvergenceReport
sink.tableRow_();
+ sink.tableRows_();
sink.table_();
}
@@ -557,6 +563,7 @@ public class DependencyConvergenceReport
// Create report
sink.table();
+ sink.tableRows( null, false );
sink.tableCaption();
sink.bold();
sink.text( getI18nString( locale, "stats.caption" ) );
@@ -665,6 +672,7 @@ public class DependencyConvergenceReport
sink.tableCell_();
sink.tableRow_();
+ sink.tableRows_();
sink.table_();
}
diff --git a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
index 43eb156..ffd9249 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
@@ -857,7 +857,7 @@ public class DependenciesRenderer
String javascript = String.format( "<img id=\"%s\" src=\"%s\" alt=\"%s\""
+ " onclick=\"toggleDependencyDetails( '%s', '%s' );\""
- + " style=\"cursor: pointer; vertical-align: text-bottom;\"></img>",
+ + " style=\"cursor: pointer; vertical-align: text-bottom;\" />",
imgId, IMG_INFO_URL, getI18nString( "graph.icon.information" ), dependencyDetailId, imgId );
sink.rawText( javascript );
@@ -911,6 +911,7 @@ public class DependenciesRenderer
List<License> licenses = artifactProject.getLicenses();
sink.table();
+ sink.tableRows( null, false );
sink.tableRow();
sink.tableHeaderCell();
@@ -1007,6 +1008,7 @@ public class DependenciesRenderer
sink.tableCell_();
sink.tableRow_();
+ sink.tableRows_();
sink.table_();
}
catch ( ProjectBuildingException e )
@@ -1026,6 +1028,7 @@ public class DependenciesRenderer
else
{
sink.table();
+ sink.tableRows( null, false );
sink.tableRow();
sink.tableHeaderCell();
@@ -1056,6 +1059,7 @@ public class DependenciesRenderer
sink.tableCell_();
sink.tableRow_();
+ sink.tableRows_();
sink.table_();
}