[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #11068: Fix triple default version

[GitBox <gi...@apache.org>]

CrazyHZM commented on code in PR #11068:
URL: https://github.com/apache/dubbo/pull/11068#discussion_r1039358079


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/RequestMetadata.java:
##########
@@ -58,9 +58,7 @@ public DefaultHttp2Headers toHeaders() {
             .set(TripleHeaderEnum.CONTENT_TYPE_KEY.getHeader(), TripleConstant.CONTENT_PROTO)
             .set(HttpHeaderNames.TE, HttpHeaderValues.TRAILERS);
         setIfNotNull(header, TripleHeaderEnum.TIMEOUT.getHeader(), timeout);
-        if (!"1.0.0".equals(version)) {
-            setIfNotNull(header, TripleHeaderEnum.SERVICE_VERSION.getHeader(), version);
-        }

Review Comment:
   Why do I get the feeling that this 1.0.0 is a bit confusing with the Dubbo protocol version?
   If it's just the service version number, it shouldn't make a difference to 1.0.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org