You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/06/30 20:27:57 UTC

Re: svn commit: r31927 - in trunk/subversion: libsvn_client tests/cmdline

kameshj@tigris.org writes:
> Log:
> Fix issue-3067 desc36.
>
> * subversion/libsvn_client/merge.c
>   (prepare_subtree_ranges): 'svn_client__repos_location_segments'
>    gives location segments order oldest to youngest.
>    Here the code wants the Youngest segment which is available at the
>    of the segment list.
> * subversion/tests/cmdline/merge_tests.py
>   (test_list): Remove XFail marker from subtrees_with_empty_mergeinfo.

Thanks for fixing this.  But, the log message for prepare_subtree_ranges
doesn't really say what changed in this commit.  It just makes a
statement about what some other function does, and then a statement
about what this code wants.

Can you rewrite it to say what actually happened in this commit?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r31927 - in trunk/subversion: libsvn_client tests/cmdline

Posted by Kamesh Jayachandran <ka...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Thanks for fixing this.  But, the log message for prepare_subtree_ranges
> doesn't really say what changed in this commit.  It just makes a
> statement about what some other function does, and then a statement
> about what this code wants.
> 
> Can you rewrite it to say what actually happened in this commit?

Done. Let me know if it needs some more.

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIadIn3WHvyO0YTCwRAq7OAJ9kWPNBL0E6QgvCDRCOFj97evzB7wCeKVm9
mkFn524hwUlSuGftxM71Ipc=
=A/Cn
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org