You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/08 21:16:01 UTC

Review Request 33994: Change RC verification script to use a temp dir.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.


Diffs
-----

  build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 33994: Change RC verification script to use a temp dir.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83058
-----------------------------------------------------------

Ship it!


Master (8d8d75e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 8, 2015, 7:16 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.
> 
> 
> Diffs
> -----
> 
>   build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> -------
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33994: Change RC verification script to use a temp dir.

Posted by Bill Farner <wf...@apache.org>.

> On May 8, 2015, 7:24 p.m., Kevin Sweeney wrote:
> > build-support/release/verify-release-candidate, line 59
> > <https://reviews.apache.org/r/33994/diff/1/?file=953286#file953286line59>
> >
> >     local dist_name=$1

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83057
-----------------------------------------------------------


On May 8, 2015, 7:16 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.
> 
> 
> Diffs
> -----
> 
>   build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> -------
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33994: Change RC verification script to use a temp dir.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83057
-----------------------------------------------------------

Ship it!



build-support/release/verify-release-candidate
<https://reviews.apache.org/r/33994/#comment133927>

    local dist_name=$1


- Kevin Sweeney


On May 8, 2015, 12:16 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 12:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.
> 
> 
> Diffs
> -----
> 
>   build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> -------
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33994: Change RC verification script to use a temp dir.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
-----------------------------------------------------------

(Updated May 8, 2015, 7:33 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.


Diffs (updated)
-----

  build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing
-------

Successfully verified 0.8.0-rc1:
```
./build-support/release/verify-release-candidate 0.8.0-rc1
```


Thanks,

Bill Farner


Re: Review Request 33994: Change RC verification script to use a temp dir.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
-----------------------------------------------------------

(Updated May 8, 2015, 7:16 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains and is likely to regress.


Diffs
-----

  build-support/release/verify-release-candidate a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing (updated)
-------

Successfully verified 0.8.0-rc1:
```
./build-support/release/verify-release-candidate 0.8.0-rc1
```


Thanks,

Bill Farner