You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/11 18:33:44 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…
kgiusti opened a new pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761
…ion masks
There can be a delay between when a new remote router is discovered
and the connection over which that router is accessed is identified.
If a message is forwarded before this process completes the connection
lookup fails. The patch checks if the failure occurs and avoids
forwarding the message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761#discussion_r442294031
##########
File path: src/router_core/forwarder.c
##########
@@ -660,23 +660,25 @@ int qdr_forward_closest_CT(qdr_core_t *core,
qd_bitmask_first_set(addr->closest_remotes, &addr->next_remote);
// get the inter-router connection associated with path to rnode:
- int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
- qdr_link_t *out_link;
- if (control) {
- out_link = peer_router_control_link(core, conn_bit);
- } else if (!receive_complete) {
- out_link = get_outgoing_streaming_link(core, core->rnode_conns_by_mask_bit[conn_bit]);
- } else {
- out_link = peer_router_data_link(core, conn_bit, qdr_forward_effective_priority(msg, addr));
- }
+ const int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
+ if (conn_bit >= 0) {
Review comment:
Yeah I checked each access to node->conn_mask_bit and use of the conn bit in that file and elsewhere. I'm pretty sure I've covered all the bases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…
Posted by GitBox <gi...@apache.org>.
ted-ross commented on a change in pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761#discussion_r442192632
##########
File path: src/router_core/forwarder.c
##########
@@ -660,23 +660,25 @@ int qdr_forward_closest_CT(qdr_core_t *core,
qd_bitmask_first_set(addr->closest_remotes, &addr->next_remote);
// get the inter-router connection associated with path to rnode:
- int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
- qdr_link_t *out_link;
- if (control) {
- out_link = peer_router_control_link(core, conn_bit);
- } else if (!receive_complete) {
- out_link = get_outgoing_streaming_link(core, core->rnode_conns_by_mask_bit[conn_bit]);
- } else {
- out_link = peer_router_data_link(core, conn_bit, qdr_forward_effective_priority(msg, addr));
- }
+ const int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
+ if (conn_bit >= 0) {
Review comment:
Did you also check the equivalent logic in qdr_forward_balanced_CT? I think this is a good update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761#issuecomment-642881998
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=h1) Report
> Merging [#761](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b726d7d9fd9c2a6e9193394a4c6f349740c740a8&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 97 97
Lines 22241 22242 +1
=======================================
+ Hits 19215 19216 +1
Misses 3026 3026
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/761/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.91% <100.00%> (-0.21%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/761/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.25% <0.00%> (-0.22%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/761/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `92.10% <0.00%> (+0.31%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=footer). Last update [b726d7d...10ba4d5](https://codecov.io/gh/apache/qpid-dispatch/pull/761?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org