You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/01 09:02:29 UTC

[GitHub] [mynewt-nimble] JaydenH215 opened a new issue #712: A case in ble_ll_sched_adv_reschedule

JaydenH215 opened a new issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] wnnwoo edited a comment on issue #712: A case in ble_ll_sched_adv_reschedule

Posted by GitBox <gi...@apache.org>.
wnnwoo edited a comment on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573288634
 
 
   Yes, it may overlap the next_sch
   
   and the procedure will judge whether it is overlapped it in the next iteration in this while loop, the procedure will go and find the right position until the end of the Q.
   
   U can refer this doc.
   https://wnnwoo.github.io/2020/01/05/nimble-scheduler/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule

Posted by GitBox <gi...@apache.org>.
wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573288634
 
 
   Yes, it may overlap the next_sch
   
   and the procedure will judge whether it is overlapped it in the next iteration in this while loop, the procedure will go and find the right position until the end of the Q.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule

Posted by GitBox <gi...@apache.org>.
wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573721791
 
 
   Dose my blog resole ur question?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] JaydenH215 commented on issue #712: A case in ble_ll_sched_adv_reschedule

Posted by GitBox <gi...@apache.org>.
JaydenH215 commented on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573572939
 
 
   > Yes, it may overlap the next_sch
   > 
   > and the procedure will judge whether it is overlapped it in the next iteration in this while loop, the procedure will go and find the right position until the end of the Q.
   > 
   > U can refer this doc.
   > https://wnnwoo.github.io/2020/01/05/nimble-scheduler/
   
   ```
       if (entry == end_overlap) {
           rand_ticks = (orig_start + max_delay_ticks) - sch->start_time;
           if (rand_ticks > max_delay_ticks) {
               /* No place for advertisement. */
               rc = -1;
           } else {
               if (next_sch == NULL) {
                   TAILQ_INSERT_TAIL(&g_ble_ll_sched_q, sch, link);
               } else {
                   TAILQ_INSERT_BEFORE(next_sch, sch, link);
               }
           }
           break;
       }
   ```
   
   But the latter condition should be true, it will 'break' and will not enter the while again.
   I have read your blog and thank you for sharing. I am also learning nimble and hope to make friends with you. 
   
   [https://jaydenh215.github.io/](https://jaydenh215.github.io/)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on issue #712: A case in ble_ll_sched_adv_reschedule

Posted by GitBox <gi...@apache.org>.
sjanc commented on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573557791
 
 
   Hi,
   
   Since our documentation needs improvements, it would be great if you consider updating it with your notes and send PR :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services