You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2014/03/20 17:57:59 UTC

Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19475/
-----------------------------------------------------------

Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
-------

See JIRA


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e20d8bf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3262ae3 

Diff: https://reviews.apache.org/r/19475/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19475/
-----------------------------------------------------------

(Updated March 25, 2014, 5:50 p.m.)


Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
-------

See JIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e20d8bf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3262ae3 

Diff: https://reviews.apache.org/r/19475/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19475/#review38406
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
<https://reviews.apache.org/r/19475/#comment70546>

    can you remove this or change it?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
<https://reviews.apache.org/r/19475/#comment70547>

    i'm thinking you probably don't need the stack trace here...


- Gunther Hagleitner


On March 20, 2014, 4:57 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19475/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 4:57 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e20d8bf 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3262ae3 
> 
> Diff: https://reviews.apache.org/r/19475/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19475/#review38470
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
<https://reviews.apache.org/r/19475/#comment70664>

    why remove? when there's less urgency before release someone can address it


- Sergey Shelukhin


On March 20, 2014, 4:57 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19475/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 4:57 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e20d8bf 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3262ae3 
> 
> Diff: https://reviews.apache.org/r/19475/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>