You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Alfred Nathaniel (JIRA)" <ji...@apache.org> on 2005/11/23 10:15:37 UTC

[jira] Updated: (COCOON-1691) ESQL compilation error

     [ http://issues.apache.org/jira/browse/COCOON-1691?page=all ]

Alfred Nathaniel updated COCOON-1691:
-------------------------------------

      Component: Blocks: Databases
                     (was: Blocks: XSP)
    Fix Version: 2.1.9-dev (current SVN)

Damn it, the ESQL logicsheet escaped my renaming exercise.  Our pre-release testing really sucks...

Fix for 2.1.9-dev and trunk committed.

You can patch it relatively easy in a 2.1.8 source distribution.  Edit src/blocks/xsp/databases/java/org/apache/cocoon/components/language/markup/xsp/java/esql.xsl and change xspAttr to _xspAttr in these two lines:

line 697: this._esql_printObject(_esql_struct[_esql_k],xspAttr);
line 708: this._esql_printObject(_esql_query.getResultSet().getObject(_esql_i), xspAttr);


> ESQL compilation error
> ----------------------
>
>          Key: COCOON-1691
>          URL: http://issues.apache.org/jira/browse/COCOON-1691
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Databases
>     Versions: 2.1.8
>     Reporter: Feliciano Borrego
>     Assignee: Alfred Nathaniel
>     Priority: Critical
>      Fix For: 2.1.9-dev (current SVN)
>  Attachments: xsp_esql-error.zip
>
> In the Cocoon 2.1.7 version the sent file mis_referencias.xsp compiled and run correctly.
> org.apache.cocoon.components.language.LanguageException: Error compiling mis_referencias_xsp:
> ERROR 1 (org\apache\cocoon\www\file_\c_\Des\Proy\SigPortal\web\portal\xsp\mis_referencias_xsp.java):
> ...
> );
> _xspAttr.clear();
> // start error (lines 687-687) "xspAttr cannot be resolved"
> this._esql_printObject(_esql_struct[_esql_k],xspAttr);
> // end error
> this.contentHandler.endElement(
> "",
> "sql-row-item",
> ...
> ERROR 2 (org\apache\cocoon\www\file_\c_\Des\Proy\SigPortal\web\portal\xsp\mis_referencias_xsp.java):
> ...
> // postgres is broken as it doesn't allow getObject()
> // to retrieve any type (i.e. bit and bit varying)
> // so don't handle complex types different for postgres
> if (!_esql_connection.getURL().startsWith("jdbc:postgresql:")) {
> // start error (lines 713-713) "xspAttr cannot be resolved"
> this._esql_printObject(_esql_query.getResultSet().getObject(_esql_i), xspAttr);
> // end error
> break;
> }
> default:
> ...
> Line 687, column 0: xspAttr cannot be resolved
> Line 713, column 0: xspAttr cannot be resolved

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (COCOON-1691) ESQL compilation error

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Alfred Nathaniel (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/COCOON-1691?page=all ]
> 
> Alfred Nathaniel updated COCOON-1691:
> -------------------------------------
> 
>       Component: Blocks: Databases
>                      (was: Blocks: XSP)
>     Fix Version: 2.1.9-dev (current SVN)
> 
> Damn it, the ESQL logicsheet escaped my renaming exercise.  Our pre-release testing really sucks...
> 
> Fix for 2.1.9-dev and trunk committed.

Still this change can break existing 3rd party logicsheets relying on existance 
of xspAttr. I'd suggest adding a line...


138:    public void generate() throws ... {
139:      final AttributesImpl xspAttr = _xspAttr;


As well as changing line 122 to add final modifier:

122:    private final AttributesImpl _xspAttr = new AttributesImpl();


Vadim