You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/23 06:01:53 UTC

[GitHub] [airflow] zhongjiajie opened a new pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

zhongjiajie opened a new pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6326
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Sort cli commands and arg
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   NOT need test
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#discussion_r360776523
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1022,10 +1022,10 @@ def _add_subcommand(cls, subparsers, sub):
         if subcommands:
             sub_subparsers = sub_proc.add_subparsers(dest='subcommand')
             sub_subparsers.required = True
-            for command in subcommands:
+            for command in sorted(subcommands, key=lambda x: x['name']):
                 cls._add_subcommand(sub_subparsers, command)
         else:
-            for arg in sub['args']:
+            for arg in sorted(sub['args'], key=lambda x: cls.args[x].flags[0]):
 
 Review comment:
   @potiuk @ashb @mik-laj Could you please take a look if have time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570749730
 
 
   I run `test/test_core.py` local in Airflow breeze, and found out unittest `test_local_task_job` failed random , the failed reason is **Timeout**.
   And I check the code and database, when https://github.com/apache/airflow/blob/3d82e8cf6a9b6b0af3fafef0769f77ced1974cbf/tests/test_core.py#L321
   this line run, table `airflow.dag_run` add a new dag run record but state still on **running**, so after 8 mins cause timeout error.
   
   The point is I could not found why dag run don't change to `success`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571032638
 
 
   @zhongjiajie : I think it will be best if sort according to long option only (especially if we fix the short options to be one-letter). General idea behind long options is that people - when learning CLI tend to use longer options and they are preferred in automation/scripts. They are easier to memorize and they carry the meaning. Also when using autocomplete, it is much easier to learn as you start using longer option prefix and it gets auto-completed.
   
   The short (one letter) options are for "expert mode" only and they are pretty much just a shorthand if you get familiar with the CLI and want to use it quickly / have no autocomplete and you are very familiar with the tool itself.
   
   That's why i prefer to sort only on long options.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850316
 
 
   > What do you think about not ignoring leading dash (key= lambda d: d.lstrip('-'))?
   
   I think maybe we should keep the dash, when we use single is just the flag on open or close of some function, but double dash mean want to get some parameter from command line. IMO their different, and I think we should sort them separate
   
   ```sh
   usage: airflow tasks run [-h] [--cfg_path CFG_PATH] [--pool POOL] [--ship_dag]
                            [-A] [-f] [-i] [-I] [-int] [-l] [-m] [-p PICKLE]
                            [-sd SUBDIR]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     --pool POOL           Resource pool to use
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   I think above is better than below
   
   ```sh
   usage: airflow tasks run [-h] [-A] [--cfg_path CFG_PATH] [-f] [-i] [-I] [-int]
                            [-l] [-m] [-p PICKLE] [--pool POOL] [-sd SUBDIR]
                            [--ship_dag]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     --pool POOL           Resource pool to use
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
   ```
   
   what do you think? @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570742633
 
 
   Is there anything I can do to help with this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#discussion_r360776082
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1022,10 +1022,10 @@ def _add_subcommand(cls, subparsers, sub):
         if subcommands:
             sub_subparsers = sub_proc.add_subparsers(dest='subcommand')
             sub_subparsers.required = True
-            for command in subcommands:
+            for command in sorted(subcommands, key=lambda x: x['name']):
 
 Review comment:
   I think this change is acceptable, it keep `subcommand` in alphabetical, it change cli command like below
   
   ```sh
   # airflow pools -h
   # before
   usage: airflow pools [-h] {list,get,set,delete,import,export} ...
   
   positional arguments:
     {list,get,set,delete,import,export}
       list                List pools
       get                 Get pool size
       set                 Configure pool
       delete              Delete pool
       import              Import pools
       export              Export all pools
   
   optional arguments:
     -h, --help            show this help message and exit
   
   # after
   usage: airflow pools [-h] {delete,export,get,import,list,set} ...
   
   positional arguments:
     {delete,export,get,import,list,set}
       delete              Delete pool
       export              Export all pools
       get                 Get pool size
       import              Import pools
       list                List pools
       set                 Configure pool
   
   optional arguments:
     -h, --help            show this help message and exit
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571005760
 
 
   We still have discuss in https://github.com/apache/airflow/pull/6881#issuecomment-570850316, It's will be great if @potiuk @mik-laj to share your idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-568624951
 
 
   Mistake commit with others patch I submit, force-push to start Travis-CI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-572489470
 
 
   Thanks @zhongjiajie !
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6cbedf8775df77c623f5ca5cace24ed4eecd6a5b?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   85.06%   84.78%   -0.28%     
   ==========================================
     Files         680      680              
     Lines       38753    38764      +11     
   ==========================================
   - Hits        32965    32866      -99     
   - Misses       5788     5898     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <100%> (+0.68%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [6cbedf8...e249275](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-568624951
 
 
   Mistake commit with others patch I submit 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850316
 
 
   > What do you think about not ignoring leading dash (key= lambda d: d.lstrip('-'))?
   I think maybe we should keep the dash, when we use single is just the flag on open or close of some function, but double dash mean want to get some parameter from command line. IMO their different, and I think we should sort them separate
   ```py
   usage: airflow tasks run [-h] [--cfg_path CFG_PATH] [--pool POOL] [--ship_dag]
                            [-A] [-f] [-i] [-I] [-int] [-l] [-m] [-p PICKLE]
                            [-sd SUBDIR]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     --pool POOL           Resource pool to use
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   I think above is better than below
   
   ```py
   usage: airflow tasks run [-h] [-A] [--cfg_path CFG_PATH] [-f] [-i] [-I] [-int]
                            [-l] [-m] [-p PICKLE] [--pool POOL] [-sd SUBDIR]
                            [--ship_dag]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     --pool POOL           Resource pool to use
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
   ```
   
   what do you think? @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-568376875
 
 
   All Travis-CI failed due to Timeout, force-push to start CI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-572539351
 
 
   Thank Jarek's and Kamil's help on this patch. ❤️ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570816359
 
 
   I think, we can sort using followng function:
   ```python
       @classmethod
       def sort_args(cls, args):
           def partition(pred, iterable):
               """
               Use a predicate to partition entries into false entries and true entries
               """
               t1, t2 = tee(iterable)
               return filterfalse(pred, t1), filter(pred, t2)
           positional, optional = partition(lambda x: cls.args[x].flags[0].startswith("-"), args)
           yield from positional
           yield from sorted(optional, key=lambda x: cls.args[x].flags[0])
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6cbedf8775df77c623f5ca5cace24ed4eecd6a5b?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   85.06%   84.78%   -0.28%     
   ==========================================
     Files         680      680              
     Lines       38753    38764      +11     
   ==========================================
   - Hits        32965    32866      -99     
   - Misses       5788     5898     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <100%> (+0.68%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [6cbedf8...e249275](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6cbedf8775df77c623f5ca5cace24ed4eecd6a5b?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   85.06%   84.78%   -0.28%     
   ==========================================
     Files         680      680              
     Lines       38753    38764      +11     
   ==========================================
   - Hits        32965    32866      -99     
   - Misses       5788     5898     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <100%> (+0.68%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [6cbedf8...e249275](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571033170
 
 
   BTW. I added WIP in the title - to indicate this is still in progress :). We have nice Bot now that will keep it from accidentally being merged :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570935734
 
 
   BTW. Created https://issues.apache.org/jira/browse/AIRFLOW-6472 "Some of the options we have are long options with single -"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570932007
 
 
   > It's so odd in https://travis-ci.org/apache/airflow/jobs/632880273?utm_medium=notification&utm_source=github_status
   > Both `tests/test_impersonation.py` and `tests/hooks/test_s3_hook.py` work fun in Breeze but not in Travis, mysql breeze setup with `./breeze --backend mysql --env docker` and run test by `pytest tests/test_impersonation.py tests/hooks/test_s3_hook.py`.
   > 
   > Did some step I miss for the full test?
   
   
   Seem that CI just failed random.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570749730
 
 
   I run `test/test_core.py` local in Airflow breeze, and found out unittest `test_local_task_job` failed random , the failed reason is **Timeout**.
   And I check the code and database, when https://github.com/apache/airflow/blob/3d82e8cf6a9b6b0af3fafef0769f77ced1974cbf/tests/test_core.py#L321
   this line run, table `airflow.dag_run` add a new dag run record but state still on **running**, so after 8 mins cause timeout error.
   
   The point is I could not found why dag run don't change to `success`. If you could help will be bettter @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570814948
 
 
   Oh. We should not sort positional arguments.  How can we fix it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570891939
 
 
   One other point since we are discussing cli changes and cleaning up.
   
   I just realised that we have some "short" options that are really "long" ones: namely -int and -sd in the run task. This is against the idea of short and long options in Unix (and argparse follows that). The main reason to have short options is that you can combine short options:
   
   `airflow task run -iAlm` 
   
   When you have more than one letter "short" options this might become quickly ambiguous. We do not have -s yet but if we add few more options this might become a problem.
   
   Also in the argparse documentation https://docs.python.org/2/library/argparse.html it's mentioned that short options should be single character only.
   
   Does it bother others? Or is it just me ? Should we maybe fix that?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570813787
 
 
   Finally I found out CI failed due to
   `for arg in sorted(sub['args'], key=lambda x: cls.args[x].flags[0]):`
   and the error message is
   `argument execution_date: invalid parse value: 'runme_0', see help above.`
   It's seem that argparse parse parameter in wrong index, I try to fix it but still failed. 😢 
   
   The more odd think is odd thing, when I only change to sort of `airflow tasks run` arg, if will fail the test
   ```py
   # before
   {
       'func': lazy_load_command('airflow.cli.commands.task_command.task_run'),
       'name': 'run',
       'help': "Run a single task instance",
       'args': (
           'dag_id', 'task_id', 'execution_date', 'subdir',     #  <---change this line
           'mark_success', 'force', 'pool', 'cfg_path',
           'local', 'raw', 'ignore_all_dependencies', 'ignore_dependencies',
           'ignore_depends_on_past', 'ship_dag', 'pickle', 'job_id', 'interactive',),
   },
   # after
   {
       'func': lazy_load_command('airflow.cli.commands.task_command.task_run'),
       'name': 'run',
       'help': "Run a single task instance",
       'args': (
           'execution_date', 'dag_id', 'task_id', 'subdir',
           'mark_success', 'force', 'pool', 'cfg_path',
           'local', 'raw', 'ignore_all_dependencies', 'ignore_dependencies',
           'ignore_depends_on_past', 'ship_dag', 'pickle', 'job_id', 'interactive',),
   },
   ```
   with error message `argument execution_date: invalid parse value: 'example_bash_operator', see help above.`
   Seem that airflow pass parameter by position, no the key. But I can not found out where
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#discussion_r361766491
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1022,10 +1022,10 @@ def _add_subcommand(cls, subparsers, sub):
         if subcommands:
             sub_subparsers = sub_proc.add_subparsers(dest='subcommand')
             sub_subparsers.required = True
-            for command in subcommands:
+            for command in sorted(subcommands, key=lambda x: x['name']):
                 cls._add_subcommand(sub_subparsers, command)
         else:
-            for arg in sub['args']:
+            for arg in sorted(sub['args'], key=lambda x: cls.args[x].flags[0]):
 
 Review comment:
   The current order of the elements is random. No one had ever dealt with their order before. I think we don't have to worry about the current order.  I prefer alphabetical order.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571391602
 
 
   Code now sort by long option and CI green, the behavior like below 
   
   ```sh
   usage: airflow tasks run [-h] [--cfg_path CFG_PATH] [-f] [-A] [-i] [-I] [-int]
                            [-l] [-m] [-p PICKLE] [--pool POOL] [--ship_dag]
                            [-sd SUBDIR]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     --pool POOL           Resource pool to use
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   ```sh
   usage: airflow dags trigger [-h] [-c CONF] [-e EXEC_DATE] [-r RUN_ID]
                               [-sd SUBDIR]
                               dag_id
   
   positional arguments:
     dag_id                The id of the dag
   
   optional arguments:
     -h, --help            show this help message and exit
     -c CONF, --conf CONF  JSON string that gets pickled into the DagRun's conf attribute
     -e EXEC_DATE, --exec_date EXEC_DATE
                           The execution date of the DAG
     -r RUN_ID, --run_id RUN_ID
                           Helps to identify this run
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   PTAL @potiuk @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570924726
 
 
   > Does it bother others? Or is it just me ? Should we maybe fix that?
   
   Yeah, I think is a problem too, short option represent turn on or turn off something, if the option have multiple value should use long one. IMO, we should fix that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

mik-laj commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570817142
 
 
   What do you think about not ignoring case (key= lambda d: d.lower())?
   What do you think about not ignoring leading dash (key= lambda d: d.lstrip('-'))?
   
   So we will have the following method:
   ```python
       @classmethod
       def sort_args(cls, args):
           def partition(pred, iterable):
               """
               Use a predicate to partition entries into false entries and true entries
               """
               t1, t2 = tee(iterable)
               return filterfalse(pred, t1), filter(pred, t2)
           positional, optional = partition(lambda x: cls.args[x].flags[0].startswith("-"), args)
           yield from positional
           yield from sorted(optional, key=lambda x: cls.args[x].flags[0].lower().lstrip("-"))
   ```
   Examplle output:
   ```
   usage: airflow tasks run [-h] [-A] [--cfg_path CFG_PATH] [-f] [-i] [-I] [-int]
                            [-l] [-m] [-p PICKLE] [--pool POOL] [-sd SUBDIR]
                            [--ship_dag]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     --pool POOL           Resource pool to use
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
   ```
    I would like to draw your attention to the `pickle` and `pool` options

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850651
 
 
   > What do you think about not ignoring case (key= lambda d: d.lower())?
   
   I agree with you this point, but different with others, the reason in the previous comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850316
 
 
   > What do you think about not ignoring leading dash (key= lambda d: d.lstrip('-'))?
   I think maybe we should keep the dash, when we use single is just the flag on open or close of some function, but double dash mean want to get some parameter from command line. IMO their different, and I think we should sort them separate
   
   ```sh
   usage: airflow tasks run [-h] [--cfg_path CFG_PATH] [--pool POOL] [--ship_dag]
                            [-A] [-f] [-i] [-I] [-int] [-l] [-m] [-p PICKLE]
                            [-sd SUBDIR]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     --pool POOL           Resource pool to use
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   I think above is better than below
   
   ```sh
   usage: airflow tasks run [-h] [-A] [--cfg_path CFG_PATH] [-f] [-i] [-I] [-int]
                            [-l] [-m] [-p PICKLE] [--pool POOL] [-sd SUBDIR]
                            [--ship_dag]
                            dag_id task_id execution_date
   
   positional arguments:
     dag_id                The id of the dag
     task_id               The id of the task
     execution_date        The execution date of the DAG
   
   optional arguments:
     -h, --help            show this help message and exit
     -A, --ignore_all_dependencies
                           Ignores all non-critical dependencies, including ignore_ti_state and ignore_task_deps
     --cfg_path CFG_PATH   Path to config file to use instead of airflow.cfg
     -f, --force           Ignore previous task instance state, rerun regardless if task already succeeded/failed
     -i, --ignore_dependencies
                           Ignore task-specific dependencies, e.g. upstream, depends_on_past, and retry delay dependencies
     -I, --ignore_depends_on_past
                           Ignore depends_on_past dependencies (but respect upstream dependencies)
     -int, --interactive   Do not capture standard output and error streams (useful for interactive debugging)
     -l, --local           Run the task using the LocalExecutor
     -m, --mark_success    Mark jobs as succeeded without running them
     -p PICKLE, --pickle PICKLE
                           Serialized pickle object of the entire dag (used internally)
     --pool POOL           Resource pool to use
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
     --ship_dag            Pickles (serializes) the DAG and ships it to the worker
   ```
   
   what do you think? @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570927761
 
 
   It's so odd in https://travis-ci.org/apache/airflow/jobs/632880273?utm_medium=notification&utm_source=github_status
   Both `tests/test_impersonation.py` and `tests/hooks/test_s3_hook.py` work fun in Breeze but not in Travis, mysql breeze setup with `./breeze --backend mysql --env docker` and run test by `pytest tests/test_impersonation.py tests/hooks/test_s3_hook.py`.
   
   Did some step I miss for the full test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570933284
 
 
   Don't merge this PR as we still have discuss in https://github.com/apache/airflow/pull/6881#issuecomment-570850316

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on a change in pull request #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#discussion_r360776054
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1022,10 +1022,10 @@ def _add_subcommand(cls, subparsers, sub):
         if subcommands:
             sub_subparsers = sub_proc.add_subparsers(dest='subcommand')
             sub_subparsers.required = True
-            for command in subcommands:
+            for command in sorted(subcommands, key=lambda x: x['name']):
                 cls._add_subcommand(sub_subparsers, command)
         else:
-            for arg in sub['args']:
+            for arg in sorted(sub['args'], key=lambda x: cls.args[x].flags[0]):
 
 Review comment:
   But I'm not sure if this change is acceptable? Should we keep args in manual or alphabetical? Because some of args help user more easy to catch specific arg like `DAG_ID` or `RUN_ID`
   
   ```sh
   # airflow shceduler -h
   # before
   optional arguments:
     -h, --help            show this help message and exit
     -d DAG_ID, --dag_id DAG_ID
                           The id of the dag to run
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
     -n NUM_RUNS, --num_runs NUM_RUNS
                           Set the number of runs to execute before exiting
     -p, --do_pickle       Attempt to pickle the DAG object to send over to the workers, instead of letting workers run their version of the code
     --pid [PID]           PID file location
     -D, --daemon          Daemonize instead of running in the foreground
     --stdout STDOUT       Redirect stdout to this file
     --stderr STDERR       Redirect stderr to this file
     -l LOG_FILE, --log-file LOG_FILE
                           Location of the log file
   
   # after
   optional arguments:
     -h, --help            show this help message and exit
     --pid [PID]           PID file location
     --stderr STDERR       Redirect stderr to this file
     --stdout STDOUT       Redirect stdout to this file
     -D, --daemon          Daemonize instead of running in the foreground
     -d DAG_ID, --dag_id DAG_ID
                           The id of the dag to run
     -l LOG_FILE, --log-file LOG_FILE
                           Location of the log file
     -n NUM_RUNS, --num_runs NUM_RUNS
                           Set the number of runs to execute before exiting
     -p, --do_pickle       Attempt to pickle the DAG object to send over to the workers, instead of letting workers run their version of the code
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set for 'AIRFLOW_HOME' config you set in 'airflow.cfg'
   ```
   
   ```sh
   # airflow dags -h
   # before
   usage: airflow dags trigger [-h] [-sd SUBDIR] [-r RUN_ID] [-c CONF]
                               [-e EXEC_DATE]
                               dag_id
   
   positional arguments:
     dag_id                The id of the dag
   
   optional arguments:
     -h, --help            show this help message and exit
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look \for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set \for 'AIRFLOW_HOME' config you set \in 'airflow.cfg'
     -r RUN_ID, --run_id RUN_ID
                           Helps to identify this run
     -c CONF, --conf CONF  JSON string that gets pickled into the DagRun\'s conf attribute
     -e EXEC_DATE, --exec_date EXEC_DATE
                           The execution date of the DAG
   
   # after
   usage: airflow dags trigger [-h] [-c CONF] [-e EXEC_DATE] [-r RUN_ID]
                               [-sd SUBDIR]
                               dag_id
   
   positional arguments:
     dag_id                The id of the dag
   
   optional arguments:
     -h, --help            show this help message and exit
     -c CONF, --conf CONF  JSON string that gets pickled into the DagRun\'s conf attribute
     -e EXEC_DATE, --exec_date EXEC_DATE
                           The execution date of the DAG
     -r RUN_ID, --run_id RUN_ID
                           Helps to identify this run
     -sd SUBDIR, --subdir SUBDIR
                           File location or directory from which to look \for the dag. Defaults to '[AIRFLOW_HOME]/dags' where [AIRFLOW_HOME] is the value you set \for 'AIRFLOW_HOME' config you set \in 'airflow.cfg'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570935341
 
 
   > It's so odd in https://travis-ci.org/apache/airflow/jobs/632880273?utm_medium=notification&utm_source=github_status
   > Both `tests/test_impersonation.py` and `tests/hooks/test_s3_hook.py` work fun in Breeze but not in Travis, mysql breeze setup with `./breeze --backend mysql --env docker` and run test by `pytest tests/test_impersonation.py tests/hooks/test_s3_hook.py`.
   > 
   > Did some step I miss for the full test?
   
   We have some weird, really weird behaviour - from time to time py37/mysql impersonation_tests are failiing - and then this failure propagates to other tests and eventually hangs the whole build. 
   This seems to be connected to lack of enough resources on travis builds sometimes (we think they are running on shared machines and maybe those run sometimes too many VMS in parallel).
   We are tracing it down. But so far when the build hanged eventually, we could not see the actual errors - it was not printed by pytest.
   
   I just added pytest-instafail: #7064 to show failures immediately when they happen so that when it happens next time we will be able to hunt it down. Of course the builds started to work 🥇  when I added it, so we do not yet know the reason :(
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b8d5aff156af341fde177597f90777f2cc897d4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [5b8d5af...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-569397951
 
 
   @mik-laj Thanks for approving, but Travis still sad 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570931451
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=h1) Report
   > Merging [#6881](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6881/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6881      +/-   ##
   ==========================================
   - Coverage   84.99%   84.71%   -0.29%     
   ==========================================
     Files         679      679              
     Lines       38647    38655       +8     
   ==========================================
   - Hits        32847    32745     -102     
   - Misses       5800     5910     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.56% <100%> (+0.51%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6881/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=footer). Last update [869ca96...ee8b766](https://codecov.io/gh/apache/airflow/pull/6881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services