You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/12/02 11:24:29 UTC
Re: [PR] Test for string / numeric coercion [datafusion]
findepi commented on code in PR #13606:
URL: https://github.com/apache/datafusion/pull/13606#discussion_r1865682257
##########
datafusion/sqllogictest/test_files/string/string_query.slt.part:
##########
@@ -35,6 +39,41 @@ _ \_ (empty) (empty)
NULL % NULL NULL
NULL R NULL 🔥
+# --------------------------------------
+# test type coercion (compare to int)
+# queries should not error
+# --------------------------------------
+
+query BB
+select ascii_1 = 1 as col1, ascii_1 = 1 as col2 from test_basic_operator;
Review Comment:
why is `ascii_1 = 1` projected twice?
(same for `ascii_1 <> 1` case below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org