[GitHub] [accumulo] keith-turner commented on a change in pull request #1622: fixes #1621: The ClientPool thread pool allows all core threads to time out

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1622:
URL: https://github.com/apache/accumulo/pull/1622#discussion_r448632279



##########
File path: server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java
##########
@@ -231,8 +236,8 @@ public static ServerAddress startServer(MetricsSystem metricsSystem, ServerConte
    */
   public static ServerAddress createThreadedSelectorServer(HostAndPort address,
       TProcessor processor, TProtocolFactory protocolFactory, final String serverName,
-      final int numThreads, final int numSTThreads, long timeBetweenThreadChecks,
-      long maxMessageSize) throws TTransportException {
+      final int numThreads, final long threadTimeOut, final int numSTThreads,

Review comment:
       I was trying to ensure the parameter order was correct when looking at this.  Once I realized you had consistently put the timeout after the number of threads here and elsewhere it made verify the order much easier.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org