1.3 update

[Richard Hirsch <hi...@gmail.com>]

* Should we put ESME-170: Pubsubhubbub support for Atom & RSS actions
to the backlog?

* @Ethan - did your comet rewrite deal with ESME 308 Update times in
standard timeline on a regular basis as well?

* @Ethan - does your comet rewrite solve ESME 282 - When a public
message is resent by one user, no other users are able to resend it

val resendId = "resend_" + m._1.id.toString
    val resendAttrs =
BasicElemAttr("id",resendId).compose(BasicElemAttr("class","resend"))

    val resendTransform:CssBindFunc =
      if(m._3 || m._1.author.is == User.currentUser.map(_.id.is).openOr(0)) {
        ".resend" #> Text("")
      } else {
        ".resend_link" #> SHtml.a(
          () => resendMessage(m._1),
          S.loc("ui_messages_message_label_resend").openOr(Text("")),
          resendAttrs)
      }

I assume that m._3 will be true after one user has sent the message.
In Mailbox.scala, resent is a boolean value.  What if we changed
     if(m._3 || m._1.author.is == User.currentUser.map(_.id.is).openOr(0)) {
to
     if(m._1.author.is == User.currentUser.map(_.id.is).openOr(0)) {

D

Re: 1.3 update

[Ethan Jewett <es...@gmail.com>]

On Sun, Apr 10, 2011 at 7:47 AM, Richard Hirsch <hi...@gmail.com>wrote:

> * Should we put ESME-170: Pubsubhubbub support for Atom & RSS actions
> to the backlog?
>

Yes, I think so. I'm not going to have time to work on it, as far as I can
tell. If Imtiaz or someone else (future me? :) ) finds time to work on it,
that would be great.


> * @Ethan - did your comet rewrite deal with ESME 308 Update times in
> standard timeline on a regular basis as well?
>

No, but it will. I also have a "todo" to change the dates back to relative
dates.


> * @Ethan - does your comet rewrite solve ESME 282 - When a public
> message is resent by one user, no other users are able to resend it
>

No, this is actually an unrelated issue. The problem here is a different
bug. I do plan to get to it in the 1.3 timeframe. I'm not sure if the bug is
in the timeline code that handles resends or in the message/mailbox code and
data-model, or both.


> val resendId = "resend_" + m._1.id.toString
>    val resendAttrs =
> BasicElemAttr("id",resendId).compose(BasicElemAttr("class","resend"))
>
>    val resendTransform:CssBindFunc =
>      if(m._3 || m._1.author.is == User.currentUser.map(_.id.is).openOr(0))
> {
>        ".resend" #> Text("")
>      } else {
>        ".resend_link" #> SHtml.a(
>          () => resendMessage(m._1),
>          S.loc("ui_messages_message_label_resend").openOr(Text("")),
>          resendAttrs)
>      }
>
> I assume that m._3 will be true after one user has sent the message.
> In Mailbox.scala, resent is a boolean value.  What if we changed
>     if(m._3 || m._1.author.is == User.currentUser.map(_.id.is).openOr(0))
> {
> to
>     if(m._1.author.is == User.currentUser.map(_.id.is).openOr(0)) {
>

The m._3 check might be where the bug is, but I think this change will
introduce a bug in the other direction: It will make it so that all messages
will be resend-able, even after a user has already resent one. If you want
to play around with it, go ahead. I think I will not get to this today, but
I'm hoping to do some work on it next week or weekend.

Cheers,
Ethan