You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/06/08 21:58:00 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24331: chore(daos): Organize DAOs according to SIP-92
john-bodley opened a new pull request, #24331:
URL: https://github.com/apache/superset/pull/24331
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This PR is the first of many to related to [SIP-92 Proposal for restructuring the Python code base](https://github.com/apache/superset/issues/20630). Specifically it organizes all the DAOs under the `superset/daos` subfolder. A few things of note:
1. The `EmbeddedDAO` was renamed `EmbeddedDashboardDAO` for clarity.
2. The organization is flat from a directory standpoint (akin to @ktmud's suggestion in the SIP) as opposed to tiered. This means that there was consolidation of DAOs by theme:
- `AnnotationLayerDAO` is housed `daos/annotation.py`
- `EmbeddedDashboardDAO` and `FilterSetDAO` are housed in `daos/dashboard.py`
- `SavedQueryDAO` is housed in `daos/query.py`
- `SSHTunnelDAO` is housed in `daos/database.py`
3. It wasn't overly clear whether the modules should use [singular or plural](https://softwareengineering.stackexchange.com/a/75929) forms, i.e., `dashboard` or `dashboards`. I opted for the former given that:
- They're already housed under `daos` (plural) subfolder.
- Even though the `dashboard.py` file contains a collection of DAOs (`DashboardDAO`, `EmbeddedDashboardDAO`) we _tend_ to think of the term "dashboard" as a concept/type rather than multiple types.
- It seems prudent to stick with either singular or plural from a consistency standpoint—the one exception is (no pun intended) `exceptions` as this houses different exception types and is consistent with how other files containing exceptions are named.
4. Apart from singularizing the terms the follow renames occurred:
- `css_templates/dao.py` became `daos/css.py`
- `row_level_security/dao.py` became `daos/security.py`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24331: chore(daos): Organize DAOs according to SIP-92
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24331:
URL: https://github.com/apache/superset/pull/24331#issuecomment-1583562173
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24331](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6d7a5a1) into [master](https://app.codecov.io/gh/apache/superset/commit/c4242a36572f0468766bad5e645f532d585af642?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c4242a3) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6d7a5a1 differs from pull request most recent head 74cbdbb. Consider uploading reports for the commit 74cbdbb to get more accurate results
```diff
@@ Coverage Diff @@
## master #24331 +/- ##
==========================================
- Coverage 69.08% 69.01% -0.07%
==========================================
Files 1905 1905
Lines 74848 74671 -177
Branches 8108 8108
==========================================
- Hits 51705 51534 -171
+ Misses 21031 21025 -6
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.61% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `86.36% <ø> (-1.14%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `84.21% <ø> (-1.16%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `82.60% <ø> (-1.40%)` | :arrow_down: |
| [...t/annotation\_layers/annotations/commands/update.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `86.36% <ø> (-0.88%)` | :arrow_down: |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `83.33% <ø> (-1.29%)` | :arrow_down: |
| [superset/annotation\_layers/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | `88.00% <ø> (-0.89%)` | :arrow_down: |
| [superset/annotation\_layers/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZGVsZXRlLnB5) | `88.00% <ø> (-0.89%)` | :arrow_down: |
| [superset/annotation\_layers/commands/update.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvdXBkYXRlLnB5) | `90.32% <ø> (-0.59%)` | :arrow_down: |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `87.03% <ø> (-0.05%)` | :arrow_down: |
| [superset/charts/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | `90.90% <ø> (-0.52%)` | :arrow_down: |
| ... and [92 more](https://app.codecov.io/gh/apache/superset/pull/24331?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24331/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24331: chore(dao): Organize DAOs according to SIP-92
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24331:
URL: https://github.com/apache/superset/pull/24331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org