You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/23 09:20:42 UTC

[GitHub] sijie closed pull request #1129: Upgrade JaCoCo and fix code coverage build system

sijie closed pull request #1129: Upgrade  JaCoCo and fix code coverage build system
URL: https://github.com/apache/bookkeeper/pull/1129
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/circe-checksum/pom.xml b/circe-checksum/pom.xml
index 9b4f08408..744e4f021 100644
--- a/circe-checksum/pom.xml
+++ b/circe-checksum/pom.xml
@@ -134,6 +134,17 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.jacoco</groupId>
+        <artifactId>jacoco-maven-plugin</artifactId>
+        <version>0.8.0</version>
+        <configuration>
+            <excludes>
+                <!-- this class is generated -->
+                <exclude>com/scurrilous/circe/checksum/NarSystem*</exclude>
+            </excludes>
+        </configuration>
+       </plugin>
     </plugins>
   </build>
 
diff --git a/pom.xml b/pom.xml
index 0742417d8..9eba20b63 100644
--- a/pom.xml
+++ b/pom.xml
@@ -400,12 +400,14 @@
 	          <redirectTestOutputToFile>true</redirectTestOutputToFile>
 	          <reuseForks>false</reuseForks>
 	          <forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
+                  <!-- we want build to complete even in case of failures -->
+                  <testFailureIgnore>true</testFailureIgnore>
                 </configuration>
              </plugin>
              <plugin>
                <groupId>org.jacoco</groupId>
                <artifactId>jacoco-maven-plugin</artifactId>
-               <version>0.7.9</version>
+               <version>0.8.0</version>
                <executions>
                  <execution>
                    <goals>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services