[GitHub] [spark] cloud-fan commented on pull request #35746: [WIP][SPARK-38432][SQL] Reactor framework so as JDBC dialect could compile filter by self way

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #35746:
URL: https://github.com/apache/spark/pull/35746#issuecomment-1060785799


   It seems like we can completely replace v2 `Filter` with `GeneralScalarExpression`, as they are both tree-like API to represent catalyst expressions in DS v2.
   
   For better type safety, I think we can make `Filter` extends `GeneralScalarExpression`, to indicate that it's a predicate that returns boolean.
   
   That said, the `V2ExpressionBuilder` should create `Filter` if the catalyst expression is a predicate (e.g. binary comparison).
   
   also cc @huaxingao for more opinions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org