You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/05 18:05:21 UTC
[GitHub] [beam] dpcollins-google opened a new pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
dpcollins-google opened a new pull request #13903:
URL: https://github.com/apache/beam/pull/13903
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-774197283
@dpcollins-google what if we make the direct runner a testRuntimeOnly dependency instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-776891899
> what if we make the direct runner a testRuntimeOnly dependency instead?
I tried this and it didn't help.
> I'm surprised there are circular dependencies. What were they?
```
16:21:52 Circular dependency between the following tasks:
16:21:52 :runners:core-construction-java:buildDependents
16:21:52 +--- :runners:core-java:buildDependents
16:21:52 | +--- :runners:direct-java:buildDependents
16:21:52 | | \--- :sdks:java:core:buildDependents
16:21:52 | | +--- :runners:core-construction-java:buildDependents (*)
16:21:52 | | +--- :runners:core-java:buildDependents (*)
16:21:52 | | +--- :runners:direct-java:buildDependents (*)
16:21:52 | | +--- :runners:java-fn-execution:buildDependents
16:21:52 | | | \--- :runners:direct-java:buildDependents (*)
16:21:52 | | +--- :runners:local-java:buildDependents
16:21:52 | | | \--- :runners:direct-java:buildDependents (*)
16:21:52 | | +--- :vendor:sdks-java-extensions-protobuf:buildDependents
16:21:52 | | | \--- :runners:java-fn-execution:buildDependents (*)
16:21:52 | | +--- :sdks:java:fn-execution:buildDependents
16:21:52 | | | +--- :runners:core-construction-java:buildDependents (*)
16:21:52 | | | +--- :runners:core-java:buildDependents (*)
16:21:52 | | | +--- :runners:direct-java:buildDependents (*)
16:21:52 | | | +--- :runners:java-fn-execution:buildDependents (*)
16:21:52 | | | \--- :sdks:java:harness:buildDependents
16:21:52 | | | \--- :runners:java-fn-execution:buildDependents (*)
16:21:52 | | +--- :sdks:java:harness:buildDependents (*)
16:21:52 | | \--- :sdks:java:extensions:google-cloud-platform-core:buildDependents
16:21:52 | | \--- :sdks:java:harness:buildDependents (*)
16:21:52 | +--- :runners:java-fn-execution:buildDependents (*)
16:21:52 | +--- :sdks:java:harness:buildDependents (*)
16:21:52 | \--- :sdks:java:extensions:google-cloud-platform-core:buildDependents (*)
16:21:52 +--- :runners:direct-java:buildDependents (*)
16:21:52 +--- :runners:java-fn-execution:buildDependents (*)
16:21:52 \--- :sdks:java:harness:buildDependents (*)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-776887097
I'm surprised there are circular dependencies. What were they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google closed pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
dpcollins-google closed pull request #13903:
URL: https://github.com/apache/beam/pull/13903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-776909233
I see. So gradle separated main and test in a way that would break the cycle, but then added catchall tasks that reintroduce it :-/
I think the idea is a nonstarter unless we exclude some deps from this task, yea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-774197020
Won't work due to circular dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #13903: Update build.gradle to no longer treat core dependencies that need pipelines in a special way.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #13903:
URL: https://github.com/apache/beam/pull/13903#issuecomment-774195074
R: @robertwb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org