[GitHub] beam pull request #1841: BEAM-1310 Add integration tests for JdbcIO

[ssisk <gi...@git.apache.org>]

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/1841

    BEAM-1310 Add integration tests for JdbcIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Hi @tgroh can you please take a look? (2nd time!)
    
    This adds an integration test & data loading script for Jdbc IO
    
    You'll note there are TODOs for verifying the contents of the rows in the tests - I will get to those, but wanted to get a first, useful test in so that we can continue working on the end to end integration test infrastructure.
    
    This IT demonstrates:
    * Having a separate load script for read tests
    * Using TestPipelineOptions that are not test based, but rather data source based.
    * Writing kubernetes scripts for instantiating an instance of the data source.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam jdbc-it

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1841
    
----
commit e6007397e7d5508a4dfe39cf95ad4e1ceaaa2d6e
Author: Stephen Sisk <si...@google.com>
Date:   2017-01-25T01:56:35Z

    Add pg IT, load script and k8 script for JdbcIO

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1841: BEAM-1310 Add integration tests for JdbcIO

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1841


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---