You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "sainadh777 (via GitHub)" <gi...@apache.org> on 2026/09/19 20:50:27 UTC
[PR] Enforce write interest registration state [tomcat]
sainadh777 opened a new pull request, #1072:
URL: https://github.com/apache/tomcat/pull/1072
## Summary
- Complete TODO 17.1 by rejecting duplicate write-interest registration with a localized IllegalStateException until the pending callback begins.
- Clear the registration when OPEN_WRITE processing starts, or when blocking and vectored write continuations consume poller readiness.
- Add focused state-transition tests, update the Coyote changelog, and remove the completed TODO.
## Validation
- ant validate
- ant test -Dtest.entry=org.apache.tomcat.util.net.TestSocketWrapperBase (2 tests)
- ant test -Dtest.entry=org.apache.catalina.nonblocking.TestNonBlockingAPI -Dtest.entry.methods=testNonBlockingWrite,testNonBlockingWriteWithKeepAlive (2 tests)
- ant clean && ant
- Full unfiltered ant test: 656 suites, 41,398 tests, 0 failures, 0 errors, 328 skips
- Built distribution smoke: HTTP 200 from /, clean shutdown and no remaining listeners
Draft for maintainer review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Enforce write interest registration state [tomcat]
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #1072:
URL: https://github.com/apache/tomcat/pull/1072#issuecomment-5757916334
This change is very risky and the TODO might not be accurate anymore. But it is good that the testsuite passes (even though this does not prove reliability). The test is a mock so there's no point adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Enforce write interest registration state [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #1072:
URL: https://github.com/apache/tomcat/pull/1072#issuecomment-5784503669
Agreed on the pointlessness of the test.
Why not deregister in the Poller rather than all the places the Poller calls?
The back-ports for this will be non-trivial since NIO2 has been removed in trunk. After a quick look at the NIO2 code it might already have suitable protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Enforce write interest registration state [tomcat]
Posted by "sainadh777 (via GitHub)" <gi...@apache.org>.
sainadh777 closed pull request #1072: Enforce write interest registration state
URL: https://github.com/apache/tomcat/pull/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Enforce write interest registration state [tomcat]
Posted by "sainadh777 (via GitHub)" <gi...@apache.org>.
sainadh777 commented on PR #1072:
URL: https://github.com/apache/tomcat/pull/1072#issuecomment-5745207293
@markt-asf @rmaucher Could you review the write-interest state transition and the poller callback clearing points when convenient? This implements TODO 17.1; the full suite and runtime smoke are green. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org