You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/06 18:04:58 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #5442: Py3 component tests fixes
DaanHoogland opened a new pull request, #5442:
URL: https://github.com/apache/cloudstack/pull/5442
### Description
This PR is a continuation of work in #5082. aiming to have a full set of component tests running on all hypervisors.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
To Be Refined:
- [ ] test_add_remove_network.py
- [ ] test_affinity_groups_projects.py
- [ ] test_affinity_groups.py
- [ ] test_base_image_updation.py
- [ ] test_blocker_bugs.py
- [ ] test_browse_templates.py
- [ ] test_browse_volumes.py
- [ ] test_bugs.py
- [ ] test_configdrive.py
- [ ] test_dedicate_guest_vlan_ranges.py
- [ ] test_dedicate_public_ip_range.py
- [ ] test_dhcp_dns_offload.py
- [ ] test_egress_fw_rules.py
- [ ] test_escalation_listTemplateDomainAdmin.py
- [ ] test_escalations_hosts.py
- [ ] test_escalations_ipaddresses.py
- [ ] test_escalations_networks.py
- [ ] test_escalations_volumes.py
- [ ] test_escalations_vpncustomergateways.py
- [ ] test_escalation_templates.py
- [ ] test_explicit_dedication.py
- [ ] test_ha_pool_maintenance.py
- [ ] test_high_availability.py
- [ ] test_implicit_planner.py
- [ ] test_ip_resource_count_for_vpc.py
- [ ] test_multiple_public_interfaces.py
- [ ] test_organization_states.py
- [ ] test_persistent_networks.py
- [ ] test_portable_ip.py
- [ ] test_ps_resource_limits_volume.py
- [ ] test_redundant_router_cleanups.py
- [ ] test_redundant_router_deployment_planning.py
- [ ] test_redundant_router_network_rules.py
- [ ] test_redundant_router.py
- [ ] test_reset_ssh_keypair.py
- [ ] test_rootvolume_resize.py
- [ ] test_shared_networks.py
- [ ] test_snapshots.py
- [ ] test_ss_limits.py
- [ ] test_ss_max_limits.py
- [ ] test_ss_project_limits.py
- [ ] test_stopped_vm.py
- [ ] test_storage_motion.py
- [ ] test_tags.py
- [ ] test_volumes.py
- [ ] test_vpc_host_maintenance.py
- [ ] test_vpc_network_internal_lbrules.py
- [ ] test_vpc_network_pfrules.py
- [ ] test_vpc_network.py
- [ ] test_vpc_network_staticnatrule.py
- [ ] test_vpc_offerings.py
- [ ] test_vpc_routers.py
- [ ] test_vpc_vm_life_cycle.py
- [ ] test_vpc_vms_deployment.py
- [ ] test_vpn_service.py
- [ ] test_vpn_users.py
- [ ] test_vr_metadata.py
- [ ] test_zone_level_local_storage_setting.py
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#discussion_r874775420
##########
test/integration/component/test_host_ha.py:
##########
@@ -17,22 +17,19 @@
""" BVT tests for Hosts Maintenance
"""
-# Import Local Modules
-from marvin.codes import FAILED
from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
from marvin.lib.utils import *
from marvin.lib.base import *
from marvin.lib.common import *
from nose.plugins.attrib import attr
-from time import sleep
-
_multiprocess_shared_ = False
class TestHostHA(cloudstackTestCase):
+ hostCountMsg = "Host HA can be tested with at least two hosts, only %s found"
Review Comment:
no? this is test_host_ha, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#issuecomment-1149826925
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#discussion_r875505490
##########
test/integration/component/test_host_ha.py:
##########
@@ -17,22 +17,19 @@
""" BVT tests for Hosts Maintenance
"""
-# Import Local Modules
-from marvin.codes import FAILED
from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
from marvin.lib.utils import *
from marvin.lib.base import *
from marvin.lib.common import *
from nose.plugins.attrib import attr
-from time import sleep
-
_multiprocess_shared_ = False
class TestHostHA(cloudstackTestCase):
+ hostCountMsg = "Host HA can be tested with at least two hosts, only %s found"
Review Comment:
~Not I'm asking even though file says `test_host_ha.py`, are the tests for Host HA (or VM HA) that uses oobm/ipmi etc? Nevermind I'll check this myself.~
Tests are host ha indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#discussion_r875505490
##########
test/integration/component/test_host_ha.py:
##########
@@ -17,22 +17,19 @@
""" BVT tests for Hosts Maintenance
"""
-# Import Local Modules
-from marvin.codes import FAILED
from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
from marvin.lib.utils import *
from marvin.lib.base import *
from marvin.lib.common import *
from nose.plugins.attrib import attr
-from time import sleep
-
_multiprocess_shared_ = False
class TestHostHA(cloudstackTestCase):
+ hostCountMsg = "Host HA can be tested with at least two hosts, only %s found"
Review Comment:
Not I'm asking even though file says `test_host_ha.py`, are the tests for Host HA (or VM HA) that uses oobm/ipmi etc? Nevermind I'll check this myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#issuecomment-1149942253
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #5442: Py3 component tests fixes
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #5442: Py3 component tests fixes
URL: https://github.com/apache/cloudstack/pull/5442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#discussion_r874681692
##########
test/integration/component/test_host_ha.py:
##########
@@ -17,22 +17,19 @@
""" BVT tests for Hosts Maintenance
"""
-# Import Local Modules
-from marvin.codes import FAILED
from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
from marvin.lib.utils import *
from marvin.lib.base import *
from marvin.lib.common import *
from nose.plugins.attrib import attr
-from time import sleep
-
_multiprocess_shared_ = False
class TestHostHA(cloudstackTestCase):
+ hostCountMsg = "Host HA can be tested with at least two hosts, only %s found"
Review Comment:
not related but - isn't this VM HA? (not host HA with ipmi etc?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#discussion_r893543503
##########
test/integration/broken/test_vpc_vm_life_cycle.py:
##########
@@ -19,7 +19,7 @@
from component.test_vpc_vm_life_cycle import Services
-class TestVMLifeCycleSharedNwVPC(cloudstackTesTODOtCase):
+class TestVMLifeCycleSharedNwVPC(cloudstackTestCase):
Review Comment:
Is this file ready to be moved out of the 'broken' directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5442: some component tests fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5442:
URL: https://github.com/apache/cloudstack/pull/5442#issuecomment-1149829003
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org