[GitHub] [hive] soumyakanti3578 commented on a change in pull request #1959: [DRAFT] Upgrade calcite to 1.25

[GitBox <gi...@apache.org>]

soumyakanti3578 commented on a change in pull request #1959:
URL: https://github.com/apache/hive/pull/1959#discussion_r572918961



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/ChildExpsRexShuttle.java
##########
@@ -0,0 +1,113 @@
+package org.apache.hadoop.hive.ql.optimizer.calcite;
+
+import org.apache.calcite.rex.*;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+public class ChildExpsRexShuttle extends RexShuttle {
+    private final List<RexNode> exps;
+
+    public ChildExpsRexShuttle(List<RexNode> exps) {
+        this.exps = exps;
+    }
+
+    @Override
+    public RexNode visitOver(RexOver over) {
+        exps.add(over);
+        return super.visitOver(over);

Review comment:
       In that case, should we just return the appropriate method arguments here or just return `null` as we are not calling these methods explicitly anywhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org