[GitHub] [spark] beliefer commented on a change in pull request #24229: [SPARK-27275][CORE] Fix potential corruption in EncryptedMessage.transferTo (2.4)

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #24229: [SPARK-27275][CORE] Fix potential corruption in EncryptedMessage.transferTo (2.4)
URL: https://github.com/apache/spark/pull/24229#discussion_r269841713
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java
 ##########
 @@ -84,7 +85,8 @@ SecretKeySpec getKey() {
     return outIv;
   }
 
-  private CryptoOutputStream createOutputStream(WritableByteChannel ch) throws IOException {
+  @VisibleForTesting
 
 Review comment:
   You use a `VisibleForTesting` annotation to release modifier `private`, just for junit?
   Maybe Encapsulation a top class used for junit is better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org