You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/04 16:15:54 UTC

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11155: chore: cleanup fab update perms

john-bodley commented on a change in pull request #11155:
URL: https://github.com/apache/incubator-superset/pull/11155#discussion_r499262881



##########
File path: superset/app.py
##########
@@ -552,7 +552,6 @@ def configure_fab(self) -> None:
         appbuilder.indexview = SupersetIndexView
         appbuilder.base_template = "superset/base.html"
         appbuilder.security_manager_class = custom_sm
-        appbuilder.update_perms = False

Review comment:
       This is already `False` per [here](https://github.com/apache/incubator-superset/blob/3a08fd04f3f9ebaaa48fa554028c26062de42f02/superset/extensions.py#L135) which is set by FAB either [here](https://github.com/dpgaspar/Flask-AppBuilder/blob/120bc3ca38c4559a0099fe3b1a1badb319b6546e/flask_appbuilder/base.py#L145) and potentially reset [here](https://github.com/dpgaspar/Flask-AppBuilder/blob/120bc3ca38c4559a0099fe3b1a1badb319b6546e/flask_appbuilder/base.py#L186-L187), though isn't since `self.update_perms` is already `False`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org