You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/27 21:15:13 UTC

Review Request 68531: Windows: Ported `OsTest.Environment`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68531/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5813
    https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
-------

This required replacing `os::raw::environment()` inline as it does not
exist on Windows. Furthermore, it was also discovered that the
documentation is incorrect, and that sometimes environment variables
start with an equal sign. The fix is to simply look for the first
equal sign excluding the first character, otherwise we end up with
empty keys.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/environment.hpp 40eee59ac0b73ebe71b120e540ba7eace672ff4c 
  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68531/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68531: Windows: Ported `OsTest.Environment`.

Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68531/#review207995
-----------------------------------------------------------


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:15 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68531/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2018, 9:15 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
>     https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This required replacing `os::raw::environment()` inline as it does not
> exist on Windows. Furthermore, it was also discovered that the
> documentation is incorrect, and that sometimes environment variables
> start with an equal sign. The fix is to simply look for the first
> equal sign excluding the first character, otherwise we end up with
> empty keys.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/environment.hpp 40eee59ac0b73ebe71b120e540ba7eace672ff4c 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68531/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>