[jira] [Updated] (OAK-2840) Login Benchmark Test broken due to OAK-2128

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-2840:
------------------------
    Attachment: OAK-2840.patch

proposed patch. i don't fully understand why it matters but without the patch i always get:

{code}
java.lang.IllegalStateException: This tree does not exist
	at org.apache.jackrabbit.oak.core.MutableTree.beforeWrite(MutableTree.java:353)
	at org.apache.jackrabbit.oak.core.MutableTree.setProperty(MutableTree.java:232)
	at org.apache.jackrabbit.oak.plugins.name.ReadWriteNamespaceRegistry.registerNamespace(ReadWriteNamespaceRegistry.java:92)
	at org.apache.jackrabbit.commons.cnd.TemplateBuilderFactory.setNamespace(TemplateBuilderFactory.java:92)
	at org.apache.jackrabbit.commons.cnd.CompactNodeTypeDefReader.doNameSpace(CompactNodeTypeDefReader.java:246)
	at org.apache.jackrabbit.commons.cnd.CompactNodeTypeDefReader.parse(CompactNodeTypeDefReader.java:200)
	at org.apache.jackrabbit.commons.cnd.CompactNodeTypeDefReader.<init>(CompactNodeTypeDefReader.java:163)
	at org.apache.jackrabbit.commons.cnd.CompactNodeTypeDefReader.<init>(CompactNodeTypeDefReader.java:139)
	at org.apache.jackrabbit.commons.cnd.CndImporter.registerNodeTypes(CndImporter.java:147)
	at org.apache.jackrabbit.oak.plugins.nodetype.write.NodeTypeRegistry.registerNodeTypes(NodeTypeRegistry.java:109)
	at org.apache.jackrabbit.oak.plugins.nodetype.write.NodeTypeRegistry.register(NodeTypeRegistry.java:104)
	at org.apache.jackrabbit.oak.plugins.nodetype.write.NodeTypeRegistry.registerBuiltIn(NodeTypeRegistry.java:86)
	at org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent.initialize(InitialContent.java:112)
	at org.apache.jackrabbit.oak.spi.lifecycle.CompositeInitializer.initialize(CompositeInitializer.java:48)
	at org.apache.jackrabbit.oak.spi.lifecycle.OakInitializer.initialize(OakInitializer.java:42)
	at org.apache.jackrabbit.oak.Oak.createContentRepository(Oak.java:555)
	at org.apache.jackrabbit.oak.jcr.Jcr.createRepository(Jcr.java:202)
	at org.apache.jackrabbit.oak.fixture.OakRepositoryFixture.setUpCluster(OakRepositoryFixture.java:98)
	at org.apache.jackrabbit.oak.benchmark.AbstractLoginTest.createRepository(AbstractLoginTest.java:108)
	at org.apache.jackrabbit.oak.benchmark.AbstractTest.run(AbstractTest.java:194)
	at org.apache.jackrabbit.oak.benchmark.LoginWithMembersTest.run(LoginWithMembersTest.java:36)
	at org.apache.jackrabbit.oak.benchmark.BenchmarkRunner.main(BenchmarkRunner.java:341)
	at org.apache.jackrabbit.oak.run.Main.main(Main.java:149)
{code}

when executing the test with the dedicated separate setup (i.e. with no_of_iterations != -1).

> Login Benchmark Test broken due to OAK-2128
> -------------------------------------------
>
>                 Key: OAK-2840
>                 URL: https://issues.apache.org/jira/browse/OAK-2840
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: run
>            Reporter: angela
>            Assignee: Amit Jain
>             Fix For: 1.3.0
>
>         Attachments: OAK-2840.patch
>
>
> As mentioned ages ago in an Oak call, the login related benchmark tests are broken when specifying a value other than -1 for the iterations. This is easily reproducible when setting 
> {code}
> HASH_ITERATIONS="1"
> {code}
> in the concurrent-login-test script.
> It seems to me that this was broken when addressing OAK-2128. It took me some time finding a fix (see attached patch).
> [~amitjain], since you committed the changes for OAK-2128, may I kindly ask you to verify the proposed patch (will follow) and commit the fix? thanks in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)