You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@gmail.com> on 2018/12/24 22:35:13 UTC
Ejemplos en Español
I was talking with Hillmer on twitter about potentially translating examples into Spanish.
The idea is that we could potentially do examples and documentation in Spanish. Perhaps:
- http://tomee.apache.org/tomee-8.0/es/docs/
- http://tomee.apache.org/tomee-8.0/es/ejemplos/
First note is that how we organize the files in the git repo and how we organize them on the website can be completely different. We use the following code to collect all the examples together and do various things to them:
- https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
Right now it will do a copy and rename, for example:
- https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
- http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
We could theoretically do something as simple as this:
- https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
- http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
I.e. make a new file next to the original, then update our copying logic to put the prefix in the path.
Thoughts?
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
Re: Ejemplos en Español
Posted by Rodrigo Graciano <ro...@gmail.com>.
I can help with Portuguese
On Wed, Jan 2, 2019 at 7:10 PM César Hernández Mendoza <ce...@gmail.com>
wrote:
> +1
> I can definitely help on this one and amplify the initiative to the Latin
> America community on the translation epic :)!
>
> I created the main Task for this initiative:
> https://issues.apache.org/jira/browse/TOMEE-2442
>
> @David, do you have already a PR that can be associated with this Task?
>
>
> El vie., 28 dic. 2018 a las 8:13, Otávio Gonçalves de Santana (<
> osantana@tomitribe.com>) escribió:
>
> > +1
> >
> > On Wed, Dec 26, 2018 at 9:11 AM Daniel Cunha <da...@gmail.com>
> wrote:
> >
> > > +1
> > >
> > > Em qua, 26 de dez de 2018 7:34 AM, Bruno Baptista <brunobat@gmail.com
> > > escreveu:
> > >
> > > > +1
> > > >
> > > > Bruno Baptista
> > > > https://twitter.com/brunobat_
> > > >
> > > >
> > > > On 24/12/18 22:35, David Blevins wrote:
> > > > > I was talking with Hillmer on twitter about potentially translating
> > > > examples into Spanish.
> > > > >
> > > > > The idea is that we could potentially do examples and documentation
> > in
> > > > Spanish. Perhaps:
> > > > >
> > > > > - http://tomee.apache.org/tomee-8.0/es/docs/
> > > > > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> > > > >
> > > > > First note is that how we organize the files in the git repo and
> how
> > we
> > > > organize them on the website can be completely different. We use the
> > > > following code to collect all the examples together and do various
> > things
> > > > to them:
> > > > >
> > > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> > > > >
> > > > > Right now it will do a copy and rename, for example:
> > > > >
> > > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > > > > -
> > http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> > > > >
> > > > > We could theoretically do something as simple as this:
> > > > >
> > > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > > > > -
> > > http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> > > > >
> > > > > I.e. make a new file next to the original, then update our copying
> > > logic
> > > > to put the prefix in the path.
> > > > >
> > > > >
> > > > > Thoughts?
> > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>
--
Rodrigo Graciano
rodrigolgraciano@gmail.com
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
+1
I can definitely help on this one and amplify the initiative to the Latin
America community on the translation epic :)!
I created the main Task for this initiative:
https://issues.apache.org/jira/browse/TOMEE-2442
@David, do you have already a PR that can be associated with this Task?
El vie., 28 dic. 2018 a las 8:13, Otávio Gonçalves de Santana (<
osantana@tomitribe.com>) escribió:
> +1
>
> On Wed, Dec 26, 2018 at 9:11 AM Daniel Cunha <da...@gmail.com> wrote:
>
> > +1
> >
> > Em qua, 26 de dez de 2018 7:34 AM, Bruno Baptista <brunobat@gmail.com
> > escreveu:
> >
> > > +1
> > >
> > > Bruno Baptista
> > > https://twitter.com/brunobat_
> > >
> > >
> > > On 24/12/18 22:35, David Blevins wrote:
> > > > I was talking with Hillmer on twitter about potentially translating
> > > examples into Spanish.
> > > >
> > > > The idea is that we could potentially do examples and documentation
> in
> > > Spanish. Perhaps:
> > > >
> > > > - http://tomee.apache.org/tomee-8.0/es/docs/
> > > > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> > > >
> > > > First note is that how we organize the files in the git repo and how
> we
> > > organize them on the website can be completely different. We use the
> > > following code to collect all the examples together and do various
> things
> > > to them:
> > > >
> > > > -
> > >
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> > > >
> > > > Right now it will do a copy and rename, for example:
> > > >
> > > > -
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > > > -
> http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> > > >
> > > > We could theoretically do something as simple as this:
> > > >
> > > > -
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > > > -
> > http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> > > >
> > > > I.e. make a new file next to the original, then update our copying
> > logic
> > > to put the prefix in the path.
> > > >
> > > >
> > > > Thoughts?
> > > >
> > > >
> > >
> >
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by Otávio Gonçalves de Santana <os...@tomitribe.com>.
+1
On Wed, Dec 26, 2018 at 9:11 AM Daniel Cunha <da...@gmail.com> wrote:
> +1
>
> Em qua, 26 de dez de 2018 7:34 AM, Bruno Baptista <brunobat@gmail.com
> escreveu:
>
> > +1
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 24/12/18 22:35, David Blevins wrote:
> > > I was talking with Hillmer on twitter about potentially translating
> > examples into Spanish.
> > >
> > > The idea is that we could potentially do examples and documentation in
> > Spanish. Perhaps:
> > >
> > > - http://tomee.apache.org/tomee-8.0/es/docs/
> > > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> > >
> > > First note is that how we organize the files in the git repo and how we
> > organize them on the website can be completely different. We use the
> > following code to collect all the examples together and do various things
> > to them:
> > >
> > > -
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> > >
> > > Right now it will do a copy and rename, for example:
> > >
> > > -
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > > - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> > >
> > > We could theoretically do something as simple as this:
> > >
> > > -
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > > -
> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> > >
> > > I.e. make a new file next to the original, then update our copying
> logic
> > to put the prefix in the path.
> > >
> > >
> > > Thoughts?
> > >
> > >
> >
>
Re: Ejemplos en Español
Posted by Daniel Cunha <da...@gmail.com>.
+1
Em qua, 26 de dez de 2018 7:34 AM, Bruno Baptista <brunobat@gmail.com
escreveu:
> +1
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 24/12/18 22:35, David Blevins wrote:
> > I was talking with Hillmer on twitter about potentially translating
> examples into Spanish.
> >
> > The idea is that we could potentially do examples and documentation in
> Spanish. Perhaps:
> >
> > - http://tomee.apache.org/tomee-8.0/es/docs/
> > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> >
> > First note is that how we organize the files in the git repo and how we
> organize them on the website can be completely different. We use the
> following code to collect all the examples together and do various things
> to them:
> >
> > -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> >
> > Right now it will do a copy and rename, for example:
> >
> > -
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> >
> > We could theoretically do something as simple as this:
> >
> > -
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > - http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> >
> > I.e. make a new file next to the original, then update our copying logic
> to put the prefix in the path.
> >
> >
> > Thoughts?
> >
> >
>
Re: Ejemplos en Español
Posted by Bruno Baptista <br...@gmail.com>.
+1
Bruno Baptista
https://twitter.com/brunobat_
On 24/12/18 22:35, David Blevins wrote:
> I was talking with Hillmer on twitter about potentially translating examples into Spanish.
>
> The idea is that we could potentially do examples and documentation in Spanish. Perhaps:
>
> - http://tomee.apache.org/tomee-8.0/es/docs/
> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
>
> First note is that how we organize the files in the git repo and how we organize them on the website can be completely different. We use the following code to collect all the examples together and do various things to them:
>
> - https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
>
> Right now it will do a copy and rename, for example:
>
> - https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
>
> We could theoretically do something as simple as this:
>
> - https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> - http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
>
> I.e. make a new file next to the original, then update our copying logic to put the prefix in the path.
>
>
> Thoughts?
>
>
Re: Ejemplos en Español
Posted by Carlos Chacín <cc...@gmail.com>.
+1
On Tue, Jan 8, 2019 at 12:00 PM Bruno Baptista <br...@gmail.com> wrote:
> +1
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 08/01/19 19:22, David Blevins wrote:
> > My perspective is we should switch this around from:
> >
> > -http://localhost:8080/tomee-8.0/examples/fr/
> >
> > To:
> >
> > -http://localhost:8080/tomee-8.0/fr/examples/
>
--
*Carlos Chacin*
Software Developer Engineering
Re: Ejemplos en Español
Posted by Bruno Baptista <br...@gmail.com>.
+1
Bruno Baptista
https://twitter.com/brunobat_
On 08/01/19 19:22, David Blevins wrote:
> My perspective is we should switch this around from:
>
> -http://localhost:8080/tomee-8.0/examples/fr/
>
> To:
>
> -http://localhost:8080/tomee-8.0/fr/examples/
Re: Ejemplos en Español
Posted by Richard Monson-Haefel <mo...@gmail.com>.
That's not OCD. That's like Sherlock Holmes level of observation!
On Wed, Jan 23, 2019 at 2:23 PM David Blevins <da...@gmail.com>
wrote:
> Working on it now!
>
> Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed
> files, 700 new lines of code and in under 20 seconds of pulling everything
> into my IDE my eyes lock in on and cannot stop staring at the one place you
> used an upper case variable name :)
>
> -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>
> I was only digging because I wanted to change "Examples" to "Ejemplos" and
> I kinda felt bad for giving you too much feedback already.
>
> Seriously, something is wrong with me :)
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > Hi,
> > Can some of the committers please redeploy TomEE website,
> > http://tomee.apache.org/docs.html still doesn't show the translation
> > language available and https://issues.apache.org/jira/browse/TOMEE-2444
> is
> > still marked as Open.
> >
> > El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> > cesarguate@gmail.com>) escribió:
> >
> >> The PR was merged, can someone of the JIRA admins please move forward
> the
> >> ticket?
> >> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> >> tomee website.
> >>
> >> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<brunobat@gmail.com
> >)
> >> escribió:
> >>
> >>> Hi César,
> >>>
> >>> The PR looks ok to me.
> >>>
> >>> Thanks!
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 16/01/19 23:44, César Hernández Mendoza wrote:
> >>>> Hi!
> >>>>
> >>>> I updated the code and now the PR is ready for review.
> >>>> https://github.com/apache/tomee-site-generator/pull/16
> >>>>
> >>>> @Bruno: I fixed the issue that was causing the test failure you
> >>> identified.
> >>>> @David: I implement your proposal of removing "en" to the path of the
> >>>> default language (English).
> >>>>
> >>>>
> >>>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
> >>>> cesarguate@gmail.com>) escribió:
> >>>>
> >>>>> Thank you for the feedback,
> >>>>>
> >>>>> site navigation has links to /latest/examples/ and similar -- people
> >>> were
> >>>>>> issuing PRs for broken links in headers, footers, menues, all dec
> and
> >>>>>> they're finally (hopefully) settled.
> >>>>> That's a good point, I was not aware of this /latest/examples/
> >>> reference
> >>>>> inside the docs and website. I only updated the doc.html page.
> >>>>>
> >>>>> We don't have direct access to the second svn, so I don't know of any
> >>> way
> >>>>>> to avoid doubling the size of that second repo.
> >>>>> I don't follow you entirely on this one. So far my understanding is
> >>> that
> >>>>> the process for building the site is divided into three major steps:
> >>>>>
> >>>>> 1) Download all the branches into: tomee-site-generator/repos
> >>>>> 2) Copy from /repos folder all the branches
> >>>>> into: tomee-site-generator/target/jbake/content
> >>>>> 3) Bake the tomee-site-generator/target/jbake/content folder
> structure
> >>>>> to generate the final website
> >>>>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >>>>>
> >>>>> My PR only touches step 2) without duplicating the content of the
> >>>>> documentation in English. I added /en to standardize in the code the
> >>>>> indexing process that also is performed on step 2) to generate the
> >>>>> index.htmll per documentation Category, and Language on each Branch:
> >>>>>
> >>>>> --tomee-site-generator/target/jbake/content/tomee-8.0
> >>>>> ----- en
> >>>>> |--examples
> >>>>> ----- es
> >>>>> |--examples
> >>>>> ----- index.adoc
> >>>>>
> >>>>>
> >>>>> Tomorrow I'm going to analyze how to remove /en from the website
> >>> structure.
> >>>>>
> >>>>>
> >>>>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> >>> david.blevins@gmail.com>)
> >>>>> escribió:
> >>>>>
> >>>>>> Little feedback on my side of the fence. Can we avoid adding "en"
> to
> >>> the
> >>>>>> path of the default language?
> >>>>>>
> >>>>>> Couple small reasons:
> >>>>>>
> >>>>>> - site navigation has links to /latest/examples/ and similar --
> >>> people
> >>>>>> were issuing PRs for broken links in headers, footers, menues, all
> >>> dec and
> >>>>>> they're finally (hopefully) settled.
> >>>>>>
> >>>>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
> >>> site
> >>>>>> overall is 1.7G. The initial push took a few hours to sync and
> moving
> >>>>>> everything into an 'en/' directory will double the size. The
> process
> >>>>>> actually involves one svn synching to another svn. We don't have
> >>> direct
> >>>>>> access to the second svn, so I don't know of any way to avoid
> >>> doubling the
> >>>>>> size of that second repo.
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> David Blevins
> >>>>>> http://twitter.com/dblevins
> >>>>>> http://www.tomitribe.com
> >>>>>>
> >>>>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> >>>>>> cesarguate@gmail.com> wrote:
> >>>>>>> Thanks Bruno.
> >>>>>>> I'm working on fixing that test and will be back with an updated PR
> >>> when
> >>>>>>> ready.
> >>>>>>>
> >>>>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
> >>> brunobat@gmail.com>)
> >>>>>>> escribió:
> >>>>>>>
> >>>>>>>> Hi César,
> >>>>>>>>
> >>>>>>>> I've reviewed the PR and found an error:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Tests in error:
> >>>>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >>>>>>>> java.io.FileNotFoundException:
> >>>>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
> >>> file or
> >>>>>>>> directory)
> >>>>>>>>
> >>>>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>>>>>>>
> >>>>>>>> [INFO]
> >>>>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>>>>> [INFO] BUILD FAILURE
> >>>>>>>> [INFO]
> >>>>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>>>>> Left a comment in the PR.
> >>>>>>>>
> >>>>>>>> Cheers
> >>>>>>>>
> >>>>>>>> Bruno Baptista
> >>>>>>>> https://twitter.com/brunobat_
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>>>>>>>> Hi all,
> >>>>>>>>> In case somebody is wondering how to review this PR
> >>>>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
> >>>>>>>>> once you have the PR on your local git:
> >>>>>>>>>
> >>>>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>>>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
> >>>>>> compile
> >>>>>>>>> -Djbake.http=true`
> >>>>>>>>> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> >>> <http://localhost:8080/docs.html>
> >>>>>> <http://localhost:8080/docs.html>
> >>>>>>>> <http://localhost:8080/docs.html>
> >>>>>>>>> <http://localhost:8080/docs.html> the [es] link to the examples
> in
> >>>>>>>> Spanish.
> >>>>>>>>> So far tomee master only has 1 readme translated into spanish but
> >>> you
> >>>>>> can
> >>>>>>>>> add more README_es.adoc files to any of your
> >>>>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>>>>>>>
> >>>>>>>>> I'm more than happy to resolve any questions that may arise for
> the
> >>>>>>>> review
> >>>>>>>>> of this PR.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>>>>>>>> cesarguate@gmail.com>) escribió:
> >>>>>>>>>
> >>>>>>>>>> Hi, The new PR with the requested changes is ready for review.
> >>>>>>>>>>
> >>>>>>>>>> Now the internationalization for examples follows the format
> like:
> >>>>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>>>>>>>
> >>>>>>>>>> I added a vide on the ticket:
> >>>>>>>>>>
> >>>>>>
> >>>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >>>>>>>> david.blevins@gmail.com>)
> >>>>>>>>>> escribió:
> >>>>>>>>>>
> >>>>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>>>>>>>> cesarguate@gmail.com> wrote:
> >>>>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
> >>> loops
> >>>>>>>>>>>> while I was studying and learning the code.
> >>>>>>>>>>>> I need to improve my functional skills to refactor that code
> >>> but in
> >>>>>>>> the
> >>>>>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup
> >>> and
> >>>>>>>>>>> sharpness
> >>>>>>>>>>>> once we all agree on the functionality itself.
> >>>>>>>>>>> That's absolutely fine. Work at whatever language level you're
> >>>>>>>>>>> comfortable with.
> >>>>>>>>>>>
> >>>>>>>>>>> I think as a project we should be very ok with people
> simplifying
> >>>>>> code
> >>>>>>>> so
> >>>>>>>>>>> they can understand it -- even if that means removing fancy new
> >>>>>> syntax.
> >>>>>>>>>>>
> >>>>>>>>>>> -David
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Atentamente:
> >>>>>>>>>> César Hernández Mendoza.
> >>>>>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Atentamente:
> >>>>>>> César Hernández Mendoza.
> >>>>>>
> >>>>> --
> >>>>> Atentamente:
> >>>>> César Hernández Mendoza.
> >>>>>
> >>>>
> >>>
> >>
> >>
> >> --
> >> Atentamente:
> >> César Hernández Mendoza.
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi,
I created https://issues.apache.org/jira/browse/TOMEE-2461 to add the
corresponding title and HTML page.
I'm going to fix the uppercase variable too :)
El mié., 23 ene. 2019 a las 17:42, David Blevins (<da...@gmail.com>)
escribió:
> > On Jan 23, 2019, at 1:19 PM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >> ... an upper case variable name :)
> >
> > I really sorry about that horrible typo, somehow it passes under the
> > commits and reviews.
>
> There's nothing to be sorry for -- I thought it was funny :) Besides,
> here is the nature of open source:
>
> 10 people are in a room each with a bag of rice
> 1 of them gives you his bag of rice
> Theres one small rock in the rice, so he apologizes
> The person accepting says "it's ok"
>
> The typical status quo in this story:
>
> - The only person who did anything good is apologizing
> - The only person taking some is the one issuing forgiveness
> - The 9 people who did nothing offer no apology or ask for forgiveness
>
> I always do my best to make sure this status quo is *not* the case. So I
> will once again say, thank YOU Cesar :) A harmless rock in an overall
> generous and rare gift is nothing.
>
> If others want to help, I will help them do so and thank them properly
> like anyone who gets a gift :)
>
> > I can keep pushing forward the improvements and keep hearing feedback is
> > always a good way to know and fix the direction ... like, for example,
> the
> > Upper case variable I added XD.
>
> I already ran out of time to hack, but if you want to try another update
> that makes the url and title "Ejemplos" for the Spanish page, that'd be
> awesome. We could publish with the way it is, but the trick is we won't be
> able to delete that directory if we do.
>
> Good logic for this could be some new method in `Configuration` where we
> could define say
>
> public static Lang[] getLanguages() {
> return new Lang[] {
> new Lang("es", "Ejemplos", /* any future page names could be
> in the constructor */),
> new Lang("fr", "Exemples")
> };
> }
>
> The languages would still be discovered automatically and default to
> "examples", etc., but there'd be some way for someone to come in and
> provide and override it to provide that fine touch.
>
> Another improvement that can easily come later is perhaps inside the
> asciidoc or markdown, there could be
>
> - a "title_es" header next to the "title" header so people could provide
> a translated page name for the description in the index.
> - a "name_es" so people could supply a file name in the URL so pages
> like "alternate-descriptors.html" become "descriptores-alternativos.html"
> (or whatever the right translation is :)
>
> I think people seeing we go the extra mile will really encourage
> contribution.
>
> There's such a strong latino community (Spanish and Portuguese) I can
> easily imagine new examples coming in first in Spanish or Portuguese :) A
> little leadership there and it would be a great way to show the latino
> community how strong it really is, and bring some pride from a friendly bit
> of English/Spanish/Portuguese competition :)
>
>
> -David
>
> >
> > El mié., 23 ene. 2019 a las 14:23, David Blevins (<
> david.blevins@gmail.com>)
> > escribió:
> >
> >> Working on it now!
> >>
> >> Off topic: My OCD is scaring even myself. You've got 7 commits, 9
> changed
> >> files, 700 new lines of code and in under 20 seconds of pulling
> everything
> >> into my IDE my eyes lock in on and cannot stop staring at the one place
> you
> >> used an upper case variable name :)
> >>
> >> -
> >>
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
> >>
> >> I was only digging because I wanted to change "Examples" to "Ejemplos"
> and
> >> I kinda felt bad for giving you too much feedback already.
> >>
> >> Seriously, something is wrong with me :)
> >>
> >>
> >>
> >> --
> >> David Blevins
> >> http://twitter.com/dblevins
> >> http://www.tomitribe.com
> >>
> >>> On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
> >> cesarguate@gmail.com> wrote:
> >>>
> >>> Hi,
> >>> Can some of the committers please redeploy TomEE website,
> >>> http://tomee.apache.org/docs.html still doesn't show the translation
> >>> language available and
> https://issues.apache.org/jira/browse/TOMEE-2444
> >> is
> >>> still marked as Open.
> >>>
> >>> El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> >>> cesarguate@gmail.com>) escribió:
> >>>
> >>>> The PR was merged, can someone of the JIRA admins please move forward
> >> the
> >>>> ticket?
> >>>> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> >>>> tomee website.
> >>>>
> >>>> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<
> brunobat@gmail.com
> >>> )
> >>>> escribió:
> >>>>
> >>>>> Hi César,
> >>>>>
> >>>>> The PR looks ok to me.
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>> Bruno Baptista
> >>>>> https://twitter.com/brunobat_
> >>>>>
> >>>>>
> >>>>> On 16/01/19 23:44, César Hernández Mendoza wrote:
> >>>>>> Hi!
> >>>>>>
> >>>>>> I updated the code and now the PR is ready for review.
> >>>>>> https://github.com/apache/tomee-site-generator/pull/16
> >>>>>>
> >>>>>> @Bruno: I fixed the issue that was causing the test failure you
> >>>>> identified.
> >>>>>> @David: I implement your proposal of removing "en" to the path of
> the
> >>>>>> default language (English).
> >>>>>>
> >>>>>>
> >>>>>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
> >>>>>> cesarguate@gmail.com>) escribió:
> >>>>>>
> >>>>>>> Thank you for the feedback,
> >>>>>>>
> >>>>>>> site navigation has links to /latest/examples/ and similar --
> people
> >>>>> were
> >>>>>>>> issuing PRs for broken links in headers, footers, menues, all dec
> >> and
> >>>>>>>> they're finally (hopefully) settled.
> >>>>>>> That's a good point, I was not aware of this /latest/examples/
> >>>>> reference
> >>>>>>> inside the docs and website. I only updated the doc.html page.
> >>>>>>>
> >>>>>>> We don't have direct access to the second svn, so I don't know of
> any
> >>>>> way
> >>>>>>>> to avoid doubling the size of that second repo.
> >>>>>>> I don't follow you entirely on this one. So far my understanding is
> >>>>> that
> >>>>>>> the process for building the site is divided into three major
> steps:
> >>>>>>>
> >>>>>>> 1) Download all the branches into: tomee-site-generator/repos
> >>>>>>> 2) Copy from /repos folder all the branches
> >>>>>>> into: tomee-site-generator/target/jbake/content
> >>>>>>> 3) Bake the tomee-site-generator/target/jbake/content folder
> >> structure
> >>>>>>> to generate the final website
> >>>>>>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >>>>>>>
> >>>>>>> My PR only touches step 2) without duplicating the content of the
> >>>>>>> documentation in English. I added /en to standardize in the code
> the
> >>>>>>> indexing process that also is performed on step 2) to generate the
> >>>>>>> index.htmll per documentation Category, and Language on each
> Branch:
> >>>>>>>
> >>>>>>> --tomee-site-generator/target/jbake/content/tomee-8.0
> >>>>>>> ----- en
> >>>>>>> |--examples
> >>>>>>> ----- es
> >>>>>>> |--examples
> >>>>>>> ----- index.adoc
> >>>>>>>
> >>>>>>>
> >>>>>>> Tomorrow I'm going to analyze how to remove /en from the website
> >>>>> structure.
> >>>>>>>
> >>>>>>>
> >>>>>>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> >>>>> david.blevins@gmail.com>)
> >>>>>>> escribió:
> >>>>>>>
> >>>>>>>> Little feedback on my side of the fence. Can we avoid adding "en"
> >> to
> >>>>> the
> >>>>>>>> path of the default language?
> >>>>>>>>
> >>>>>>>> Couple small reasons:
> >>>>>>>>
> >>>>>>>> - site navigation has links to /latest/examples/ and similar --
> >>>>> people
> >>>>>>>> were issuing PRs for broken links in headers, footers, menues, all
> >>>>> dec and
> >>>>>>>> they're finally (hopefully) settled.
> >>>>>>>>
> >>>>>>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
> >>>>> site
> >>>>>>>> overall is 1.7G. The initial push took a few hours to sync and
> >> moving
> >>>>>>>> everything into an 'en/' directory will double the size. The
> >> process
> >>>>>>>> actually involves one svn synching to another svn. We don't have
> >>>>> direct
> >>>>>>>> access to the second svn, so I don't know of any way to avoid
> >>>>> doubling the
> >>>>>>>> size of that second repo.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> David Blevins
> >>>>>>>> http://twitter.com/dblevins
> >>>>>>>> http://www.tomitribe.com
> >>>>>>>>
> >>>>>>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> >>>>>>>> cesarguate@gmail.com> wrote:
> >>>>>>>>> Thanks Bruno.
> >>>>>>>>> I'm working on fixing that test and will be back with an updated
> PR
> >>>>> when
> >>>>>>>>> ready.
> >>>>>>>>>
> >>>>>>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
> >>>>> brunobat@gmail.com>)
> >>>>>>>>> escribió:
> >>>>>>>>>
> >>>>>>>>>> Hi César,
> >>>>>>>>>>
> >>>>>>>>>> I've reviewed the PR and found an error:
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Tests in error:
> >>>>>>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >>>>>>>>>> java.io.FileNotFoundException:
> >>>>>>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
> >>>>> file or
> >>>>>>>>>> directory)
> >>>>>>>>>>
> >>>>>>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>>>>>>>>>
> >>>>>>>>>> [INFO]
> >>>>>>>>>>
> >>>>>>>>
> >>>>>
> >> ------------------------------------------------------------------------
> >>>>>>>>>> [INFO] BUILD FAILURE
> >>>>>>>>>> [INFO]
> >>>>>>>>>>
> >>>>>>>>
> >>>>>
> >> ------------------------------------------------------------------------
> >>>>>>>>>> Left a comment in the PR.
> >>>>>>>>>>
> >>>>>>>>>> Cheers
> >>>>>>>>>>
> >>>>>>>>>> Bruno Baptista
> >>>>>>>>>> https://twitter.com/brunobat_
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>>>>>>>>>> Hi all,
> >>>>>>>>>>> In case somebody is wondering how to review this PR
> >>>>>>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
> >>>>>>>>>>> once you have the PR on your local git:
> >>>>>>>>>>>
> >>>>>>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>>>>>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
> >>>>>>>> compile
> >>>>>>>>>>> -Djbake.http=true`
> >>>>>>>>>>> 4. The project should show in `
> http://localhost:8080/docs.html` <http://localhost:8080/docs.html>
> >> <http://localhost:8080/docs.html>
> >>>>> <http://localhost:8080/docs.html>
> >>>>>>>> <http://localhost:8080/docs.html>
> >>>>>>>>>> <http://localhost:8080/docs.html>
> >>>>>>>>>>> <http://localhost:8080/docs.html> the [es] link to the
> examples
> >> in
> >>>>>>>>>> Spanish.
> >>>>>>>>>>> So far tomee master only has 1 readme translated into spanish
> but
> >>>>> you
> >>>>>>>> can
> >>>>>>>>>>> add more README_es.adoc files to any of your
> >>>>>>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>>>>>>>>>
> >>>>>>>>>>> I'm more than happy to resolve any questions that may arise for
> >> the
> >>>>>>>>>> review
> >>>>>>>>>>> of this PR.
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>>>>>>>>>> cesarguate@gmail.com>) escribió:
> >>>>>>>>>>>
> >>>>>>>>>>>> Hi, The new PR with the requested changes is ready for review.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Now the internationalization for examples follows the format
> >> like:
> >>>>>>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>>>>>>>>>
> >>>>>>>>>>>> I added a vide on the ticket:
> >>>>>>>>>>>>
> >>>>>>>>
> >>>>>
> >>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>>>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >>>>>>>>>> david.blevins@gmail.com>)
> >>>>>>>>>>>> escribió:
> >>>>>>>>>>>>
> >>>>>>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>>>>>>>>>> cesarguate@gmail.com> wrote:
> >>>>>>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
> >>>>> loops
> >>>>>>>>>>>>>> while I was studying and learning the code.
> >>>>>>>>>>>>>> I need to improve my functional skills to refactor that code
> >>>>> but in
> >>>>>>>>>> the
> >>>>>>>>>>>>>> meantime, I'm moving forward and will tackle the code
> cleanup
> >>>>> and
> >>>>>>>>>>>>> sharpness
> >>>>>>>>>>>>>> once we all agree on the functionality itself.
> >>>>>>>>>>>>> That's absolutely fine. Work at whatever language level
> you're
> >>>>>>>>>>>>> comfortable with.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I think as a project we should be very ok with people
> >> simplifying
> >>>>>>>> code
> >>>>>>>>>> so
> >>>>>>>>>>>>> they can understand it -- even if that means removing fancy
> new
> >>>>>>>> syntax.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> -David
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Atentamente:
> >>>>>>>>>>>> César Hernández Mendoza.
> >>>>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Atentamente:
> >>>>>>>>> César Hernández Mendoza.
> >>>>>>>>
> >>>>>>> --
> >>>>>>> Atentamente:
> >>>>>>> César Hernández Mendoza.
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Atentamente:
> >>>> César Hernández Mendoza.
> >>>>
> >>>
> >>>
> >>> --
> >>> Atentamente:
> >>> César Hernández Mendoza.
> >>
> >>
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
> On Jan 23, 2019, at 1:19 PM, César Hernández Mendoza <ce...@gmail.com> wrote:
>> ... an upper case variable name :)
>
> I really sorry about that horrible typo, somehow it passes under the
> commits and reviews.
There's nothing to be sorry for -- I thought it was funny :) Besides, here is the nature of open source:
10 people are in a room each with a bag of rice
1 of them gives you his bag of rice
Theres one small rock in the rice, so he apologizes
The person accepting says "it's ok"
The typical status quo in this story:
- The only person who did anything good is apologizing
- The only person taking some is the one issuing forgiveness
- The 9 people who did nothing offer no apology or ask for forgiveness
I always do my best to make sure this status quo is *not* the case. So I will once again say, thank YOU Cesar :) A harmless rock in an overall generous and rare gift is nothing.
If others want to help, I will help them do so and thank them properly like anyone who gets a gift :)
> I can keep pushing forward the improvements and keep hearing feedback is
> always a good way to know and fix the direction ... like, for example, the
> Upper case variable I added XD.
I already ran out of time to hack, but if you want to try another update that makes the url and title "Ejemplos" for the Spanish page, that'd be awesome. We could publish with the way it is, but the trick is we won't be able to delete that directory if we do.
Good logic for this could be some new method in `Configuration` where we could define say
public static Lang[] getLanguages() {
return new Lang[] {
new Lang("es", "Ejemplos", /* any future page names could be in the constructor */),
new Lang("fr", "Exemples")
};
}
The languages would still be discovered automatically and default to "examples", etc., but there'd be some way for someone to come in and provide and override it to provide that fine touch.
Another improvement that can easily come later is perhaps inside the asciidoc or markdown, there could be
- a "title_es" header next to the "title" header so people could provide a translated page name for the description in the index.
- a "name_es" so people could supply a file name in the URL so pages like "alternate-descriptors.html" become "descriptores-alternativos.html" (or whatever the right translation is :)
I think people seeing we go the extra mile will really encourage contribution.
There's such a strong latino community (Spanish and Portuguese) I can easily imagine new examples coming in first in Spanish or Portuguese :) A little leadership there and it would be a great way to show the latino community how strong it really is, and bring some pride from a friendly bit of English/Spanish/Portuguese competition :)
-David
>
> El mié., 23 ene. 2019 a las 14:23, David Blevins (<da...@gmail.com>)
> escribió:
>
>> Working on it now!
>>
>> Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed
>> files, 700 new lines of code and in under 20 seconds of pulling everything
>> into my IDE my eyes lock in on and cannot stop staring at the one place you
>> used an upper case variable name :)
>>
>> -
>> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>>
>> I was only digging because I wanted to change "Examples" to "Ejemplos" and
>> I kinda felt bad for giving you too much feedback already.
>>
>> Seriously, something is wrong with me :)
>>
>>
>>
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>>
>>> On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
>> cesarguate@gmail.com> wrote:
>>>
>>> Hi,
>>> Can some of the committers please redeploy TomEE website,
>>> http://tomee.apache.org/docs.html still doesn't show the translation
>>> language available and https://issues.apache.org/jira/browse/TOMEE-2444
>> is
>>> still marked as Open.
>>>
>>> El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
>>> cesarguate@gmail.com>) escribió:
>>>
>>>> The PR was merged, can someone of the JIRA admins please move forward
>> the
>>>> ticket?
>>>> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
>>>> tomee website.
>>>>
>>>> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<brunobat@gmail.com
>>> )
>>>> escribió:
>>>>
>>>>> Hi César,
>>>>>
>>>>> The PR looks ok to me.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Bruno Baptista
>>>>> https://twitter.com/brunobat_
>>>>>
>>>>>
>>>>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>>>>>> Hi!
>>>>>>
>>>>>> I updated the code and now the PR is ready for review.
>>>>>> https://github.com/apache/tomee-site-generator/pull/16
>>>>>>
>>>>>> @Bruno: I fixed the issue that was causing the test failure you
>>>>> identified.
>>>>>> @David: I implement your proposal of removing "en" to the path of the
>>>>>> default language (English).
>>>>>>
>>>>>>
>>>>>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>>>>>> cesarguate@gmail.com>) escribió:
>>>>>>
>>>>>>> Thank you for the feedback,
>>>>>>>
>>>>>>> site navigation has links to /latest/examples/ and similar -- people
>>>>> were
>>>>>>>> issuing PRs for broken links in headers, footers, menues, all dec
>> and
>>>>>>>> they're finally (hopefully) settled.
>>>>>>> That's a good point, I was not aware of this /latest/examples/
>>>>> reference
>>>>>>> inside the docs and website. I only updated the doc.html page.
>>>>>>>
>>>>>>> We don't have direct access to the second svn, so I don't know of any
>>>>> way
>>>>>>>> to avoid doubling the size of that second repo.
>>>>>>> I don't follow you entirely on this one. So far my understanding is
>>>>> that
>>>>>>> the process for building the site is divided into three major steps:
>>>>>>>
>>>>>>> 1) Download all the branches into: tomee-site-generator/repos
>>>>>>> 2) Copy from /repos folder all the branches
>>>>>>> into: tomee-site-generator/target/jbake/content
>>>>>>> 3) Bake the tomee-site-generator/target/jbake/content folder
>> structure
>>>>>>> to generate the final website
>>>>>>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>>>>>>>
>>>>>>> My PR only touches step 2) without duplicating the content of the
>>>>>>> documentation in English. I added /en to standardize in the code the
>>>>>>> indexing process that also is performed on step 2) to generate the
>>>>>>> index.htmll per documentation Category, and Language on each Branch:
>>>>>>>
>>>>>>> --tomee-site-generator/target/jbake/content/tomee-8.0
>>>>>>> ----- en
>>>>>>> |--examples
>>>>>>> ----- es
>>>>>>> |--examples
>>>>>>> ----- index.adoc
>>>>>>>
>>>>>>>
>>>>>>> Tomorrow I'm going to analyze how to remove /en from the website
>>>>> structure.
>>>>>>>
>>>>>>>
>>>>>>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
>>>>> david.blevins@gmail.com>)
>>>>>>> escribió:
>>>>>>>
>>>>>>>> Little feedback on my side of the fence. Can we avoid adding "en"
>> to
>>>>> the
>>>>>>>> path of the default language?
>>>>>>>>
>>>>>>>> Couple small reasons:
>>>>>>>>
>>>>>>>> - site navigation has links to /latest/examples/ and similar --
>>>>> people
>>>>>>>> were issuing PRs for broken links in headers, footers, menues, all
>>>>> dec and
>>>>>>>> they're finally (hopefully) settled.
>>>>>>>>
>>>>>>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
>>>>> site
>>>>>>>> overall is 1.7G. The initial push took a few hours to sync and
>> moving
>>>>>>>> everything into an 'en/' directory will double the size. The
>> process
>>>>>>>> actually involves one svn synching to another svn. We don't have
>>>>> direct
>>>>>>>> access to the second svn, so I don't know of any way to avoid
>>>>> doubling the
>>>>>>>> size of that second repo.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> David Blevins
>>>>>>>> http://twitter.com/dblevins
>>>>>>>> http://www.tomitribe.com
>>>>>>>>
>>>>>>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>>>>>>>> cesarguate@gmail.com> wrote:
>>>>>>>>> Thanks Bruno.
>>>>>>>>> I'm working on fixing that test and will be back with an updated PR
>>>>> when
>>>>>>>>> ready.
>>>>>>>>>
>>>>>>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
>>>>> brunobat@gmail.com>)
>>>>>>>>> escribió:
>>>>>>>>>
>>>>>>>>>> Hi César,
>>>>>>>>>>
>>>>>>>>>> I've reviewed the PR and found an error:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Tests in error:
>>>>>>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
>>>>>>>>>> java.io.FileNotFoundException:
>>>>>>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
>>>>> file or
>>>>>>>>>> directory)
>>>>>>>>>>
>>>>>>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>>>>>>>>>>
>>>>>>>>>> [INFO]
>>>>>>>>>>
>>>>>>>>
>>>>>
>> ------------------------------------------------------------------------
>>>>>>>>>> [INFO] BUILD FAILURE
>>>>>>>>>> [INFO]
>>>>>>>>>>
>>>>>>>>
>>>>>
>> ------------------------------------------------------------------------
>>>>>>>>>> Left a comment in the PR.
>>>>>>>>>>
>>>>>>>>>> Cheers
>>>>>>>>>>
>>>>>>>>>> Bruno Baptista
>>>>>>>>>> https://twitter.com/brunobat_
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
>>>>>>>>>>> Hi all,
>>>>>>>>>>> In case somebody is wondering how to review this PR
>>>>>>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
>>>>>>>>>>> once you have the PR on your local git:
>>>>>>>>>>>
>>>>>>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
>>>>>>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
>>>>>>>> compile
>>>>>>>>>>> -Djbake.http=true`
>>>>>>>>>>> 4. The project should show in `http://localhost:8080/docs.html`
>> <http://localhost:8080/docs.html>
>>>>> <http://localhost:8080/docs.html>
>>>>>>>> <http://localhost:8080/docs.html>
>>>>>>>>>> <http://localhost:8080/docs.html>
>>>>>>>>>>> <http://localhost:8080/docs.html> the [es] link to the examples
>> in
>>>>>>>>>> Spanish.
>>>>>>>>>>> So far tomee master only has 1 readme translated into spanish but
>>>>> you
>>>>>>>> can
>>>>>>>>>>> add more README_es.adoc files to any of your
>>>>>>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
>>>>>>>>>>>
>>>>>>>>>>> I'm more than happy to resolve any questions that may arise for
>> the
>>>>>>>>>> review
>>>>>>>>>>> of this PR.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>>>>>>>>>>> cesarguate@gmail.com>) escribió:
>>>>>>>>>>>
>>>>>>>>>>>> Hi, The new PR with the requested changes is ready for review.
>>>>>>>>>>>>
>>>>>>>>>>>> Now the internationalization for examples follows the format
>> like:
>>>>>>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
>>>>>>>>>>>>
>>>>>>>>>>>> I added a vide on the ticket:
>>>>>>>>>>>>
>>>>>>>>
>>>>>
>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>>>>>>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>>>>>>>>>> david.blevins@gmail.com>)
>>>>>>>>>>>> escribió:
>>>>>>>>>>>>
>>>>>>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>>>>>>>>>>>>> cesarguate@gmail.com> wrote:
>>>>>>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
>>>>> loops
>>>>>>>>>>>>>> while I was studying and learning the code.
>>>>>>>>>>>>>> I need to improve my functional skills to refactor that code
>>>>> but in
>>>>>>>>>> the
>>>>>>>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup
>>>>> and
>>>>>>>>>>>>> sharpness
>>>>>>>>>>>>>> once we all agree on the functionality itself.
>>>>>>>>>>>>> That's absolutely fine. Work at whatever language level you're
>>>>>>>>>>>>> comfortable with.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I think as a project we should be very ok with people
>> simplifying
>>>>>>>> code
>>>>>>>>>> so
>>>>>>>>>>>>> they can understand it -- even if that means removing fancy new
>>>>>>>> syntax.
>>>>>>>>>>>>>
>>>>>>>>>>>>> -David
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Atentamente:
>>>>>>>>>>>> César Hernández Mendoza.
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Atentamente:
>>>>>>>>> César Hernández Mendoza.
>>>>>>>>
>>>>>>> --
>>>>>>> Atentamente:
>>>>>>> César Hernández Mendoza.
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Atentamente:
>>>> César Hernández Mendoza.
>>>>
>>>
>>>
>>> --
>>> Atentamente:
>>> César Hernández Mendoza.
>>
>>
>
> --
> Atentamente:
> César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
>
> Working on it now!
Thank you.
> ... an upper case variable name :)
I really sorry about that horrible typo, somehow it passes under the
commits and reviews.
I kinda felt bad for giving you too much feedback already.
I think the approach of incremental improvements is been a good approach
here because I see the website as a green field for learning, migration,
implementation of new features along with the website development process.
I can keep pushing forward the improvements and keep hearing feedback is
always a good way to know and fix the direction ... like, for example, the
Upper case variable I added XD.
El mié., 23 ene. 2019 a las 14:23, David Blevins (<da...@gmail.com>)
escribió:
> Working on it now!
>
> Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed
> files, 700 new lines of code and in under 20 seconds of pulling everything
> into my IDE my eyes lock in on and cannot stop staring at the one place you
> used an upper case variable name :)
>
> -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>
> I was only digging because I wanted to change "Examples" to "Ejemplos" and
> I kinda felt bad for giving you too much feedback already.
>
> Seriously, something is wrong with me :)
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > Hi,
> > Can some of the committers please redeploy TomEE website,
> > http://tomee.apache.org/docs.html still doesn't show the translation
> > language available and https://issues.apache.org/jira/browse/TOMEE-2444
> is
> > still marked as Open.
> >
> > El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> > cesarguate@gmail.com>) escribió:
> >
> >> The PR was merged, can someone of the JIRA admins please move forward
> the
> >> ticket?
> >> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> >> tomee website.
> >>
> >> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<brunobat@gmail.com
> >)
> >> escribió:
> >>
> >>> Hi César,
> >>>
> >>> The PR looks ok to me.
> >>>
> >>> Thanks!
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 16/01/19 23:44, César Hernández Mendoza wrote:
> >>>> Hi!
> >>>>
> >>>> I updated the code and now the PR is ready for review.
> >>>> https://github.com/apache/tomee-site-generator/pull/16
> >>>>
> >>>> @Bruno: I fixed the issue that was causing the test failure you
> >>> identified.
> >>>> @David: I implement your proposal of removing "en" to the path of the
> >>>> default language (English).
> >>>>
> >>>>
> >>>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
> >>>> cesarguate@gmail.com>) escribió:
> >>>>
> >>>>> Thank you for the feedback,
> >>>>>
> >>>>> site navigation has links to /latest/examples/ and similar -- people
> >>> were
> >>>>>> issuing PRs for broken links in headers, footers, menues, all dec
> and
> >>>>>> they're finally (hopefully) settled.
> >>>>> That's a good point, I was not aware of this /latest/examples/
> >>> reference
> >>>>> inside the docs and website. I only updated the doc.html page.
> >>>>>
> >>>>> We don't have direct access to the second svn, so I don't know of any
> >>> way
> >>>>>> to avoid doubling the size of that second repo.
> >>>>> I don't follow you entirely on this one. So far my understanding is
> >>> that
> >>>>> the process for building the site is divided into three major steps:
> >>>>>
> >>>>> 1) Download all the branches into: tomee-site-generator/repos
> >>>>> 2) Copy from /repos folder all the branches
> >>>>> into: tomee-site-generator/target/jbake/content
> >>>>> 3) Bake the tomee-site-generator/target/jbake/content folder
> structure
> >>>>> to generate the final website
> >>>>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >>>>>
> >>>>> My PR only touches step 2) without duplicating the content of the
> >>>>> documentation in English. I added /en to standardize in the code the
> >>>>> indexing process that also is performed on step 2) to generate the
> >>>>> index.htmll per documentation Category, and Language on each Branch:
> >>>>>
> >>>>> --tomee-site-generator/target/jbake/content/tomee-8.0
> >>>>> ----- en
> >>>>> |--examples
> >>>>> ----- es
> >>>>> |--examples
> >>>>> ----- index.adoc
> >>>>>
> >>>>>
> >>>>> Tomorrow I'm going to analyze how to remove /en from the website
> >>> structure.
> >>>>>
> >>>>>
> >>>>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> >>> david.blevins@gmail.com>)
> >>>>> escribió:
> >>>>>
> >>>>>> Little feedback on my side of the fence. Can we avoid adding "en"
> to
> >>> the
> >>>>>> path of the default language?
> >>>>>>
> >>>>>> Couple small reasons:
> >>>>>>
> >>>>>> - site navigation has links to /latest/examples/ and similar --
> >>> people
> >>>>>> were issuing PRs for broken links in headers, footers, menues, all
> >>> dec and
> >>>>>> they're finally (hopefully) settled.
> >>>>>>
> >>>>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
> >>> site
> >>>>>> overall is 1.7G. The initial push took a few hours to sync and
> moving
> >>>>>> everything into an 'en/' directory will double the size. The
> process
> >>>>>> actually involves one svn synching to another svn. We don't have
> >>> direct
> >>>>>> access to the second svn, so I don't know of any way to avoid
> >>> doubling the
> >>>>>> size of that second repo.
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> David Blevins
> >>>>>> http://twitter.com/dblevins
> >>>>>> http://www.tomitribe.com
> >>>>>>
> >>>>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> >>>>>> cesarguate@gmail.com> wrote:
> >>>>>>> Thanks Bruno.
> >>>>>>> I'm working on fixing that test and will be back with an updated PR
> >>> when
> >>>>>>> ready.
> >>>>>>>
> >>>>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
> >>> brunobat@gmail.com>)
> >>>>>>> escribió:
> >>>>>>>
> >>>>>>>> Hi César,
> >>>>>>>>
> >>>>>>>> I've reviewed the PR and found an error:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Tests in error:
> >>>>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >>>>>>>> java.io.FileNotFoundException:
> >>>>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
> >>> file or
> >>>>>>>> directory)
> >>>>>>>>
> >>>>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>>>>>>>
> >>>>>>>> [INFO]
> >>>>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>>>>> [INFO] BUILD FAILURE
> >>>>>>>> [INFO]
> >>>>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>>>>> Left a comment in the PR.
> >>>>>>>>
> >>>>>>>> Cheers
> >>>>>>>>
> >>>>>>>> Bruno Baptista
> >>>>>>>> https://twitter.com/brunobat_
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>>>>>>>> Hi all,
> >>>>>>>>> In case somebody is wondering how to review this PR
> >>>>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
> >>>>>>>>> once you have the PR on your local git:
> >>>>>>>>>
> >>>>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>>>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
> >>>>>> compile
> >>>>>>>>> -Djbake.http=true`
> >>>>>>>>> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> >>> <http://localhost:8080/docs.html>
> >>>>>> <http://localhost:8080/docs.html>
> >>>>>>>> <http://localhost:8080/docs.html>
> >>>>>>>>> <http://localhost:8080/docs.html> the [es] link to the examples
> in
> >>>>>>>> Spanish.
> >>>>>>>>> So far tomee master only has 1 readme translated into spanish but
> >>> you
> >>>>>> can
> >>>>>>>>> add more README_es.adoc files to any of your
> >>>>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>>>>>>>
> >>>>>>>>> I'm more than happy to resolve any questions that may arise for
> the
> >>>>>>>> review
> >>>>>>>>> of this PR.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>>>>>>>> cesarguate@gmail.com>) escribió:
> >>>>>>>>>
> >>>>>>>>>> Hi, The new PR with the requested changes is ready for review.
> >>>>>>>>>>
> >>>>>>>>>> Now the internationalization for examples follows the format
> like:
> >>>>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>>>>>>>
> >>>>>>>>>> I added a vide on the ticket:
> >>>>>>>>>>
> >>>>>>
> >>>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >>>>>>>> david.blevins@gmail.com>)
> >>>>>>>>>> escribió:
> >>>>>>>>>>
> >>>>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>>>>>>>> cesarguate@gmail.com> wrote:
> >>>>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
> >>> loops
> >>>>>>>>>>>> while I was studying and learning the code.
> >>>>>>>>>>>> I need to improve my functional skills to refactor that code
> >>> but in
> >>>>>>>> the
> >>>>>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup
> >>> and
> >>>>>>>>>>> sharpness
> >>>>>>>>>>>> once we all agree on the functionality itself.
> >>>>>>>>>>> That's absolutely fine. Work at whatever language level you're
> >>>>>>>>>>> comfortable with.
> >>>>>>>>>>>
> >>>>>>>>>>> I think as a project we should be very ok with people
> simplifying
> >>>>>> code
> >>>>>>>> so
> >>>>>>>>>>> they can understand it -- even if that means removing fancy new
> >>>>>> syntax.
> >>>>>>>>>>>
> >>>>>>>>>>> -David
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Atentamente:
> >>>>>>>>>> César Hernández Mendoza.
> >>>>>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Atentamente:
> >>>>>>> César Hernández Mendoza.
> >>>>>>
> >>>>> --
> >>>>> Atentamente:
> >>>>> César Hernández Mendoza.
> >>>>>
> >>>>
> >>>
> >>
> >>
> >> --
> >> Atentamente:
> >> César Hernández Mendoza.
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
Working on it now!
Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed files, 700 new lines of code and in under 20 seconds of pulling everything into my IDE my eyes lock in on and cannot stop staring at the one place you used an upper case variable name :)
- https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
I was only digging because I wanted to change "Examples" to "Ejemplos" and I kinda felt bad for giving you too much feedback already.
Seriously, something is wrong with me :)
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
> On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> Hi,
> Can some of the committers please redeploy TomEE website,
> http://tomee.apache.org/docs.html still doesn't show the translation
> language available and https://issues.apache.org/jira/browse/TOMEE-2444 is
> still marked as Open.
>
> El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> cesarguate@gmail.com>) escribió:
>
>> The PR was merged, can someone of the JIRA admins please move forward the
>> ticket?
>> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
>> tomee website.
>>
>> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<br...@gmail.com>)
>> escribió:
>>
>>> Hi César,
>>>
>>> The PR looks ok to me.
>>>
>>> Thanks!
>>>
>>> Bruno Baptista
>>> https://twitter.com/brunobat_
>>>
>>>
>>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>>>> Hi!
>>>>
>>>> I updated the code and now the PR is ready for review.
>>>> https://github.com/apache/tomee-site-generator/pull/16
>>>>
>>>> @Bruno: I fixed the issue that was causing the test failure you
>>> identified.
>>>> @David: I implement your proposal of removing "en" to the path of the
>>>> default language (English).
>>>>
>>>>
>>>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>>>> cesarguate@gmail.com>) escribió:
>>>>
>>>>> Thank you for the feedback,
>>>>>
>>>>> site navigation has links to /latest/examples/ and similar -- people
>>> were
>>>>>> issuing PRs for broken links in headers, footers, menues, all dec and
>>>>>> they're finally (hopefully) settled.
>>>>> That's a good point, I was not aware of this /latest/examples/
>>> reference
>>>>> inside the docs and website. I only updated the doc.html page.
>>>>>
>>>>> We don't have direct access to the second svn, so I don't know of any
>>> way
>>>>>> to avoid doubling the size of that second repo.
>>>>> I don't follow you entirely on this one. So far my understanding is
>>> that
>>>>> the process for building the site is divided into three major steps:
>>>>>
>>>>> 1) Download all the branches into: tomee-site-generator/repos
>>>>> 2) Copy from /repos folder all the branches
>>>>> into: tomee-site-generator/target/jbake/content
>>>>> 3) Bake the tomee-site-generator/target/jbake/content folder structure
>>>>> to generate the final website
>>>>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>>>>>
>>>>> My PR only touches step 2) without duplicating the content of the
>>>>> documentation in English. I added /en to standardize in the code the
>>>>> indexing process that also is performed on step 2) to generate the
>>>>> index.htmll per documentation Category, and Language on each Branch:
>>>>>
>>>>> --tomee-site-generator/target/jbake/content/tomee-8.0
>>>>> ----- en
>>>>> |--examples
>>>>> ----- es
>>>>> |--examples
>>>>> ----- index.adoc
>>>>>
>>>>>
>>>>> Tomorrow I'm going to analyze how to remove /en from the website
>>> structure.
>>>>>
>>>>>
>>>>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
>>> david.blevins@gmail.com>)
>>>>> escribió:
>>>>>
>>>>>> Little feedback on my side of the fence. Can we avoid adding "en" to
>>> the
>>>>>> path of the default language?
>>>>>>
>>>>>> Couple small reasons:
>>>>>>
>>>>>> - site navigation has links to /latest/examples/ and similar --
>>> people
>>>>>> were issuing PRs for broken links in headers, footers, menues, all
>>> dec and
>>>>>> they're finally (hopefully) settled.
>>>>>>
>>>>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
>>> site
>>>>>> overall is 1.7G. The initial push took a few hours to sync and moving
>>>>>> everything into an 'en/' directory will double the size. The process
>>>>>> actually involves one svn synching to another svn. We don't have
>>> direct
>>>>>> access to the second svn, so I don't know of any way to avoid
>>> doubling the
>>>>>> size of that second repo.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> David Blevins
>>>>>> http://twitter.com/dblevins
>>>>>> http://www.tomitribe.com
>>>>>>
>>>>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>>>>>> cesarguate@gmail.com> wrote:
>>>>>>> Thanks Bruno.
>>>>>>> I'm working on fixing that test and will be back with an updated PR
>>> when
>>>>>>> ready.
>>>>>>>
>>>>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
>>> brunobat@gmail.com>)
>>>>>>> escribió:
>>>>>>>
>>>>>>>> Hi César,
>>>>>>>>
>>>>>>>> I've reviewed the PR and found an error:
>>>>>>>>
>>>>>>>>
>>>>>>>> Tests in error:
>>>>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
>>>>>>>> java.io.FileNotFoundException:
>>>>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
>>> file or
>>>>>>>> directory)
>>>>>>>>
>>>>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>>>>>>>>
>>>>>>>> [INFO]
>>>>>>>>
>>>>>>
>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] BUILD FAILURE
>>>>>>>> [INFO]
>>>>>>>>
>>>>>>
>>> ------------------------------------------------------------------------
>>>>>>>> Left a comment in the PR.
>>>>>>>>
>>>>>>>> Cheers
>>>>>>>>
>>>>>>>> Bruno Baptista
>>>>>>>> https://twitter.com/brunobat_
>>>>>>>>
>>>>>>>>
>>>>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
>>>>>>>>> Hi all,
>>>>>>>>> In case somebody is wondering how to review this PR
>>>>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
>>>>>>>>> once you have the PR on your local git:
>>>>>>>>>
>>>>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
>>>>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
>>>>>> compile
>>>>>>>>> -Djbake.http=true`
>>>>>>>>> 4. The project should show in `http://localhost:8080/docs.html`
>>> <http://localhost:8080/docs.html>
>>>>>> <http://localhost:8080/docs.html>
>>>>>>>> <http://localhost:8080/docs.html>
>>>>>>>>> <http://localhost:8080/docs.html> the [es] link to the examples in
>>>>>>>> Spanish.
>>>>>>>>> So far tomee master only has 1 readme translated into spanish but
>>> you
>>>>>> can
>>>>>>>>> add more README_es.adoc files to any of your
>>>>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
>>>>>>>>>
>>>>>>>>> I'm more than happy to resolve any questions that may arise for the
>>>>>>>> review
>>>>>>>>> of this PR.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>>>>>>>>> cesarguate@gmail.com>) escribió:
>>>>>>>>>
>>>>>>>>>> Hi, The new PR with the requested changes is ready for review.
>>>>>>>>>>
>>>>>>>>>> Now the internationalization for examples follows the format like:
>>>>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
>>>>>>>>>>
>>>>>>>>>> I added a vide on the ticket:
>>>>>>>>>>
>>>>>>
>>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>>>>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>>>>>>>> david.blevins@gmail.com>)
>>>>>>>>>> escribió:
>>>>>>>>>>
>>>>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>>>>>>>>>>> cesarguate@gmail.com> wrote:
>>>>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
>>> loops
>>>>>>>>>>>> while I was studying and learning the code.
>>>>>>>>>>>> I need to improve my functional skills to refactor that code
>>> but in
>>>>>>>> the
>>>>>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup
>>> and
>>>>>>>>>>> sharpness
>>>>>>>>>>>> once we all agree on the functionality itself.
>>>>>>>>>>> That's absolutely fine. Work at whatever language level you're
>>>>>>>>>>> comfortable with.
>>>>>>>>>>>
>>>>>>>>>>> I think as a project we should be very ok with people simplifying
>>>>>> code
>>>>>>>> so
>>>>>>>>>>> they can understand it -- even if that means removing fancy new
>>>>>> syntax.
>>>>>>>>>>>
>>>>>>>>>>> -David
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Atentamente:
>>>>>>>>>> César Hernández Mendoza.
>>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Atentamente:
>>>>>>> César Hernández Mendoza.
>>>>>>
>>>>> --
>>>>> Atentamente:
>>>>> César Hernández Mendoza.
>>>>>
>>>>
>>>
>>
>>
>> --
>> Atentamente:
>> César Hernández Mendoza.
>>
>
>
> --
> Atentamente:
> César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi,
Can some of the committers please redeploy TomEE website,
http://tomee.apache.org/docs.html still doesn't show the translation
language available and https://issues.apache.org/jira/browse/TOMEE-2444 is
still marked as Open.
El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
cesarguate@gmail.com>) escribió:
> The PR was merged, can someone of the JIRA admins please move forward the
> ticket?
> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> tomee website.
>
> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<br...@gmail.com>)
> escribió:
>
>> Hi César,
>>
>> The PR looks ok to me.
>>
>> Thanks!
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>> > Hi!
>> >
>> > I updated the code and now the PR is ready for review.
>> > https://github.com/apache/tomee-site-generator/pull/16
>> >
>> > @Bruno: I fixed the issue that was causing the test failure you
>> identified.
>> > @David: I implement your proposal of removing "en" to the path of the
>> > default language (English).
>> >
>> >
>> > El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>> > cesarguate@gmail.com>) escribió:
>> >
>> >> Thank you for the feedback,
>> >>
>> >> site navigation has links to /latest/examples/ and similar -- people
>> were
>> >>> issuing PRs for broken links in headers, footers, menues, all dec and
>> >>> they're finally (hopefully) settled.
>> >> That's a good point, I was not aware of this /latest/examples/
>> reference
>> >> inside the docs and website. I only updated the doc.html page.
>> >>
>> >> We don't have direct access to the second svn, so I don't know of any
>> way
>> >>> to avoid doubling the size of that second repo.
>> >> I don't follow you entirely on this one. So far my understanding is
>> that
>> >> the process for building the site is divided into three major steps:
>> >>
>> >> 1) Download all the branches into: tomee-site-generator/repos
>> >> 2) Copy from /repos folder all the branches
>> >> into: tomee-site-generator/target/jbake/content
>> >> 3) Bake the tomee-site-generator/target/jbake/content folder structure
>> >> to generate the final website
>> >> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>> >>
>> >> My PR only touches step 2) without duplicating the content of the
>> >> documentation in English. I added /en to standardize in the code the
>> >> indexing process that also is performed on step 2) to generate the
>> >> index.htmll per documentation Category, and Language on each Branch:
>> >>
>> >> --tomee-site-generator/target/jbake/content/tomee-8.0
>> >> ----- en
>> >> |--examples
>> >> ----- es
>> >> |--examples
>> >> ----- index.adoc
>> >>
>> >>
>> >> Tomorrow I'm going to analyze how to remove /en from the website
>> structure.
>> >>
>> >>
>> >> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
>> david.blevins@gmail.com>)
>> >> escribió:
>> >>
>> >>> Little feedback on my side of the fence. Can we avoid adding "en" to
>> the
>> >>> path of the default language?
>> >>>
>> >>> Couple small reasons:
>> >>>
>> >>> - site navigation has links to /latest/examples/ and similar --
>> people
>> >>> were issuing PRs for broken links in headers, footers, menues, all
>> dec and
>> >>> they're finally (hopefully) settled.
>> >>>
>> >>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the
>> site
>> >>> overall is 1.7G. The initial push took a few hours to sync and moving
>> >>> everything into an 'en/' directory will double the size. The process
>> >>> actually involves one svn synching to another svn. We don't have
>> direct
>> >>> access to the second svn, so I don't know of any way to avoid
>> doubling the
>> >>> size of that second repo.
>> >>>
>> >>>
>> >>> --
>> >>> David Blevins
>> >>> http://twitter.com/dblevins
>> >>> http://www.tomitribe.com
>> >>>
>> >>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>> >>> cesarguate@gmail.com> wrote:
>> >>>> Thanks Bruno.
>> >>>> I'm working on fixing that test and will be back with an updated PR
>> when
>> >>>> ready.
>> >>>>
>> >>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
>> brunobat@gmail.com>)
>> >>>> escribió:
>> >>>>
>> >>>>> Hi César,
>> >>>>>
>> >>>>> I've reviewed the PR and found an error:
>> >>>>>
>> >>>>>
>> >>>>> Tests in error:
>> >>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
>> >>>>> java.io.FileNotFoundException:
>> >>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such
>> file or
>> >>>>> directory)
>> >>>>>
>> >>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>> >>>>>
>> >>>>> [INFO]
>> >>>>>
>> >>>
>> ------------------------------------------------------------------------
>> >>>>> [INFO] BUILD FAILURE
>> >>>>> [INFO]
>> >>>>>
>> >>>
>> ------------------------------------------------------------------------
>> >>>>> Left a comment in the PR.
>> >>>>>
>> >>>>> Cheers
>> >>>>>
>> >>>>> Bruno Baptista
>> >>>>> https://twitter.com/brunobat_
>> >>>>>
>> >>>>>
>> >>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
>> >>>>>> Hi all,
>> >>>>>> In case somebody is wondering how to review this PR
>> >>>>>> https://github.com/apache/tomee-site-generator/pull/16,
>> >>>>>> once you have the PR on your local git:
>> >>>>>>
>> >>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
>> >>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
>> >>> compile
>> >>>>>> -Djbake.http=true`
>> >>>>>> 4. The project should show in `http://localhost:8080/docs.html`
>> <http://localhost:8080/docs.html>
>> >>> <http://localhost:8080/docs.html>
>> >>>>> <http://localhost:8080/docs.html>
>> >>>>>> <http://localhost:8080/docs.html> the [es] link to the examples in
>> >>>>> Spanish.
>> >>>>>> So far tomee master only has 1 readme translated into spanish but
>> you
>> >>> can
>> >>>>>> add more README_es.adoc files to any of your
>> >>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
>> >>>>>>
>> >>>>>> I'm more than happy to resolve any questions that may arise for the
>> >>>>> review
>> >>>>>> of this PR.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>> >>>>>> cesarguate@gmail.com>) escribió:
>> >>>>>>
>> >>>>>>> Hi, The new PR with the requested changes is ready for review.
>> >>>>>>>
>> >>>>>>> Now the internationalization for examples follows the format like:
>> >>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
>> >>>>>>>
>> >>>>>>> I added a vide on the ticket:
>> >>>>>>>
>> >>>
>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>> >>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>> >>>>> david.blevins@gmail.com>)
>> >>>>>>> escribió:
>> >>>>>>>
>> >>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>> >>>>>>>> cesarguate@gmail.com> wrote:
>> >>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
>> loops
>> >>>>>>>>> while I was studying and learning the code.
>> >>>>>>>>> I need to improve my functional skills to refactor that code
>> but in
>> >>>>> the
>> >>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup
>> and
>> >>>>>>>> sharpness
>> >>>>>>>>> once we all agree on the functionality itself.
>> >>>>>>>> That's absolutely fine. Work at whatever language level you're
>> >>>>>>>> comfortable with.
>> >>>>>>>>
>> >>>>>>>> I think as a project we should be very ok with people simplifying
>> >>> code
>> >>>>> so
>> >>>>>>>> they can understand it -- even if that means removing fancy new
>> >>> syntax.
>> >>>>>>>>
>> >>>>>>>> -David
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>> --
>> >>>>>>> Atentamente:
>> >>>>>>> César Hernández Mendoza.
>> >>>>>>>
>> >>>>
>> >>>> --
>> >>>> Atentamente:
>> >>>> César Hernández Mendoza.
>> >>>
>> >> --
>> >> Atentamente:
>> >> César Hernández Mendoza.
>> >>
>> >
>>
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
The PR was merged, can someone of the JIRA admins please move forward the
ticket?
https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
tomee website.
El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (<br...@gmail.com>)
escribió:
> Hi César,
>
> The PR looks ok to me.
>
> Thanks!
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 16/01/19 23:44, César Hernández Mendoza wrote:
> > Hi!
> >
> > I updated the code and now the PR is ready for review.
> > https://github.com/apache/tomee-site-generator/pull/16
> >
> > @Bruno: I fixed the issue that was causing the test failure you
> identified.
> > @David: I implement your proposal of removing "en" to the path of the
> > default language (English).
> >
> >
> > El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
> > cesarguate@gmail.com>) escribió:
> >
> >> Thank you for the feedback,
> >>
> >> site navigation has links to /latest/examples/ and similar -- people
> were
> >>> issuing PRs for broken links in headers, footers, menues, all dec and
> >>> they're finally (hopefully) settled.
> >> That's a good point, I was not aware of this /latest/examples/ reference
> >> inside the docs and website. I only updated the doc.html page.
> >>
> >> We don't have direct access to the second svn, so I don't know of any
> way
> >>> to avoid doubling the size of that second repo.
> >> I don't follow you entirely on this one. So far my understanding is that
> >> the process for building the site is divided into three major steps:
> >>
> >> 1) Download all the branches into: tomee-site-generator/repos
> >> 2) Copy from /repos folder all the branches
> >> into: tomee-site-generator/target/jbake/content
> >> 3) Bake the tomee-site-generator/target/jbake/content folder structure
> >> to generate the final website
> >> in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >>
> >> My PR only touches step 2) without duplicating the content of the
> >> documentation in English. I added /en to standardize in the code the
> >> indexing process that also is performed on step 2) to generate the
> >> index.htmll per documentation Category, and Language on each Branch:
> >>
> >> --tomee-site-generator/target/jbake/content/tomee-8.0
> >> ----- en
> >> |--examples
> >> ----- es
> >> |--examples
> >> ----- index.adoc
> >>
> >>
> >> Tomorrow I'm going to analyze how to remove /en from the website
> structure.
> >>
> >>
> >> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> david.blevins@gmail.com>)
> >> escribió:
> >>
> >>> Little feedback on my side of the fence. Can we avoid adding "en" to
> the
> >>> path of the default language?
> >>>
> >>> Couple small reasons:
> >>>
> >>> - site navigation has links to /latest/examples/ and similar --
> people
> >>> were issuing PRs for broken links in headers, footers, menues, all dec
> and
> >>> they're finally (hopefully) settled.
> >>>
> >>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
> >>> overall is 1.7G. The initial push took a few hours to sync and moving
> >>> everything into an 'en/' directory will double the size. The process
> >>> actually involves one svn synching to another svn. We don't have
> direct
> >>> access to the second svn, so I don't know of any way to avoid doubling
> the
> >>> size of that second repo.
> >>>
> >>>
> >>> --
> >>> David Blevins
> >>> http://twitter.com/dblevins
> >>> http://www.tomitribe.com
> >>>
> >>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> >>> cesarguate@gmail.com> wrote:
> >>>> Thanks Bruno.
> >>>> I'm working on fixing that test and will be back with an updated PR
> when
> >>>> ready.
> >>>>
> >>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<brunobat@gmail.com
> >)
> >>>> escribió:
> >>>>
> >>>>> Hi César,
> >>>>>
> >>>>> I've reviewed the PR and found an error:
> >>>>>
> >>>>>
> >>>>> Tests in error:
> >>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >>>>> java.io.FileNotFoundException:
> >>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file
> or
> >>>>> directory)
> >>>>>
> >>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>>>>
> >>>>> [INFO]
> >>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>> [INFO] BUILD FAILURE
> >>>>> [INFO]
> >>>>>
> >>>
> ------------------------------------------------------------------------
> >>>>> Left a comment in the PR.
> >>>>>
> >>>>> Cheers
> >>>>>
> >>>>> Bruno Baptista
> >>>>> https://twitter.com/brunobat_
> >>>>>
> >>>>>
> >>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>>>>> Hi all,
> >>>>>> In case somebody is wondering how to review this PR
> >>>>>> https://github.com/apache/tomee-site-generator/pull/16,
> >>>>>> once you have the PR on your local git:
> >>>>>>
> >>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
> >>> compile
> >>>>>> -Djbake.http=true`
> >>>>>> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> >>> <http://localhost:8080/docs.html>
> >>>>> <http://localhost:8080/docs.html>
> >>>>>> <http://localhost:8080/docs.html> the [es] link to the examples in
> >>>>> Spanish.
> >>>>>> So far tomee master only has 1 readme translated into spanish but
> you
> >>> can
> >>>>>> add more README_es.adoc files to any of your
> >>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>>>>
> >>>>>> I'm more than happy to resolve any questions that may arise for the
> >>>>> review
> >>>>>> of this PR.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>>>>> cesarguate@gmail.com>) escribió:
> >>>>>>
> >>>>>>> Hi, The new PR with the requested changes is ready for review.
> >>>>>>>
> >>>>>>> Now the internationalization for examples follows the format like:
> >>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>>>>
> >>>>>>> I added a vide on the ticket:
> >>>>>>>
> >>>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >>>>> david.blevins@gmail.com>)
> >>>>>>> escribió:
> >>>>>>>
> >>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>>>>> cesarguate@gmail.com> wrote:
> >>>>>>>>> I have to be honest, I had to untie a couple of lambdas into
> loops
> >>>>>>>>> while I was studying and learning the code.
> >>>>>>>>> I need to improve my functional skills to refactor that code but
> in
> >>>>> the
> >>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup and
> >>>>>>>> sharpness
> >>>>>>>>> once we all agree on the functionality itself.
> >>>>>>>> That's absolutely fine. Work at whatever language level you're
> >>>>>>>> comfortable with.
> >>>>>>>>
> >>>>>>>> I think as a project we should be very ok with people simplifying
> >>> code
> >>>>> so
> >>>>>>>> they can understand it -- even if that means removing fancy new
> >>> syntax.
> >>>>>>>>
> >>>>>>>> -David
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> --
> >>>>>>> Atentamente:
> >>>>>>> César Hernández Mendoza.
> >>>>>>>
> >>>>
> >>>> --
> >>>> Atentamente:
> >>>> César Hernández Mendoza.
> >>>
> >> --
> >> Atentamente:
> >> César Hernández Mendoza.
> >>
> >
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by Bruno Baptista <br...@gmail.com>.
Hi César,
The PR looks ok to me.
Thanks!
Bruno Baptista
https://twitter.com/brunobat_
On 16/01/19 23:44, César Hernández Mendoza wrote:
> Hi!
>
> I updated the code and now the PR is ready for review.
> https://github.com/apache/tomee-site-generator/pull/16
>
> @Bruno: I fixed the issue that was causing the test failure you identified.
> @David: I implement your proposal of removing "en" to the path of the
> default language (English).
>
>
> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
> cesarguate@gmail.com>) escribió:
>
>> Thank you for the feedback,
>>
>> site navigation has links to /latest/examples/ and similar -- people were
>>> issuing PRs for broken links in headers, footers, menues, all dec and
>>> they're finally (hopefully) settled.
>> That's a good point, I was not aware of this /latest/examples/ reference
>> inside the docs and website. I only updated the doc.html page.
>>
>> We don't have direct access to the second svn, so I don't know of any way
>>> to avoid doubling the size of that second repo.
>> I don't follow you entirely on this one. So far my understanding is that
>> the process for building the site is divided into three major steps:
>>
>> 1) Download all the branches into: tomee-site-generator/repos
>> 2) Copy from /repos folder all the branches
>> into: tomee-site-generator/target/jbake/content
>> 3) Bake the tomee-site-generator/target/jbake/content folder structure
>> to generate the final website
>> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>>
>> My PR only touches step 2) without duplicating the content of the
>> documentation in English. I added /en to standardize in the code the
>> indexing process that also is performed on step 2) to generate the
>> index.htmll per documentation Category, and Language on each Branch:
>>
>> --tomee-site-generator/target/jbake/content/tomee-8.0
>> ----- en
>> |--examples
>> ----- es
>> |--examples
>> ----- index.adoc
>>
>>
>> Tomorrow I'm going to analyze how to remove /en from the website structure.
>>
>>
>> El lun., 14 ene. 2019 a las 17:45, David Blevins (<da...@gmail.com>)
>> escribió:
>>
>>> Little feedback on my side of the fence. Can we avoid adding "en" to the
>>> path of the default language?
>>>
>>> Couple small reasons:
>>>
>>> - site navigation has links to /latest/examples/ and similar -- people
>>> were issuing PRs for broken links in headers, footers, menues, all dec and
>>> they're finally (hopefully) settled.
>>>
>>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
>>> overall is 1.7G. The initial push took a few hours to sync and moving
>>> everything into an 'en/' directory will double the size. The process
>>> actually involves one svn synching to another svn. We don't have direct
>>> access to the second svn, so I don't know of any way to avoid doubling the
>>> size of that second repo.
>>>
>>>
>>> --
>>> David Blevins
>>> http://twitter.com/dblevins
>>> http://www.tomitribe.com
>>>
>>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>>> cesarguate@gmail.com> wrote:
>>>> Thanks Bruno.
>>>> I'm working on fixing that test and will be back with an updated PR when
>>>> ready.
>>>>
>>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<br...@gmail.com>)
>>>> escribió:
>>>>
>>>>> Hi César,
>>>>>
>>>>> I've reviewed the PR and found an error:
>>>>>
>>>>>
>>>>> Tests in error:
>>>>> testProcess(org.apache.tomee.website.GroupedIndexTest):
>>>>> java.io.FileNotFoundException:
>>>>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
>>>>> directory)
>>>>>
>>>>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>>>>>
>>>>> [INFO]
>>>>>
>>> ------------------------------------------------------------------------
>>>>> [INFO] BUILD FAILURE
>>>>> [INFO]
>>>>>
>>> ------------------------------------------------------------------------
>>>>> Left a comment in the PR.
>>>>>
>>>>> Cheers
>>>>>
>>>>> Bruno Baptista
>>>>> https://twitter.com/brunobat_
>>>>>
>>>>>
>>>>> On 11/01/19 22:23, César Hernández Mendoza wrote:
>>>>>> Hi all,
>>>>>> In case somebody is wondering how to review this PR
>>>>>> https://github.com/apache/tomee-site-generator/pull/16,
>>>>>> once you have the PR on your local git:
>>>>>>
>>>>>> 1. build the project: `tomee-site-generator$ mvn clean install`
>>>>>> 3. Build and run the project: `tomee-site-generator$ mvn clean
>>> compile
>>>>>> -Djbake.http=true`
>>>>>> 4. The project should show in `http://localhost:8080/docs.html`
>>> <http://localhost:8080/docs.html>
>>>>> <http://localhost:8080/docs.html>
>>>>>> <http://localhost:8080/docs.html> the [es] link to the examples in
>>>>> Spanish.
>>>>>> So far tomee master only has 1 readme translated into spanish but you
>>> can
>>>>>> add more README_es.adoc files to any of your
>>>>>> `tomee-site-generator/repos/tomee-8.0/examples`.
>>>>>>
>>>>>> I'm more than happy to resolve any questions that may arise for the
>>>>> review
>>>>>> of this PR.
>>>>>>
>>>>>>
>>>>>>
>>>>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>>>>>> cesarguate@gmail.com>) escribió:
>>>>>>
>>>>>>> Hi, The new PR with the requested changes is ready for review.
>>>>>>>
>>>>>>> Now the internationalization for examples follows the format like:
>>>>>>> example: http://localhost:8080/tomee-8.0/es/examples/
>>>>>>>
>>>>>>> I added a vide on the ticket:
>>>>>>>
>>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>>>>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>>>>> david.blevins@gmail.com>)
>>>>>>> escribió:
>>>>>>>
>>>>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>>>>>>>> cesarguate@gmail.com> wrote:
>>>>>>>>> I have to be honest, I had to untie a couple of lambdas into loops
>>>>>>>>> while I was studying and learning the code.
>>>>>>>>> I need to improve my functional skills to refactor that code but in
>>>>> the
>>>>>>>>> meantime, I'm moving forward and will tackle the code cleanup and
>>>>>>>> sharpness
>>>>>>>>> once we all agree on the functionality itself.
>>>>>>>> That's absolutely fine. Work at whatever language level you're
>>>>>>>> comfortable with.
>>>>>>>>
>>>>>>>> I think as a project we should be very ok with people simplifying
>>> code
>>>>> so
>>>>>>>> they can understand it -- even if that means removing fancy new
>>> syntax.
>>>>>>>>
>>>>>>>> -David
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>> Atentamente:
>>>>>>> César Hernández Mendoza.
>>>>>>>
>>>>
>>>> --
>>>> Atentamente:
>>>> César Hernández Mendoza.
>>>
>> --
>> Atentamente:
>> César Hernández Mendoza.
>>
>
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi!
I updated the code and now the PR is ready for review.
https://github.com/apache/tomee-site-generator/pull/16
@Bruno: I fixed the issue that was causing the test failure you identified.
@David: I implement your proposal of removing "en" to the path of the
default language (English).
El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
cesarguate@gmail.com>) escribió:
> Thank you for the feedback,
>
> site navigation has links to /latest/examples/ and similar -- people were
>> issuing PRs for broken links in headers, footers, menues, all dec and
>> they're finally (hopefully) settled.
>
> That's a good point, I was not aware of this /latest/examples/ reference
> inside the docs and website. I only updated the doc.html page.
>
> We don't have direct access to the second svn, so I don't know of any way
>> to avoid doubling the size of that second repo.
>
> I don't follow you entirely on this one. So far my understanding is that
> the process for building the site is divided into three major steps:
>
> 1) Download all the branches into: tomee-site-generator/repos
> 2) Copy from /repos folder all the branches
> into: tomee-site-generator/target/jbake/content
> 3) Bake the tomee-site-generator/target/jbake/content folder structure
> to generate the final website
> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>
> My PR only touches step 2) without duplicating the content of the
> documentation in English. I added /en to standardize in the code the
> indexing process that also is performed on step 2) to generate the
> index.htmll per documentation Category, and Language on each Branch:
>
> --tomee-site-generator/target/jbake/content/tomee-8.0
> ----- en
> |--examples
> ----- es
> |--examples
> ----- index.adoc
>
>
> Tomorrow I'm going to analyze how to remove /en from the website structure.
>
>
> El lun., 14 ene. 2019 a las 17:45, David Blevins (<da...@gmail.com>)
> escribió:
>
>> Little feedback on my side of the fence. Can we avoid adding "en" to the
>> path of the default language?
>>
>> Couple small reasons:
>>
>> - site navigation has links to /latest/examples/ and similar -- people
>> were issuing PRs for broken links in headers, footers, menues, all dec and
>> they're finally (hopefully) settled.
>>
>> - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
>> overall is 1.7G. The initial push took a few hours to sync and moving
>> everything into an 'en/' directory will double the size. The process
>> actually involves one svn synching to another svn. We don't have direct
>> access to the second svn, so I don't know of any way to avoid doubling the
>> size of that second repo.
>>
>>
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>>
>> > On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>> cesarguate@gmail.com> wrote:
>> >
>> > Thanks Bruno.
>> > I'm working on fixing that test and will be back with an updated PR when
>> > ready.
>> >
>> > El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<br...@gmail.com>)
>> > escribió:
>> >
>> >> Hi César,
>> >>
>> >> I've reviewed the PR and found an error:
>> >>
>> >>
>> >> Tests in error:
>> >> testProcess(org.apache.tomee.website.GroupedIndexTest):
>> >> java.io.FileNotFoundException:
>> >> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
>> >> directory)
>> >>
>> >> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>> >>
>> >> [INFO]
>> >>
>> ------------------------------------------------------------------------
>> >> [INFO] BUILD FAILURE
>> >> [INFO]
>> >>
>> ------------------------------------------------------------------------
>> >>
>> >> Left a comment in the PR.
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 11/01/19 22:23, César Hernández Mendoza wrote:
>> >>> Hi all,
>> >>> In case somebody is wondering how to review this PR
>> >>> https://github.com/apache/tomee-site-generator/pull/16,
>> >>> once you have the PR on your local git:
>> >>>
>> >>> 1. build the project: `tomee-site-generator$ mvn clean install`
>> >>> 3. Build and run the project: `tomee-site-generator$ mvn clean
>> compile
>> >>> -Djbake.http=true`
>> >>> 4. The project should show in `http://localhost:8080/docs.html`
>> <http://localhost:8080/docs.html>
>> >> <http://localhost:8080/docs.html>
>> >>> <http://localhost:8080/docs.html> the [es] link to the examples in
>> >> Spanish.
>> >>> So far tomee master only has 1 readme translated into spanish but you
>> can
>> >>> add more README_es.adoc files to any of your
>> >>> `tomee-site-generator/repos/tomee-8.0/examples`.
>> >>>
>> >>> I'm more than happy to resolve any questions that may arise for the
>> >> review
>> >>> of this PR.
>> >>>
>> >>>
>> >>>
>> >>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>> >>> cesarguate@gmail.com>) escribió:
>> >>>
>> >>>> Hi, The new PR with the requested changes is ready for review.
>> >>>>
>> >>>> Now the internationalization for examples follows the format like:
>> >>>> example: http://localhost:8080/tomee-8.0/es/examples/
>> >>>>
>> >>>> I added a vide on the ticket:
>> >>>>
>> >>
>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>> >>>>
>> >>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>> >> david.blevins@gmail.com>)
>> >>>> escribió:
>> >>>>
>> >>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>> >>>>> cesarguate@gmail.com> wrote:
>> >>>>>> I have to be honest, I had to untie a couple of lambdas into loops
>> >>>>>> while I was studying and learning the code.
>> >>>>>> I need to improve my functional skills to refactor that code but in
>> >> the
>> >>>>>> meantime, I'm moving forward and will tackle the code cleanup and
>> >>>>> sharpness
>> >>>>>> once we all agree on the functionality itself.
>> >>>>> That's absolutely fine. Work at whatever language level you're
>> >>>>> comfortable with.
>> >>>>>
>> >>>>> I think as a project we should be very ok with people simplifying
>> code
>> >> so
>> >>>>> they can understand it -- even if that means removing fancy new
>> syntax.
>> >>>>>
>> >>>>>
>> >>>>> -David
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>> --
>> >>>> Atentamente:
>> >>>> César Hernández Mendoza.
>> >>>>
>> >>>
>> >>
>> >
>> >
>> > --
>> > Atentamente:
>> > César Hernández Mendoza.
>>
>>
>
> --
> Atentamente:
> César Hernández Mendoza.
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Thank you for the feedback,
site navigation has links to /latest/examples/ and similar -- people were
> issuing PRs for broken links in headers, footers, menues, all dec and
> they're finally (hopefully) settled.
That's a good point, I was not aware of this /latest/examples/ reference
inside the docs and website. I only updated the doc.html page.
We don't have direct access to the second svn, so I don't know of any way
> to avoid doubling the size of that second repo.
I don't follow you entirely on this one. So far my understanding is that
the process for building the site is divided into three major steps:
1) Download all the branches into: tomee-site-generator/repos
2) Copy from /repos folder all the branches
into: tomee-site-generator/target/jbake/content
3) Bake the tomee-site-generator/target/jbake/content folder structure to
generate the final website in: tomee-site-generator/target/site-1.0-SNAPSHOT
My PR only touches step 2) without duplicating the content of the
documentation in English. I added /en to standardize in the code the
indexing process that also is performed on step 2) to generate the
index.htmll per documentation Category, and Language on each Branch:
--tomee-site-generator/target/jbake/content/tomee-8.0
----- en
|--examples
----- es
|--examples
----- index.adoc
Tomorrow I'm going to analyze how to remove /en from the website structure.
El lun., 14 ene. 2019 a las 17:45, David Blevins (<da...@gmail.com>)
escribió:
> Little feedback on my side of the fence. Can we avoid adding "en" to the
> path of the default language?
>
> Couple small reasons:
>
> - site navigation has links to /latest/examples/ and similar -- people
> were issuing PRs for broken links in headers, footers, menues, all dec and
> they're finally (hopefully) settled.
>
> - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
> overall is 1.7G. The initial push took a few hours to sync and moving
> everything into an 'en/' directory will double the size. The process
> actually involves one svn synching to another svn. We don't have direct
> access to the second svn, so I don't know of any way to avoid doubling the
> size of that second repo.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > Thanks Bruno.
> > I'm working on fixing that test and will be back with an updated PR when
> > ready.
> >
> > El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<br...@gmail.com>)
> > escribió:
> >
> >> Hi César,
> >>
> >> I've reviewed the PR and found an error:
> >>
> >>
> >> Tests in error:
> >> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >> java.io.FileNotFoundException:
> >> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
> >> directory)
> >>
> >> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>
> >> [INFO]
> >> ------------------------------------------------------------------------
> >> [INFO] BUILD FAILURE
> >> [INFO]
> >> ------------------------------------------------------------------------
> >>
> >> Left a comment in the PR.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>> Hi all,
> >>> In case somebody is wondering how to review this PR
> >>> https://github.com/apache/tomee-site-generator/pull/16,
> >>> once you have the PR on your local git:
> >>>
> >>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>> 3. Build and run the project: `tomee-site-generator$ mvn clean compile
> >>> -Djbake.http=true`
> >>> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> >> <http://localhost:8080/docs.html>
> >>> <http://localhost:8080/docs.html> the [es] link to the examples in
> >> Spanish.
> >>> So far tomee master only has 1 readme translated into spanish but you
> can
> >>> add more README_es.adoc files to any of your
> >>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>
> >>> I'm more than happy to resolve any questions that may arise for the
> >> review
> >>> of this PR.
> >>>
> >>>
> >>>
> >>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>> cesarguate@gmail.com>) escribió:
> >>>
> >>>> Hi, The new PR with the requested changes is ready for review.
> >>>>
> >>>> Now the internationalization for examples follows the format like:
> >>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>
> >>>> I added a vide on the ticket:
> >>>>
> >>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>
> >>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >> david.blevins@gmail.com>)
> >>>> escribió:
> >>>>
> >>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>> cesarguate@gmail.com> wrote:
> >>>>>> I have to be honest, I had to untie a couple of lambdas into loops
> >>>>>> while I was studying and learning the code.
> >>>>>> I need to improve my functional skills to refactor that code but in
> >> the
> >>>>>> meantime, I'm moving forward and will tackle the code cleanup and
> >>>>> sharpness
> >>>>>> once we all agree on the functionality itself.
> >>>>> That's absolutely fine. Work at whatever language level you're
> >>>>> comfortable with.
> >>>>>
> >>>>> I think as a project we should be very ok with people simplifying
> code
> >> so
> >>>>> they can understand it -- even if that means removing fancy new
> syntax.
> >>>>>
> >>>>>
> >>>>> -David
> >>>>>
> >>>>>
> >>>>>
> >>>> --
> >>>> Atentamente:
> >>>> César Hernández Mendoza.
> >>>>
> >>>
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
Little feedback on my side of the fence. Can we avoid adding "en" to the path of the default language?
Couple small reasons:
- site navigation has links to /latest/examples/ and similar -- people were issuing PRs for broken links in headers, footers, menues, all dec and they're finally (hopefully) settled.
- everything is in svn, the tomee-8.0 dir alone is 133M, and the site overall is 1.7G. The initial push took a few hours to sync and moving everything into an 'en/' directory will double the size. The process actually involves one svn synching to another svn. We don't have direct access to the second svn, so I don't know of any way to avoid doubling the size of that second repo.
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> Thanks Bruno.
> I'm working on fixing that test and will be back with an updated PR when
> ready.
>
> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<br...@gmail.com>)
> escribió:
>
>> Hi César,
>>
>> I've reviewed the PR and found an error:
>>
>>
>> Tests in error:
>> testProcess(org.apache.tomee.website.GroupedIndexTest):
>> java.io.FileNotFoundException:
>> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
>> directory)
>>
>> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>>
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>>
>> Left a comment in the PR.
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 11/01/19 22:23, César Hernández Mendoza wrote:
>>> Hi all,
>>> In case somebody is wondering how to review this PR
>>> https://github.com/apache/tomee-site-generator/pull/16,
>>> once you have the PR on your local git:
>>>
>>> 1. build the project: `tomee-site-generator$ mvn clean install`
>>> 3. Build and run the project: `tomee-site-generator$ mvn clean compile
>>> -Djbake.http=true`
>>> 4. The project should show in `http://localhost:8080/docs.html`
>> <http://localhost:8080/docs.html>
>>> <http://localhost:8080/docs.html> the [es] link to the examples in
>> Spanish.
>>> So far tomee master only has 1 readme translated into spanish but you can
>>> add more README_es.adoc files to any of your
>>> `tomee-site-generator/repos/tomee-8.0/examples`.
>>>
>>> I'm more than happy to resolve any questions that may arise for the
>> review
>>> of this PR.
>>>
>>>
>>>
>>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
>>> cesarguate@gmail.com>) escribió:
>>>
>>>> Hi, The new PR with the requested changes is ready for review.
>>>>
>>>> Now the internationalization for examples follows the format like:
>>>> example: http://localhost:8080/tomee-8.0/es/examples/
>>>>
>>>> I added a vide on the ticket:
>>>>
>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>>>>
>>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
>> david.blevins@gmail.com>)
>>>> escribió:
>>>>
>>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>>>>> cesarguate@gmail.com> wrote:
>>>>>> I have to be honest, I had to untie a couple of lambdas into loops
>>>>>> while I was studying and learning the code.
>>>>>> I need to improve my functional skills to refactor that code but in
>> the
>>>>>> meantime, I'm moving forward and will tackle the code cleanup and
>>>>> sharpness
>>>>>> once we all agree on the functionality itself.
>>>>> That's absolutely fine. Work at whatever language level you're
>>>>> comfortable with.
>>>>>
>>>>> I think as a project we should be very ok with people simplifying code
>> so
>>>>> they can understand it -- even if that means removing fancy new syntax.
>>>>>
>>>>>
>>>>> -David
>>>>>
>>>>>
>>>>>
>>>> --
>>>> Atentamente:
>>>> César Hernández Mendoza.
>>>>
>>>
>>
>
>
> --
> Atentamente:
> César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Thanks Bruno.
I'm working on fixing that test and will be back with an updated PR when
ready.
El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<br...@gmail.com>)
escribió:
> Hi César,
>
> I've reviewed the PR and found an error:
>
>
> Tests in error:
> testProcess(org.apache.tomee.website.GroupedIndexTest):
> java.io.FileNotFoundException:
> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
> directory)
>
> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
>
> Left a comment in the PR.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 11/01/19 22:23, César Hernández Mendoza wrote:
> > Hi all,
> > In case somebody is wondering how to review this PR
> > https://github.com/apache/tomee-site-generator/pull/16,
> > once you have the PR on your local git:
> >
> > 1. build the project: `tomee-site-generator$ mvn clean install`
> > 3. Build and run the project: `tomee-site-generator$ mvn clean compile
> > -Djbake.http=true`
> > 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> > <http://localhost:8080/docs.html> the [es] link to the examples in
> Spanish.
> > So far tomee master only has 1 readme translated into spanish but you can
> > add more README_es.adoc files to any of your
> > `tomee-site-generator/repos/tomee-8.0/examples`.
> >
> > I'm more than happy to resolve any questions that may arise for the
> review
> > of this PR.
> >
> >
> >
> > El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> > cesarguate@gmail.com>) escribió:
> >
> >> Hi, The new PR with the requested changes is ready for review.
> >>
> >> Now the internationalization for examples follows the format like:
> >> example: http://localhost:8080/tomee-8.0/es/examples/
> >>
> >> I added a vide on the ticket:
> >>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>
> >> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> david.blevins@gmail.com>)
> >> escribió:
> >>
> >>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>> cesarguate@gmail.com> wrote:
> >>>> I have to be honest, I had to untie a couple of lambdas into loops
> >>>> while I was studying and learning the code.
> >>>> I need to improve my functional skills to refactor that code but in
> the
> >>>> meantime, I'm moving forward and will tackle the code cleanup and
> >>> sharpness
> >>>> once we all agree on the functionality itself.
> >>> That's absolutely fine. Work at whatever language level you're
> >>> comfortable with.
> >>>
> >>> I think as a project we should be very ok with people simplifying code
> so
> >>> they can understand it -- even if that means removing fancy new syntax.
> >>>
> >>>
> >>> -David
> >>>
> >>>
> >>>
> >> --
> >> Atentamente:
> >> César Hernández Mendoza.
> >>
> >
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by Bruno Baptista <br...@gmail.com>.
Hi César,
I've reviewed the PR and found an error:
Tests in error:
testProcess(org.apache.tomee.website.GroupedIndexTest):
java.io.FileNotFoundException:
/tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
directory)
Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
Left a comment in the PR.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 11/01/19 22:23, César Hernández Mendoza wrote:
> Hi all,
> In case somebody is wondering how to review this PR
> https://github.com/apache/tomee-site-generator/pull/16,
> once you have the PR on your local git:
>
> 1. build the project: `tomee-site-generator$ mvn clean install`
> 3. Build and run the project: `tomee-site-generator$ mvn clean compile
> -Djbake.http=true`
> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html> the [es] link to the examples in Spanish.
> So far tomee master only has 1 readme translated into spanish but you can
> add more README_es.adoc files to any of your
> `tomee-site-generator/repos/tomee-8.0/examples`.
>
> I'm more than happy to resolve any questions that may arise for the review
> of this PR.
>
>
>
> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> cesarguate@gmail.com>) escribió:
>
>> Hi, The new PR with the requested changes is ready for review.
>>
>> Now the internationalization for examples follows the format like:
>> example: http://localhost:8080/tomee-8.0/es/examples/
>>
>> I added a vide on the ticket:
>> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>>
>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<da...@gmail.com>)
>> escribió:
>>
>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>>> cesarguate@gmail.com> wrote:
>>>> I have to be honest, I had to untie a couple of lambdas into loops
>>>> while I was studying and learning the code.
>>>> I need to improve my functional skills to refactor that code but in the
>>>> meantime, I'm moving forward and will tackle the code cleanup and
>>> sharpness
>>>> once we all agree on the functionality itself.
>>> That's absolutely fine. Work at whatever language level you're
>>> comfortable with.
>>>
>>> I think as a project we should be very ok with people simplifying code so
>>> they can understand it -- even if that means removing fancy new syntax.
>>>
>>>
>>> -David
>>>
>>>
>>>
>> --
>> Atentamente:
>> César Hernández Mendoza.
>>
>
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi all,
In case somebody is wondering how to review this PR
https://github.com/apache/tomee-site-generator/pull/16,
once you have the PR on your local git:
1. build the project: `tomee-site-generator$ mvn clean install`
3. Build and run the project: `tomee-site-generator$ mvn clean compile
-Djbake.http=true`
4. The project should show in `http://localhost:8080/docs.html`
<http://localhost:8080/docs.html> the [es] link to the examples in Spanish.
So far tomee master only has 1 readme translated into spanish but you can
add more README_es.adoc files to any of your
`tomee-site-generator/repos/tomee-8.0/examples`.
I'm more than happy to resolve any questions that may arise for the review
of this PR.
El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
cesarguate@gmail.com>) escribió:
> Hi, The new PR with the requested changes is ready for review.
>
> Now the internationalization for examples follows the format like:
> example: http://localhost:8080/tomee-8.0/es/examples/
>
> I added a vide on the ticket:
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
>
> El mié., 9 ene. 2019 a las 12:39, David Blevins (<da...@gmail.com>)
> escribió:
>
>> > On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
>> cesarguate@gmail.com> wrote:
>> >
>> > I have to be honest, I had to untie a couple of lambdas into loops
>> > while I was studying and learning the code.
>> > I need to improve my functional skills to refactor that code but in the
>> > meantime, I'm moving forward and will tackle the code cleanup and
>> sharpness
>> > once we all agree on the functionality itself.
>>
>> That's absolutely fine. Work at whatever language level you're
>> comfortable with.
>>
>> I think as a project we should be very ok with people simplifying code so
>> they can understand it -- even if that means removing fancy new syntax.
>>
>>
>> -David
>>
>>
>>
>
> --
> Atentamente:
> César Hernández Mendoza.
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi, The new PR with the requested changes is ready for review.
Now the internationalization for examples follows the format like:
example: http://localhost:8080/tomee-8.0/es/examples/
I added a vide on the ticket:
https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
El mié., 9 ene. 2019 a las 12:39, David Blevins (<da...@gmail.com>)
escribió:
> > On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > I have to be honest, I had to untie a couple of lambdas into loops
> > while I was studying and learning the code.
> > I need to improve my functional skills to refactor that code but in the
> > meantime, I'm moving forward and will tackle the code cleanup and
> sharpness
> > once we all agree on the functionality itself.
>
> That's absolutely fine. Work at whatever language level you're
> comfortable with.
>
> I think as a project we should be very ok with people simplifying code so
> they can understand it -- even if that means removing fancy new syntax.
>
>
> -David
>
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> I have to be honest, I had to untie a couple of lambdas into loops
> while I was studying and learning the code.
> I need to improve my functional skills to refactor that code but in the
> meantime, I'm moving forward and will tackle the code cleanup and sharpness
> once we all agree on the functionality itself.
That's absolutely fine. Work at whatever language level you're comfortable with.
I think as a project we should be very ok with people simplifying code so they can understand it -- even if that means removing fancy new syntax.
-David
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Got it, I'm going to work on updating my PR to enable the proposed changes.
I'll keep this thread updated as I move forward.
but one approach might be to break up this method
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Sources.java#L117
Yes, I actually took that advice you made since the beginning of the
thread. I have to be honest, I had to untie a couple of lambdas into loops
while I was studying and learning the code.
I need to improve my functional skills to refactor that code but in the
meantime, I'm moving forward and will tackle the code cleanup and sharpness
once we all agree on the functionality itself.
El mar., 8 ene. 2019 a las 19:14, David Blevins (<da...@gmail.com>)
escribió:
> > On Jan 8, 2019, at 12:32 PM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > tomee-8.0 (latest)
> > Documentation
> > Examples [es]
> > Javadoc
> >
> > tomee-7.1
> > Examples [es] [fr]
> > Javadoc
>
> We could still do that regardless of the url pattern change. There's a
> little bit of jumping already happening on the main /docs.html page.
> Particularly:
>
> - http://tomee.apache.org/docs.html ... links to
> - http://tomee.apache.org/tomee-8.0/docs/ ... here and skips over
> - http://tomee.apache.org/tomee-8.0/ ... this page which does
> exist
>
> The only way to get to "tomee-8.0/index.html" is via URL hack. But it's
> there in case we want to point people to it. If we wanted tot add
> breadcrumbs, we're ready.
>
> There could and should be a "tomee-8.0/es/index.html" page.
>
> I haven't looked at the PR since this weekend, but one approach might be
> to break up this method
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Sources.java#L117
>
> This is pseudo code, but something a little like this:
>
> public void prepare() {
> // copy the non-version specific stuff over
> try {
> IO.copyDirectory(mainSource, jbake);
> } catch (IOException e) {
> throw new RuntimeException(e);
> }
>
> // download all the external repos
> sources.stream()
> .flatMap(source -> source.getRelated().stream())
> .peek(source -> source.setDir(new File(repos,
> source.getName())))
> .forEach(Repos::download);
>
> // download all our repos and process javadoc
> final Javadocs javadocs = new Javadocs(this);
> sources.stream()
> .peek(source -> source.setDir(new File(repos,
> source.getName())))
> .peek(Repos::download)
> .forEach(javadocs::prepare);
> ;
>
> // for each source, collect the extensions and process them
> // each gets its own identical layout
> // perhaps empty string "" implies english
> for (Source source : sources) {
> for (String lang : source.findLanguages()) {
>
> final Docs docs = new Docs(this, lang);
> final Examples examples = new Examples(this, lang);
> final VersionIndex versionIndex = new VersionIndex(this,
> lang);
>
> // this logic now knows what language it needs to look for
> and collect and process
> sources.stream()
> .peek(docs::prepare)
> .peek(examples::prepare)
> .peek(versionIndex::prepare)
> .forEach(Sources::done);
> }
> }
>
> // create the big magical index across all projects, versions and
> languages
> // we can try to keep it on one page for as long as possible
> // it will eventually get too big, but we're not there yet
>
> VersionsIndex.prepare(this);
> }
>
> Then we make sure anything we add in that second set of loops always
> handles internationalization. Now it's docs and examples. Tomorrow it
> could include presentations, video links, who knows.
>
> I'm sure that second set of loops could be done with Streams. I don't
> know that I could type that into an email window with confidence :)
>
>
> -David
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
> On Jan 8, 2019, at 12:32 PM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> tomee-8.0 (latest)
> Documentation
> Examples [es]
> Javadoc
>
> tomee-7.1
> Examples [es] [fr]
> Javadoc
We could still do that regardless of the url pattern change. There's a little bit of jumping already happening on the main /docs.html page. Particularly:
- http://tomee.apache.org/docs.html ... links to
- http://tomee.apache.org/tomee-8.0/docs/ ... here and skips over
- http://tomee.apache.org/tomee-8.0/ ... this page which does exist
The only way to get to "tomee-8.0/index.html" is via URL hack. But it's there in case we want to point people to it. If we wanted tot add breadcrumbs, we're ready.
There could and should be a "tomee-8.0/es/index.html" page.
I haven't looked at the PR since this weekend, but one approach might be to break up this method https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Sources.java#L117
This is pseudo code, but something a little like this:
public void prepare() {
// copy the non-version specific stuff over
try {
IO.copyDirectory(mainSource, jbake);
} catch (IOException e) {
throw new RuntimeException(e);
}
// download all the external repos
sources.stream()
.flatMap(source -> source.getRelated().stream())
.peek(source -> source.setDir(new File(repos, source.getName())))
.forEach(Repos::download);
// download all our repos and process javadoc
final Javadocs javadocs = new Javadocs(this);
sources.stream()
.peek(source -> source.setDir(new File(repos, source.getName())))
.peek(Repos::download)
.forEach(javadocs::prepare);
;
// for each source, collect the extensions and process them
// each gets its own identical layout
// perhaps empty string "" implies english
for (Source source : sources) {
for (String lang : source.findLanguages()) {
final Docs docs = new Docs(this, lang);
final Examples examples = new Examples(this, lang);
final VersionIndex versionIndex = new VersionIndex(this, lang);
// this logic now knows what language it needs to look for and collect and process
sources.stream()
.peek(docs::prepare)
.peek(examples::prepare)
.peek(versionIndex::prepare)
.forEach(Sources::done);
}
}
// create the big magical index across all projects, versions and languages
// we can try to keep it on one page for as long as possible
// it will eventually get too big, but we're not there yet
VersionsIndex.prepare(this);
}
Then we make sure anything we add in that second set of loops always handles internationalization. Now it's docs and examples. Tomorrow it could include presentations, video links, who knows.
I'm sure that second set of loops could be done with Streams. I don't know that I could type that into an email window with confidence :)
-David
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Thank you for the feedback. I have one question regarding the navigation:
Currently from the homepage, one can go to http://tomee.apache.org/docs.html
by clicking the Documentation button.
The resulting page has the following structure:
tomee-8.0 (latest)
Documentation
Examples [es]
Javadoc
tomee-7.1
Examples [es] [fr]
Javadoc
...
By changing to http://localhost:8080/tomee-8.0/fr/examples/ approach,
does the Documentation button should show the languages available as a list
instead of the list described above?
* English
* Spanish
* French
El mar., 8 ene. 2019 a las 13:29, David Blevins (<da...@gmail.com>)
escribió:
> > On Jan 4, 2019, at 6:47 PM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > When you click [fr] or [es], then the page for the translated examples
> > appears: http://localhost:8080/tomee-8.0/examples/es/ or
> > http://localhost:8080/tomee-8.0/examples/fr/
> > Keeping the link for `Examples` the default in English:
> > http://localhost:8080/tomee-8.0/examples/
>
> My perspective is we should switch this around from:
>
> - http://localhost:8080/tomee-8.0/examples/fr/
>
> To:
>
> - http://localhost:8080/tomee-8.0/fr/examples/
>
> Some reasons:
>
> - this approach works for more than examples and can work for other
> documentation as well
> - we could potentially use non-english names in the path instead of
> always the english "examples"
>
> So both combined could look like this:
>
> - http://localhost:8080/tomee-8.0/es/index.html # this would be all
> resources in es
> - http://localhost:8080/tomee-8.0/es/ejemplos/<something>.html
> - http://localhost:8080/tomee-8.0/es/docs/<foobar>.html
>
> This would grow better over time IMO.
>
> Thoughts?
>
> Note we can still take the PR as-is ; things can easily evolve in the
> codebase.
>
>
> -David
>
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
> On Jan 4, 2019, at 6:47 PM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> When you click [fr] or [es], then the page for the translated examples
> appears: http://localhost:8080/tomee-8.0/examples/es/ or
> http://localhost:8080/tomee-8.0/examples/fr/
> Keeping the link for `Examples` the default in English:
> http://localhost:8080/tomee-8.0/examples/
My perspective is we should switch this around from:
- http://localhost:8080/tomee-8.0/examples/fr/
To:
- http://localhost:8080/tomee-8.0/fr/examples/
Some reasons:
- this approach works for more than examples and can work for other documentation as well
- we could potentially use non-english names in the path instead of always the english "examples"
So both combined could look like this:
- http://localhost:8080/tomee-8.0/es/index.html # this would be all resources in es
- http://localhost:8080/tomee-8.0/es/ejemplos/<something>.html
- http://localhost:8080/tomee-8.0/es/docs/<foobar>.html
This would grow better over time IMO.
Thoughts?
Note we can still take the PR as-is ; things can easily evolve in the codebase.
-David
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Hi,
I rebase the PR with the latest master and did code clean up.
The PR for https://issues.apache.org/jira/browse/TOMEE-2444 is ready for
review.
I included in the PR the instructions to check the feature:
https://github.com/apache/tomee-site-generator/pull/16
To review this PR you need:
1. build the project: `tomee-site-generator$ mvn clean install`
2. Choose any example like for example
`tomee-site-generator/repos/tomee-8.0/examples/mp-config-example/` and
create a readme file with a suffix that represents the translation for the
readme. For example: ` README_fr.adoc `.
3. Build and run the project: `tomee-site-generator$ mvn clean compile
-Djbake.http=true`
4. The project should show in `http://localhost:8080/docs.html` the [fr]
link to the examples in French.
El vie., 4 ene. 2019 a las 20:47, César Hernández Mendoza (<
cesarguate@gmail.com>) escribió:
> Update:
> My PR is still WIP. I identified a missing requirement: how we are going
> to present the available languages for each Source.
> After doing some mocks, I come up with this solution:
>
> tomee-8.0 (latest)
> Documentation
> Examples [fr] [es]
>
> When you click [fr] or [es], then the page for the translated examples
> appears: http://localhost:8080/tomee-8.0/examples/es/ or
> http://localhost:8080/tomee-8.0/examples/fr/
> Keeping the link for `Examples` the default in English:
> http://localhost:8080/tomee-8.0/examples/
>
> The site automatically generates the /<language> structure based on the
> suffix for the readme file: README_<2LetterLanguage>.adoc
>
> A video can clear out a lot of questions, you can check the video of the
> current PR that I expect to finish on Monday next week. I think I'm very
> close :)!
>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16734742&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16734742
>
> El jue., 3 ene. 2019 a las 13:28, David Blevins (<da...@gmail.com>)
> escribió:
>
>>
>> > On Jan 3, 2019, at 8:40 AM, César Hernández Mendoza <
>> cesarguate@gmail.com> wrote:
>> >
>> > Now that we have the main task (TomEE-2442), I created the first sub
>> tast:
>> > "Update tomee-site-generator to allow examples and docs
>> > internationalization- [TOMEE-2444]"
>> >
>> > Can some of the Jira admins please assign
>> > https://issues.apache.org/jira/browse/TOMEE-2444 to me?
>>
>> Assigned!
>>
>> > This will implement and validate David's proposal, if I make it work
>> then
>> > the door will be open to starting the translation marathon :)
>>
>> I recommend we translate a few examples now so you have something to code
>> against.
>>
>> Great to see excitement behind this :) It could be huge :)
>>
>> -David
>>
>>
>> > El jue., 3 ene. 2019 a las 3:10, Bruno Baptista (<br...@gmail.com>)
>> > escribió:
>> >
>> >> Hi Carlos,
>> >>
>> >> Just chose a few documents, create the jiras and let us know them.
>> >>
>> >> Cheers!
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 03/01/19 01:11, Carlos Chacín wrote:
>> >>> +1 please let me know how I can help
>> >>>
>> >>> On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
>> >>> daniel.dias.analistati@gmail.com wrote:
>> >>>
>> >>>> +1 : )
>> >>>> --
>> >>>>
>> >>>> *Daniel Dias dos Santos*
>> >>>> Java Developer
>> >>>> SouJava & JCP Member
>> >>>> GitHub: https://github.com/Daniel-Dos
>> >>>> Linkedin: www.linkedin.com/in/danieldiasjava
>> >>>> Twitter: http://twitter.com/danieldiasjava
>> >>>>
>> >>>>
>> >>>> Em seg, 24 de dez de 2018 às 21:28, David Blevins <
>> >> david.blevins@gmail.com
>> >>>> escreveu:
>> >>>>
>> >>>>> I say “game on” to any languages people want to contribute :)
>> >>>>>
>> >>>>> In fact, let the PRs fly. I’ll write the site logic this week.
>> >>>>>
>> >>>>> -David
>> >>>>>
>> >>>>> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
>> >>>>> aboullaite.mohammed@gmail.com> wrote:
>> >>>>>
>> >>>>>> I think its a brilliant idea. it'll open the door for not only
>> >> Spanish,
>> >>>>> but
>> >>>>>> other languages as well (I'm thinking of French as well).
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> On Mon, Dec 24, 2018, 11:35 PM David Blevins <
>> david.blevins@gmail.com
>> >>>>>> wrote:
>> >>>>>>
>> >>>>>>> I was talking with Hillmer on twitter about potentially
>> translating
>> >>>>>>> examples into Spanish.
>> >>>>>>>
>> >>>>>>> The idea is that we could potentially do examples and
>> documentation
>> >>>> in
>> >>>>>>> Spanish. Perhaps:
>> >>>>>>>
>> >>>>>>> - http://tomee.apache.org/tomee-8.0/es/docs/
>> >>>>>>> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
>> >>>>>>>
>> >>>>>>> First note is that how we organize the files in the git repo and
>> how
>> >>>> we
>> >>>>>>> organize them on the website can be completely different. We use
>> the
>> >>>>>>> following code to collect all the examples together and do various
>> >>>>> things
>> >>>>>>> to them:
>> >>>>>>>
>> >>>>>>> -
>> >>>>>>>
>> >>>>
>> >>
>> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
>> >>>>>>> Right now it will do a copy and rename, for example:
>> >>>>>>>
>> >>>>>>> -
>> >>>>>>>
>> >>>>
>> >>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
>> >>>>>>> -
>> >> http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
>> >>>>>>>
>> >>>>>>> We could theoretically do something as simple as this:
>> >>>>>>>
>> >>>>>>> -
>> >>>>>>>
>> >>>>
>> >>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
>> >>>>>>> -
>> >>>>>
>> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
>> >>>>>>> I.e. make a new file next to the original, then update our copying
>> >>>>> logic
>> >>>>>>> to put the prefix in the path.
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> Thoughts?
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> --
>> >>>>>>> David Blevins
>> >>>>>>> http://twitter.com/dblevins
>> >>>>>>> http://www.tomitribe.com
>> >>>>>>>
>> >>>>>>>
>> >>>>> --
>> >>>>> Sent from my iPhone
>> >>>>>
>> >>
>> >
>> >
>> > --
>> > Atentamente:
>> > César Hernández Mendoza.
>>
>>
>
> --
> Atentamente:
> César Hernández Mendoza.
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Update:
My PR is still WIP. I identified a missing requirement: how we are going to
present the available languages for each Source.
After doing some mocks, I come up with this solution:
tomee-8.0 (latest)
Documentation
Examples [fr] [es]
When you click [fr] or [es], then the page for the translated examples
appears: http://localhost:8080/tomee-8.0/examples/es/ or
http://localhost:8080/tomee-8.0/examples/fr/
Keeping the link for `Examples` the default in English:
http://localhost:8080/tomee-8.0/examples/
The site automatically generates the /<language> structure based on the
suffix for the readme file: README_<2LetterLanguage>.adoc
A video can clear out a lot of questions, you can check the video of the
current PR that I expect to finish on Monday next week. I think I'm very
close :)!
https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16734742&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16734742
El jue., 3 ene. 2019 a las 13:28, David Blevins (<da...@gmail.com>)
escribió:
>
> > On Jan 3, 2019, at 8:40 AM, César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
> >
> > Now that we have the main task (TomEE-2442), I created the first sub
> tast:
> > "Update tomee-site-generator to allow examples and docs
> > internationalization- [TOMEE-2444]"
> >
> > Can some of the Jira admins please assign
> > https://issues.apache.org/jira/browse/TOMEE-2444 to me?
>
> Assigned!
>
> > This will implement and validate David's proposal, if I make it work then
> > the door will be open to starting the translation marathon :)
>
> I recommend we translate a few examples now so you have something to code
> against.
>
> Great to see excitement behind this :) It could be huge :)
>
> -David
>
>
> > El jue., 3 ene. 2019 a las 3:10, Bruno Baptista (<br...@gmail.com>)
> > escribió:
> >
> >> Hi Carlos,
> >>
> >> Just chose a few documents, create the jiras and let us know them.
> >>
> >> Cheers!
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 03/01/19 01:11, Carlos Chacín wrote:
> >>> +1 please let me know how I can help
> >>>
> >>> On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
> >>> daniel.dias.analistati@gmail.com wrote:
> >>>
> >>>> +1 : )
> >>>> --
> >>>>
> >>>> *Daniel Dias dos Santos*
> >>>> Java Developer
> >>>> SouJava & JCP Member
> >>>> GitHub: https://github.com/Daniel-Dos
> >>>> Linkedin: www.linkedin.com/in/danieldiasjava
> >>>> Twitter: http://twitter.com/danieldiasjava
> >>>>
> >>>>
> >>>> Em seg, 24 de dez de 2018 às 21:28, David Blevins <
> >> david.blevins@gmail.com
> >>>> escreveu:
> >>>>
> >>>>> I say “game on” to any languages people want to contribute :)
> >>>>>
> >>>>> In fact, let the PRs fly. I’ll write the site logic this week.
> >>>>>
> >>>>> -David
> >>>>>
> >>>>> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
> >>>>> aboullaite.mohammed@gmail.com> wrote:
> >>>>>
> >>>>>> I think its a brilliant idea. it'll open the door for not only
> >> Spanish,
> >>>>> but
> >>>>>> other languages as well (I'm thinking of French as well).
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Dec 24, 2018, 11:35 PM David Blevins <
> david.blevins@gmail.com
> >>>>>> wrote:
> >>>>>>
> >>>>>>> I was talking with Hillmer on twitter about potentially translating
> >>>>>>> examples into Spanish.
> >>>>>>>
> >>>>>>> The idea is that we could potentially do examples and documentation
> >>>> in
> >>>>>>> Spanish. Perhaps:
> >>>>>>>
> >>>>>>> - http://tomee.apache.org/tomee-8.0/es/docs/
> >>>>>>> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> >>>>>>>
> >>>>>>> First note is that how we organize the files in the git repo and
> how
> >>>> we
> >>>>>>> organize them on the website can be completely different. We use
> the
> >>>>>>> following code to collect all the examples together and do various
> >>>>> things
> >>>>>>> to them:
> >>>>>>>
> >>>>>>> -
> >>>>>>>
> >>>>
> >>
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> >>>>>>> Right now it will do a copy and rename, for example:
> >>>>>>>
> >>>>>>> -
> >>>>>>>
> >>>>
> >>
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> >>>>>>> -
> >> http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> >>>>>>>
> >>>>>>> We could theoretically do something as simple as this:
> >>>>>>>
> >>>>>>> -
> >>>>>>>
> >>>>
> >>
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> >>>>>>> -
> >>>>> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> >>>>>>> I.e. make a new file next to the original, then update our copying
> >>>>> logic
> >>>>>>> to put the prefix in the path.
> >>>>>>>
> >>>>>>>
> >>>>>>> Thoughts?
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> David Blevins
> >>>>>>> http://twitter.com/dblevins
> >>>>>>> http://www.tomitribe.com
> >>>>>>>
> >>>>>>>
> >>>>> --
> >>>>> Sent from my iPhone
> >>>>>
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
> On Jan 3, 2019, at 8:40 AM, César Hernández Mendoza <ce...@gmail.com> wrote:
>
> Now that we have the main task (TomEE-2442), I created the first sub tast:
> "Update tomee-site-generator to allow examples and docs
> internationalization- [TOMEE-2444]"
>
> Can some of the Jira admins please assign
> https://issues.apache.org/jira/browse/TOMEE-2444 to me?
Assigned!
> This will implement and validate David's proposal, if I make it work then
> the door will be open to starting the translation marathon :)
I recommend we translate a few examples now so you have something to code against.
Great to see excitement behind this :) It could be huge :)
-David
> El jue., 3 ene. 2019 a las 3:10, Bruno Baptista (<br...@gmail.com>)
> escribió:
>
>> Hi Carlos,
>>
>> Just chose a few documents, create the jiras and let us know them.
>>
>> Cheers!
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 03/01/19 01:11, Carlos Chacín wrote:
>>> +1 please let me know how I can help
>>>
>>> On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
>>> daniel.dias.analistati@gmail.com wrote:
>>>
>>>> +1 : )
>>>> --
>>>>
>>>> *Daniel Dias dos Santos*
>>>> Java Developer
>>>> SouJava & JCP Member
>>>> GitHub: https://github.com/Daniel-Dos
>>>> Linkedin: www.linkedin.com/in/danieldiasjava
>>>> Twitter: http://twitter.com/danieldiasjava
>>>>
>>>>
>>>> Em seg, 24 de dez de 2018 às 21:28, David Blevins <
>> david.blevins@gmail.com
>>>> escreveu:
>>>>
>>>>> I say “game on” to any languages people want to contribute :)
>>>>>
>>>>> In fact, let the PRs fly. I’ll write the site logic this week.
>>>>>
>>>>> -David
>>>>>
>>>>> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
>>>>> aboullaite.mohammed@gmail.com> wrote:
>>>>>
>>>>>> I think its a brilliant idea. it'll open the door for not only
>> Spanish,
>>>>> but
>>>>>> other languages as well (I'm thinking of French as well).
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
>>>>>> wrote:
>>>>>>
>>>>>>> I was talking with Hillmer on twitter about potentially translating
>>>>>>> examples into Spanish.
>>>>>>>
>>>>>>> The idea is that we could potentially do examples and documentation
>>>> in
>>>>>>> Spanish. Perhaps:
>>>>>>>
>>>>>>> - http://tomee.apache.org/tomee-8.0/es/docs/
>>>>>>> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
>>>>>>>
>>>>>>> First note is that how we organize the files in the git repo and how
>>>> we
>>>>>>> organize them on the website can be completely different. We use the
>>>>>>> following code to collect all the examples together and do various
>>>>> things
>>>>>>> to them:
>>>>>>>
>>>>>>> -
>>>>>>>
>>>>
>> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
>>>>>>> Right now it will do a copy and rename, for example:
>>>>>>>
>>>>>>> -
>>>>>>>
>>>>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
>>>>>>> -
>> http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
>>>>>>>
>>>>>>> We could theoretically do something as simple as this:
>>>>>>>
>>>>>>> -
>>>>>>>
>>>>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
>>>>>>> -
>>>>> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
>>>>>>> I.e. make a new file next to the original, then update our copying
>>>>> logic
>>>>>>> to put the prefix in the path.
>>>>>>>
>>>>>>>
>>>>>>> Thoughts?
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> David Blevins
>>>>>>> http://twitter.com/dblevins
>>>>>>> http://www.tomitribe.com
>>>>>>>
>>>>>>>
>>>>> --
>>>>> Sent from my iPhone
>>>>>
>>
>
>
> --
> Atentamente:
> César Hernández Mendoza.
Re: Ejemplos en Español
Posted by César Hernández Mendoza <ce...@gmail.com>.
Now that we have the main task (TomEE-2442), I created the first sub tast:
"Update tomee-site-generator to allow examples and docs
internationalization- [TOMEE-2444]"
Can some of the Jira admins please assign
https://issues.apache.org/jira/browse/TOMEE-2444 to me?
This will implement and validate David's proposal, if I make it work then
the door will be open to starting the translation marathon :)
El jue., 3 ene. 2019 a las 3:10, Bruno Baptista (<br...@gmail.com>)
escribió:
> Hi Carlos,
>
> Just chose a few documents, create the jiras and let us know them.
>
> Cheers!
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 03/01/19 01:11, Carlos Chacín wrote:
> > +1 please let me know how I can help
> >
> > On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
> > daniel.dias.analistati@gmail.com wrote:
> >
> >> +1 : )
> >> --
> >>
> >> *Daniel Dias dos Santos*
> >> Java Developer
> >> SouJava & JCP Member
> >> GitHub: https://github.com/Daniel-Dos
> >> Linkedin: www.linkedin.com/in/danieldiasjava
> >> Twitter: http://twitter.com/danieldiasjava
> >>
> >>
> >> Em seg, 24 de dez de 2018 às 21:28, David Blevins <
> david.blevins@gmail.com
> >> escreveu:
> >>
> >>> I say “game on” to any languages people want to contribute :)
> >>>
> >>> In fact, let the PRs fly. I’ll write the site logic this week.
> >>>
> >>> -David
> >>>
> >>> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
> >>> aboullaite.mohammed@gmail.com> wrote:
> >>>
> >>>> I think its a brilliant idea. it'll open the door for not only
> Spanish,
> >>> but
> >>>> other languages as well (I'm thinking of French as well).
> >>>>
> >>>>
> >>>>
> >>>> On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
> >>>> wrote:
> >>>>
> >>>>> I was talking with Hillmer on twitter about potentially translating
> >>>>> examples into Spanish.
> >>>>>
> >>>>> The idea is that we could potentially do examples and documentation
> >> in
> >>>>> Spanish. Perhaps:
> >>>>>
> >>>>> - http://tomee.apache.org/tomee-8.0/es/docs/
> >>>>> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> >>>>>
> >>>>> First note is that how we organize the files in the git repo and how
> >> we
> >>>>> organize them on the website can be completely different. We use the
> >>>>> following code to collect all the examples together and do various
> >>> things
> >>>>> to them:
> >>>>>
> >>>>> -
> >>>>>
> >>
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> >>>>> Right now it will do a copy and rename, for example:
> >>>>>
> >>>>> -
> >>>>>
> >>
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> >>>>> -
> http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> >>>>>
> >>>>> We could theoretically do something as simple as this:
> >>>>>
> >>>>> -
> >>>>>
> >>
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> >>>>> -
> >>> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> >>>>> I.e. make a new file next to the original, then update our copying
> >>> logic
> >>>>> to put the prefix in the path.
> >>>>>
> >>>>>
> >>>>> Thoughts?
> >>>>>
> >>>>>
> >>>>> --
> >>>>> David Blevins
> >>>>> http://twitter.com/dblevins
> >>>>> http://www.tomitribe.com
> >>>>>
> >>>>>
> >>> --
> >>> Sent from my iPhone
> >>>
>
--
Atentamente:
César Hernández Mendoza.
Re: Ejemplos en Español
Posted by Bruno Baptista <br...@gmail.com>.
Hi Carlos,
Just chose a few documents, create the jiras and let us know them.
Cheers!
Bruno Baptista
https://twitter.com/brunobat_
On 03/01/19 01:11, Carlos Chacín wrote:
> +1 please let me know how I can help
>
> On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
> daniel.dias.analistati@gmail.com wrote:
>
>> +1 : )
>> --
>>
>> *Daniel Dias dos Santos*
>> Java Developer
>> SouJava & JCP Member
>> GitHub: https://github.com/Daniel-Dos
>> Linkedin: www.linkedin.com/in/danieldiasjava
>> Twitter: http://twitter.com/danieldiasjava
>>
>>
>> Em seg, 24 de dez de 2018 às 21:28, David Blevins <david.blevins@gmail.com
>> escreveu:
>>
>>> I say “game on” to any languages people want to contribute :)
>>>
>>> In fact, let the PRs fly. I’ll write the site logic this week.
>>>
>>> -David
>>>
>>> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
>>> aboullaite.mohammed@gmail.com> wrote:
>>>
>>>> I think its a brilliant idea. it'll open the door for not only Spanish,
>>> but
>>>> other languages as well (I'm thinking of French as well).
>>>>
>>>>
>>>>
>>>> On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
>>>> wrote:
>>>>
>>>>> I was talking with Hillmer on twitter about potentially translating
>>>>> examples into Spanish.
>>>>>
>>>>> The idea is that we could potentially do examples and documentation
>> in
>>>>> Spanish. Perhaps:
>>>>>
>>>>> - http://tomee.apache.org/tomee-8.0/es/docs/
>>>>> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
>>>>>
>>>>> First note is that how we organize the files in the git repo and how
>> we
>>>>> organize them on the website can be completely different. We use the
>>>>> following code to collect all the examples together and do various
>>> things
>>>>> to them:
>>>>>
>>>>> -
>>>>>
>> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
>>>>> Right now it will do a copy and rename, for example:
>>>>>
>>>>> -
>>>>>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
>>>>> - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
>>>>>
>>>>> We could theoretically do something as simple as this:
>>>>>
>>>>> -
>>>>>
>> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
>>>>> -
>>> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
>>>>> I.e. make a new file next to the original, then update our copying
>>> logic
>>>>> to put the prefix in the path.
>>>>>
>>>>>
>>>>> Thoughts?
>>>>>
>>>>>
>>>>> --
>>>>> David Blevins
>>>>> http://twitter.com/dblevins
>>>>> http://www.tomitribe.com
>>>>>
>>>>>
>>> --
>>> Sent from my iPhone
>>>
Re: Ejemplos en Español
Posted by Carlos Chacín <cc...@gmail.com>.
+1 please let me know how I can help
On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
daniel.dias.analistati@gmail.com wrote:
> +1 : )
> --
>
> *Daniel Dias dos Santos*
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
>
>
> Em seg, 24 de dez de 2018 às 21:28, David Blevins <david.blevins@gmail.com
> >
> escreveu:
>
> > I say “game on” to any languages people want to contribute :)
> >
> > In fact, let the PRs fly. I’ll write the site logic this week.
> >
> > -David
> >
> > On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
> > aboullaite.mohammed@gmail.com> wrote:
> >
> > > I think its a brilliant idea. it'll open the door for not only Spanish,
> > but
> > > other languages as well (I'm thinking of French as well).
> > >
> > >
> > >
> > > On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
> > > wrote:
> > >
> > > > I was talking with Hillmer on twitter about potentially translating
> > > > examples into Spanish.
> > > >
> > > > The idea is that we could potentially do examples and documentation
> in
> > > > Spanish. Perhaps:
> > > >
> > > > - http://tomee.apache.org/tomee-8.0/es/docs/
> > > > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> > > >
> > > > First note is that how we organize the files in the git repo and how
> we
> > > > organize them on the website can be completely different. We use the
> > > > following code to collect all the examples together and do various
> > things
> > > > to them:
> > > >
> > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> > > >
> > > > Right now it will do a copy and rename, for example:
> > > >
> > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > > > - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> > > >
> > > > We could theoretically do something as simple as this:
> > > >
> > > > -
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > > > -
> > http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> > > >
> > > > I.e. make a new file next to the original, then update our copying
> > logic
> > > > to put the prefix in the path.
> > > >
> > > >
> > > > Thoughts?
> > > >
> > > >
> > > > --
> > > > David Blevins
> > > > http://twitter.com/dblevins
> > > > http://www.tomitribe.com
> > > >
> > > >
> > >
> > --
> > Sent from my iPhone
> >
>
Re: Ejemplos en Español
Posted by Daniel Dias Dos Santos <da...@gmail.com>.
+1 : )
--
*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava
Em seg, 24 de dez de 2018 às 21:28, David Blevins <da...@gmail.com>
escreveu:
> I say “game on” to any languages people want to contribute :)
>
> In fact, let the PRs fly. I’ll write the site logic this week.
>
> -David
>
> On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
> aboullaite.mohammed@gmail.com> wrote:
>
> > I think its a brilliant idea. it'll open the door for not only Spanish,
> but
> > other languages as well (I'm thinking of French as well).
> >
> >
> >
> > On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
> > wrote:
> >
> > > I was talking with Hillmer on twitter about potentially translating
> > > examples into Spanish.
> > >
> > > The idea is that we could potentially do examples and documentation in
> > > Spanish. Perhaps:
> > >
> > > - http://tomee.apache.org/tomee-8.0/es/docs/
> > > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> > >
> > > First note is that how we organize the files in the git repo and how we
> > > organize them on the website can be completely different. We use the
> > > following code to collect all the examples together and do various
> things
> > > to them:
> > >
> > > -
> > >
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> > >
> > > Right now it will do a copy and rename, for example:
> > >
> > > -
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > > - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> > >
> > > We could theoretically do something as simple as this:
> > >
> > > -
> > >
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > > -
> http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> > >
> > > I.e. make a new file next to the original, then update our copying
> logic
> > > to put the prefix in the path.
> > >
> > >
> > > Thoughts?
> > >
> > >
> > > --
> > > David Blevins
> > > http://twitter.com/dblevins
> > > http://www.tomitribe.com
> > >
> > >
> >
> --
> Sent from my iPhone
>
Re: Ejemplos en Español
Posted by David Blevins <da...@gmail.com>.
I say “game on” to any languages people want to contribute :)
In fact, let the PRs fly. I’ll write the site logic this week.
-David
On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
aboullaite.mohammed@gmail.com> wrote:
> I think its a brilliant idea. it'll open the door for not only Spanish, but
> other languages as well (I'm thinking of French as well).
>
>
>
> On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com
> wrote:
>
> > I was talking with Hillmer on twitter about potentially translating
> > examples into Spanish.
> >
> > The idea is that we could potentially do examples and documentation in
> > Spanish. Perhaps:
> >
> > - http://tomee.apache.org/tomee-8.0/es/docs/
> > - http://tomee.apache.org/tomee-8.0/es/ejemplos/
> >
> > First note is that how we organize the files in the git repo and how we
> > organize them on the website can be completely different. We use the
> > following code to collect all the examples together and do various things
> > to them:
> >
> > -
> >
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
> >
> > Right now it will do a copy and rename, for example:
> >
> > -
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> > - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
> >
> > We could theoretically do something as simple as this:
> >
> > -
> >
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> > - http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
> >
> > I.e. make a new file next to the original, then update our copying logic
> > to put the prefix in the path.
> >
> >
> > Thoughts?
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >
>
--
Sent from my iPhone
Re: Ejemplos en Español
Posted by Mohammed Aboullaite <ab...@gmail.com>.
I think its a brilliant idea. it'll open the door for not only Spanish, but
other languages as well (I'm thinking of French as well).
On Mon, Dec 24, 2018, 11:35 PM David Blevins <david.blevins@gmail.com wrote:
> I was talking with Hillmer on twitter about potentially translating
> examples into Spanish.
>
> The idea is that we could potentially do examples and documentation in
> Spanish. Perhaps:
>
> - http://tomee.apache.org/tomee-8.0/es/docs/
> - http://tomee.apache.org/tomee-8.0/es/ejemplos/
>
> First note is that how we organize the files in the git repo and how we
> organize them on the website can be completely different. We use the
> following code to collect all the examples together and do various things
> to them:
>
> -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42
>
> Right now it will do a copy and rename, for example:
>
> -
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
> - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html
>
> We could theoretically do something as simple as this:
>
> -
> https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
> - http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html
>
> I.e. make a new file next to the original, then update our copying logic
> to put the prefix in the path.
>
>
> Thoughts?
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>