You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/05/04 23:17:24 UTC
Review Request 33820: Provide a configurable timeout setting on
MetricsTimelineSink.emitMetrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33820/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.
Bugs: AMBAR-10904
https://issues.apache.org/jira/browse/AMBAR-10904
Repository: ambari
Description
-------
Provide socket timeout setting for httpclient.
at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:66)
Diffs
-----
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java fd4cacd
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 2786e3c
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java a6137af
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 12230f5
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java cc365bd
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 89fc2ca
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 767695b
Diff: https://reviews.apache.org/r/33820/diff/
Testing
-------
All unit tests pass.
Thanks,
Sid Wagle
Re: Review Request 33820: Provide a configurable timeout setting on
MetricsTimelineSink.emitMetrics
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33820/#review82468
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 4, 2015, 5:17 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33820/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 5:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.
>
>
> Bugs: AMBAR-10904
> https://issues.apache.org/jira/browse/AMBAR-10904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide socket timeout setting for httpclient.
> at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
> at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:66)
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java fd4cacd
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 2786e3c
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java a6137af
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 12230f5
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java cc365bd
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 89fc2ca
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 767695b
>
> Diff: https://reviews.apache.org/r/33820/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 33820: Provide a configurable timeout setting on
MetricsTimelineSink.emitMetrics
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33820/#review82465
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 4, 2015, 9:17 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33820/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 9:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.
>
>
> Bugs: AMBAR-10904
> https://issues.apache.org/jira/browse/AMBAR-10904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide socket timeout setting for httpclient.
> at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
> at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:66)
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java fd4cacd
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 2786e3c
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java a6137af
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 12230f5
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java cc365bd
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 89fc2ca
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 767695b
>
> Diff: https://reviews.apache.org/r/33820/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Sid Wagle
>
>