You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 16:29:38 UTC
[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request #59: [FLINK-26620] Mark CRD classes experimental
SteNicholas opened a new pull request #59:
URL: https://github.com/apache/flink-kubernetes-operator/pull/59
We should mark the CRD classes experimental for the first preview release. This is the only API of the operator that we plan to release.
**The brief change log**
- Use `@Experimental` annotation to mark the classes of the `org.apache.flink.kubernetes.operator.crd` package experimental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #59: [FLINK-26620] Mark CRD classes experimental
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #59:
URL: https://github.com/apache/flink-kubernetes-operator/pull/59#issuecomment-1067094347
@gyfora, IMO, the enums don't need to add the `@Experimental` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #59: [FLINK-26620] Mark CRD classes experimental
Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #59:
URL: https://github.com/apache/flink-kubernetes-operator/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #59: [FLINK-26620] Mark CRD classes experimental
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #59:
URL: https://github.com/apache/flink-kubernetes-operator/pull/59#issuecomment-1067035899
Should we also mark UpgradeMode and JobState?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #59: [FLINK-26620] Mark CRD classes experimental
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #59:
URL: https://github.com/apache/flink-kubernetes-operator/pull/59#issuecomment-1067148653
I think we need to annotate the enums also, they affect the schema of the generated crd and what can or cannot be submitted. So 100% part of the api :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org