[GitHub] [ignite-3] Berkof commented on a change in pull request #439: IGNITE-15833 Provide interfaces for SQL Extension API

[GitBox <gi...@apache.org>]

Berkof commented on a change in pull request #439:
URL: https://github.com/apache/ignite-3/pull/439#discussion_r747194461



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/extension/SqlExtension.java
##########
@@ -0,0 +1,132 @@
+package org.apache.ignite.internal.processors.query.calcite.extension;
+
+import java.util.List;
+import java.util.Set;
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptTable;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.processors.query.calcite.exec.rel.Node;
+import org.apache.ignite.internal.processors.query.calcite.metadata.ColocationGroup;
+import org.apache.ignite.internal.processors.query.calcite.prepare.PlannerPhase;
+import org.apache.ignite.internal.processors.query.calcite.rel.IgniteRel;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Entry point to extend current sql engine with external storage or even custom execution.
+ */
+public interface SqlExtension {
+    /**
+     * Returns the name of the current extension.
+     *
+     * <p>This name will be used to distinguish between different
+     * extensions. Also the {@link CatalogUpdateListener} will register
+     * provided catalog with the same name.

Review comment:
       But there is nothing about names in CatalogUpdateListener.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org