You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/12 17:17:14 UTC

[GitHub] [fineract] vorburger opened a new pull request #688: clean up all whitespace issues in Java files (FINERACT-821)

vorburger opened a new pull request #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688
 
 
   1. convert all Java files from DOS to UNIX line ending:
        find . -type f -name "*.java" -exec dos2unix '{}' ';'
   
     2. replace Tabs with 4 Spaces:
        rpl -eRxjava "\t" "    " .
   
     3. remove all trailing spaces:
        find . -type f -name "*.java" -exec sed -i 's/ *$//' '{}' ';'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger merged pull request #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-573436950
 
 
   This PR only make whitespace clean up changes, and nothing else.  This can be "proven" by locally doing a `git diff -w` on it, or inspecting https://github.com/apache/fineract/pull/688/files?w=1.
   
   See https://issues.apache.org/jira/browse/FINERACT-821 for full background.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574044939
 
 
   > > Makes sense. Go for it.
   > 
   > but I'm waiting for you to review and hopefully merge #684 and #685 ...
   
   I think you are all set. Both PRs have now been merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574040714
 
 
   @awasum I'll fix the Merge Conflicts on this one **AFTER** my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574043410
 
 
   > Makes sense. Go for it.
   
   but I'm waiting for you to review and hopefully merge #684 and #685 ... :smiley: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)

Posted by GitBox <gi...@apache.org>.
awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574042839
 
 
   > @awasum I'll fix the Merge Conflicts on this one **AFTER** my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.)
   
   Makes sense. Go for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services