You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/17 14:12:20 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
sdedic opened a new pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769
The current dialog uses a custom layout w/ checkbox. The LSP client has some issues :) with it (can't properly discover / display the option ;)) so I propose to change the dialog to a standard `NotifyDescriptor.Confirmation`.
The wording remains mostly the same, but there are 3 closing buttons + cancel. This dialog can be remoted to LSP or processed by other `DialogDisplayer` implementations.
I've added one more option: Trust All, which changes the Gradle execution policy to `run always`.
Please review / comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-782246691
I had two other solutions before I've decided to take this shortcut:
- use "branding API" to modify the behavior. But I would have to code the variants (permitted actions) in Gradle anyway, so it's not less complicated than the current
- introduce a TrustProvider SPI (instances placed in default Lookup), the current `master` implementation being the default if no Provider decided otherwise. The decisions could be 'trust-persist', 'trust-session', 'abstain' and 'reject'. Gradle core would then take care of the persistent decisions as it does now. LSP can register its own provider and provide the alternative implementation. Would be slightly complicated as I'd probably need to introduce a Gradle integration module (so the base LSP does not bloat with dependencies), but doable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-782246691
I had two other solutions before I've decided to take this shortcut:
- use "branding API" to modify the behavior. But I would have to code the variants (permitted actions) in Gradle anyway, so it's not less complicated than the current
- introduce a `GradleExecutionTrustProvider` SPI (instances placed in default Lookup), the current `master` implementation being the default if no Provider decided otherwise. The decisions could be 'trust-persist', 'trust-session', 'abstain' and 'reject'. Gradle core would then take care of the persistent decisions as it does now. LSP can register its own provider and provide the alternative implementation. Would be slightly complicated as I'd probably need to introduce a Gradle integration module (so the base LSP does not bloat with dependencies), but doable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-796711419
Ping ... this PR is over a week without response or review, 3 weeks from latest input that has been processed. @lkishalmi, @JaroslavTulach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-789031356
Since no feedback appeared since 22th Feb 2021, I followed @lkishalmi advice to keep trust management strictly inside the module. I've changed the dialog implementation to use 'branding API' that eventually allows to expose "Trust all Gradle" for a distribution.
The behaviour in Apache NetBeans is intended to stay as it was (OK (=default), Permanent, Cancel).
Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-782212774
Can't we just detect LSP (or headlessness), then use a different dialog in that case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2769: NonUI compatibility: Trust project question uses standard dialogs.
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2769:
URL: https://github.com/apache/netbeans/pull/2769#issuecomment-796711419
Ping ... this PR is over a week without response or review, 3 weeks from last input that has been processed. @lkishalmi, @JaroslavTulach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists