You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/26 09:50:38 UTC

[GitHub] [flink] bytesandwich edited a comment on pull request #15017: [FLINK-12607][rest] Introduce a REST API that returns the maxParallelism

bytesandwich edited a comment on pull request #15017:
URL: https://github.com/apache/flink/pull/15017#issuecomment-786535400


   Thank you for your quick and attentive code review, @zentol! I also appreciate that you sent those commands. 
   
   I'm having a bit of trouble running tests and node builds (though `npm run proxy` works) under windows WSL linux. So, I ran
   ```
   # From the link
   mvn package -Dgenerate-rest-docs -pl flink-docs -am -nsu -DskipTests -Pskip-webui-build
   ```
   
   And I wasn't able to get `mvn package` without `-DskipTests` or `mvn test` to work, but I was able to run that specific test in intellij for some reason.
   
   I think I cleaned it up, rebased, and ran pretty much those commands? PTAL. I think I addressed all the comments you've made so far.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org