You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/05/26 08:37:05 UTC
[GitHub] [spark] beliefer opened a new pull request, #41329: [SPARK-16484][CONNECT][FOLLOWUP] Simplify the hll_union_agg by reuse functions.
beliefer opened a new pull request, #41329:
URL: https://github.com/apache/spark/pull/41329
### What changes were proposed in this pull request?
https://github.com/apache/spark/pull/40615 added the hll_union_agg into Spark and Spark connect project.
But hll_union_agg in function API are defined one by one.
In fact, we can simplify the hll_union_agg by reuse functions.
### Why are the changes needed?
Simplify the hll_union_agg by reuse functions.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
Exists test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41329: [SPARK-16484][SPARK-42527][CONNECT][FOLLOWUP] Simplify functions API by reuse existent functions.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41329: [SPARK-16484][SPARK-42527][CONNECT][FOLLOWUP] Simplify functions API by reuse existent functions.
URL: https://github.com/apache/spark/pull/41329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41329: [SPARK-16484][SPARK-42527][CONNECT][FOLLOWUP] Simplify functions API by reuse existent functions.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41329:
URL: https://github.com/apache/spark/pull/41329#issuecomment-1566324579
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41329: [SPARK-16484][CONNECT][FOLLOWUP] Simplify the hll_union_agg by reuse functions.
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41329:
URL: https://github.com/apache/spark/pull/41329#issuecomment-1565101242
ping @hvanhovell @HyukjinKwon @zhengruifeng cc @RyanBerti @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41329: [SPARK-16484][SPARK-42527][CONNECT][FOLLOWUP] Simplify functions API by reuse existent functions.
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41329:
URL: https://github.com/apache/spark/pull/41329#issuecomment-1566541566
@HyukjinKwon Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org