[GitHub] [superset] eschutho commented on a change in pull request #17382: fix(sqllab): Query limit dropdown number breaks to separate lines

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #17382:
URL: https://github.com/apache/superset/pull/17382#discussion_r746166762



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
##########
@@ -125,6 +125,10 @@ const StyledToolbar = styled.div`
       }
     }
   }
+
+  .limitDropdown {
+    width: max-content;

Review comment:
       this is great! Super small nit, but `white-space: nowrap` may be more explicit here. You're saying "don't wrap on the white space", rather than "make the width of the element match the content." With `white-space`if you wanted to change the width later and make it larger, you still can. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org