You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mgaido91 <gi...@git.apache.org> on 2018/04/05 12:04:14 UTC
[GitHub] nifi pull request #2606: NIFI-5043: TailFile in Multifile mode should not op...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/nifi/pull/2606
NIFI-5043: TailFile in Multifile mode should not open new readers in onTrigger
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes? **Manual tests (running lsof while the processor runs)**
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/nifi NIFI-5043
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2606
----
commit d688846af44f2647d4d3e38508f9af4ca503632f
Author: Marco Gaido <ma...@...>
Date: 2018-04-05T11:44:55Z
NIFI-5043: TailFile in Multifile mode should not open new readers in onTrigger
----
---
[GitHub] nifi pull request #2606: NIFI-5043: TailFile in Multifile mode should not op...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2606
---
[GitHub] nifi issue #2606: NIFI-5043: TailFile in Multifile mode should not open new ...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2606
Thank you for taking a look at this and reviewing it, @markap14!
---
[GitHub] nifi issue #2606: NIFI-5043: TailFile in Multifile mode should not open new ...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2606
@mgaido91 thanks for addressing this! And the JIRA did a good job of explaining exactly what the issue is, as well as how to detect that the issue was present. Was able to detect the issue on master, then running the PR was able to ensure that the issue is no longer present. Otherwise, the code looks good and the changes make sense. +1 merged to master. Thanks again!
---