You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/01 12:58:00 UTC
[jira] [Commented] (AIRFLOW-5578) The root url "/" should be
configurable, not hardcoded
[ https://issues.apache.org/jira/browse/AIRFLOW-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941798#comment-16941798 ]
ASF GitHub Bot commented on AIRFLOW-5578:
-----------------------------------------
ddossett commented on pull request #6223: AIRFLOW-5578 Adding the ability to define custom IndexView
URL: https://github.com/apache/airflow/pull/6223
### Jira
- [x] My PR addresses the following [Jira Issue](https://issues.apache.org/jira/browse/AIRFLOW-5578)
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
* The route that simply redirects to "/home" in airflow.www.blueprints has been replaced with an IndexView version from Flask-Appbuilder.
* This IndexView is used as the default and should behave in exactly the same way as before.
* I have added config option for defining your own IndexView class in default_webserver_config.py
* The either the default IndexView or the one defined in default_webserver_config.py is used by the indexview keyword in the appbuilder setup in app.py
* So now a user can define a custom IndexView and choose to do something else instead of a simple redirection.
### Tests
- [x] My PR adds no unit tests
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits (closely) follow the guidelines.
### Documentation
- [x] The config file contains a description of what to do. And the IndexView class has a basic docstring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> The root url "/" should be configurable, not hardcoded
> ------------------------------------------------------
>
> Key: AIRFLOW-5578
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5578
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webserver
> Affects Versions: 1.10.5
> Reporter: David Dossett
> Assignee: David Dossett
> Priority: Minor
>
> The webserver root url "/" is hardcoded in airflow/www/blueprints.py to redirect to the Airflow.index view function. If you want to build a front-end website to airflow, with the normal /home as an admin area, then you will always have the problem that this will redirect to the admin area first and this is not configurable.
> Flask Appbuilder has the IndexView class which can be set dynamically when creating the app. This should allow for some configuration of custom IndexView classes using the default_webserver_config.py
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)