[jira] [Commented] (FELIX-5640) Using JarFile to getManifest to avoid NPE when META-INF and MANIFEST.MF are not the first 2 entries in jar

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158243#comment-16158243 ] 

Guillaume Nodet commented on FELIX-5640:
----------------------------------------

I'm not opposed to your proposal about supporting jar files with a MANIFEST not at the beginning, however your patch assumes that the URLs used are always file based, which isn't the case.  Hence, it's not possible to use a JarFile.  It might be possible to use a ZipInputStream and try to iterate through the entries.  However, we can't buffer too much in memory, so if the MANIFEST is not in the first 256k, we should cache to disk or reject.

> Using JarFile to getManifest to avoid NPE when META-INF and MANIFEST.MF are not the first 2 entries in jar
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-5640
>                 URL: https://issues.apache.org/jira/browse/FELIX-5640
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>            Reporter: Andy Wu
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)