You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/07 23:02:48 UTC

[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints

lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015982803


##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -45,6 +46,12 @@ func init() {
 			"have no more than 1 override applied to it. If multiple "+
 			"overrides match a container image it is arbitrary which "+
 			"will be applied.")
+	flag.Var(&ResourceHints,
+		"resource_hints",
+		"Set whole pipeline level resource hints, accepting values of the format '<urn>=<value>'. "+
+			"Supports 'min_ram' and 'accelerator' hints. "+

Review Comment:
   Good call. Agreed. This was written before I learned that there's a "break glass" with default URN semantics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org