You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/06 14:32:09 UTC
[GitHub] [maven-jlink-plugin] elharo opened a new pull request #22: older commons IO for dependency convergence
elharo opened a new pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
bmarwell commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583748
Assuming this plugin needs at least java 9 to work (either by toolchain or by the executing Java), I do not see the purpose of this change. No one would be affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] sparsick edited a comment on pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
sparsick edited a comment on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155
Maybe we should upgrade the other dependencies that requires Java 8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583228
Upgrading other dependencies would be a major breaking change that shoould be discussed on the mailing list and follow some analysis of how many projects and people we'd be likely to break. Most folks are on Java 8 now, but not all, and Maven is very widely used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] sparsick commented on pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
sparsick commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155
Maybe we should upgrade the other dependencies to require Java 8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537134930
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.8.0</version>
Review comment:
Please give a short reason. Either inherit it from somewhere or add a comment.
Plugins are seperated by classloaders as far as I remember, so a dependency convergence should not hurt (aside from a few KiB of jars).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537147922
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.8.0</version>
Review comment:
check the dependency convergence report. It's not just the plugins but shared libraries such as maven-archiver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739584400
It's not just about this plugin. It's about its own dependencies like maven-archiver that are expecting an older version of commons-io. They'll probably work with the new version, but in the rare cases when they don't it's a really nasty problem to locate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell closed pull request #22: older commons IO for dependency convergence
Posted by GitBox <gi...@apache.org>.
bmarwell closed pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org