You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 11:35:56 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…

rkhachatryan commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r554980369



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
 import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
 import org.apache.flink.streaming.api.graph.StreamConfig;
 import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;

Review comment:
       Looks like `InputProcessorUtil` also belongs to `checkpointing` as it's sole purpose is to create `CheckpointedInputGate`. And the purpose of the latter is to handle events, mostly checkpoint barriers.
   
   How about moving it too along with `UpstreamRecoveryTracker`/Impl and `CheckpointedInputGate`?
   
   WDYT @pnowojski , @AHeise ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org