You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2011/07/07 20:41:16 UTC
[jira] [Created] (QPID-3345) Make new transport implementations
pluggable
Make new transport implementations pluggable
--------------------------------------------
Key: QPID-3345
URL: https://issues.apache.org/jira/browse/QPID-3345
Project: Qpid
Issue Type: Improvement
Components: Java Client, Java Common
Reporter: Keith Wall
Fix For: 0.13
Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063427#comment-13063427 ]
Rajith Attapattu commented on QPID-3345:
----------------------------------------
Keith,
I also got the same error when trying to add the patch when creating a review request. I got around that by just creating a review request without the patch and then using upload diff, once the request is created.Perhaps that might work for you as well.
I'd be happy to review the patch for you.
Regards,
Rajith
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3345) Make new transport implementations
pluggable
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3345:
--------------------------------
Assignee: Rajith Attapattu (was: Keith Wall)
Hi Rajith
Would you mind reviewing this patch?
(I've been trying to put this up on review board, but it keeps giving me an internal server error).
cheers Keith.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3345) Make new transport implementations
pluggable
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3345:
--------------------------------
Assignee: Keith Wall
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064666#comment-13064666 ]
jiraposter@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
bq. On 2011-07-13 04:04:38, rajith attapattu wrote:
bq. > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java, line 30
bq. > <https://reviews.apache.org/r/1087/diff/1/?file=22375#file22375line30>
bq. >
bq. > Looking at the Transport class, I see that transports are choosen based on the AMQP protocol version.
bq. >
bq. > While it is true that this can be easily overridden using qpid.transport system property, it would have been nice if we had the transport implementations independent of the protocol versions.
bq. >
bq. > Perhaps this is the case, and the map is just there to specify the default (or preferred) transport for each version?
bq. >
bq. > Is this approach was taken due to the 0-8,0-9 version code paths are heavily tied to MINA (I haven't really looked at the code in this area for a long time) ?
bq.
bq. Keith Wall wrote:
bq. No, for the client, user can either override all transports (via -Dqpid.transport) or by protocol version (via -Dqpid.transport.v0_10 etc).
bq.
bq. The objective of this Jira was merely to reintroduce plugability of the existing transports.
bq.
bq. The next step will be the testing of the IoNetworkTransport implementation against 0-8..0-9-1 so that it can become the default for all protocols. This will take us the next step towards making the use Mina on the client optional. This is a reasonably complex area, so I think an incremental approach makes sense.
bq.
bq.
Gotcha. Thanks for the answers.
- rajith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/#review1041
-----------------------------------------------------------
On 2011-07-12 09:38:50, Keith Wall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 09:38:50)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection.
bq.
bq.
bq. This addresses bug QPID-3345.
bq. https://issues.apache.org/jira/browse/QPID-3345
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481
bq. /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481
bq. /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481
bq. /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481
bq.
bq. Diff: https://reviews.apache.org/r/1087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths)
bq.
bq.
bq. Thanks,
bq.
bq. Keith
bq.
bq.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3345) Make new transport implementations
pluggable
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3345:
-----------------------------
Attachment: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
Proposed patch to resolve this Improvement.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064335#comment-13064335 ]
jiraposter@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/#review1041
-----------------------------------------------------------
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java
<https://reviews.apache.org/r/1087/#comment2117>
Looking at the Transport class, I see that transports are choosen based on the AMQP protocol version.
While it is true that this can be easily overridden using qpid.transport system property, it would have been nice if we had the transport implementations independent of the protocol versions.
Perhaps this is the case, and the map is just there to specify the default (or preferred) transport for each version?
Is this approach was taken due to the 0-8,0-9 version code paths are heavily tied to MINA (I haven't really looked at the code in this area for a long time) ?
- rajith
On 2011-07-12 09:38:50, Keith Wall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 09:38:50)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection.
bq.
bq.
bq. This addresses bug QPID-3345.
bq. https://issues.apache.org/jira/browse/QPID-3345
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481
bq. /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481
bq. /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481
bq. /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481
bq.
bq. Diff: https://reviews.apache.org/r/1087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths)
bq.
bq.
bq. Thanks,
bq.
bq. Keith
bq.
bq.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064597#comment-13064597 ]
jiraposter@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
bq. On 2011-07-13 04:04:38, rajith attapattu wrote:
bq. > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java, line 30
bq. > <https://reviews.apache.org/r/1087/diff/1/?file=22375#file22375line30>
bq. >
bq. > Looking at the Transport class, I see that transports are choosen based on the AMQP protocol version.
bq. >
bq. > While it is true that this can be easily overridden using qpid.transport system property, it would have been nice if we had the transport implementations independent of the protocol versions.
bq. >
bq. > Perhaps this is the case, and the map is just there to specify the default (or preferred) transport for each version?
bq. >
bq. > Is this approach was taken due to the 0-8,0-9 version code paths are heavily tied to MINA (I haven't really looked at the code in this area for a long time) ?
No, for the client, user can either override all transports (via -Dqpid.transport) or by protocol version (via -Dqpid.transport.v0_10 etc).
The objective of this Jira was merely to reintroduce plugability of the existing transports.
The next step will be the testing of the IoNetworkTransport implementation against 0-8..0-9-1 so that it can become the default for all protocols. This will take us the next step towards making the use Mina on the client optional. This is a reasonably complex area, so I think an incremental approach makes sense.
- Keith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/#review1041
-----------------------------------------------------------
On 2011-07-12 09:38:50, Keith Wall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 09:38:50)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection.
bq.
bq.
bq. This addresses bug QPID-3345.
bq. https://issues.apache.org/jira/browse/QPID-3345
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481
bq. /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481
bq. /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481
bq. /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481
bq.
bq. Diff: https://reviews.apache.org/r/1087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths)
bq.
bq.
bq. Thanks,
bq.
bq. Keith
bq.
bq.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3345) Make new transport implementations
pluggable
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3345:
------------------------------------
Assignee: Robbie Gemmell (was: Rajith Attapattu)
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063789#comment-13063789 ]
jiraposter@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/
-----------------------------------------------------------
Review request for qpid.
Summary
-------
QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection.
This addresses bug QPID-3345.
https://issues.apache.org/jira/browse/QPID-3345
Diffs
-----
/trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION
/trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481
/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481
/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481
Diff: https://reviews.apache.org/r/1087/diff
Testing
-------
Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths)
Thanks,
Keith
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3345) Make new transport implementations
pluggable
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3345.
----------------------------------
Resolution: Fixed
Patch applied, closing out.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3345) Make new transport implementations
pluggable
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064667#comment-13064667 ]
jiraposter@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/#review1045
-----------------------------------------------------------
Ship it!
I looked at the patch from the client side and it looks good to me.
I am happy with the direction you are taking.
- rajith
On 2011-07-12 09:38:50, Keith Wall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 09:38:50)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3345: transport implementations for client/broker sides controllable via new System Properties and Reflection.
bq.
bq.
bq. This addresses bug QPID-3345.
bq. https://issues.apache.org/jira/browse/QPID-3345
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java PRE-CREATION
bq. /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java 1145481
bq. /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java 1145481
bq. /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java 1145481
bq. /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java 1145481
bq. /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java 1145481
bq.
bq. Diff: https://reviews.apache.org/r/1087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Additional unit test and exercised by existing system test suite (0-9-1/0-10 code paths)
bq.
bq.
bq. Thanks,
bq.
bq. Keith
bq.
bq.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments: 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be loaded by reflection, thus working towards the removal of dependencies on Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org