You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/28 08:24:02 UTC

[jira] [Commented] (IGNITE-5593) Affinity change message leak on massive topology updates

    [ https://issues.apache.org/jira/browse/IGNITE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066127#comment-16066127 ] 

ASF GitHub Bot commented on IGNITE-5593:
----------------------------------------

GitHub user AMashenkov opened a pull request:

    https://github.com/apache/ignite/pull/2210

    IGNITE-5593: Affinity change message leak on massive topology updates

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2210
    
----
commit 52a5d4f7725609050fd64335369da7d123598d35
Author: Andrey V. Mashenkov <an...@gmail.com>
Date:   2017-06-27T17:43:07Z

    Fixed.

commit a69488397cbd3d2209f17fc9778237cd7d8d6b79
Author: Andrey V. Mashenkov <an...@gmail.com>
Date:   2017-06-28T08:02:48Z

    Minor.

----


> Affinity change message leak on massive topology updates
> --------------------------------------------------------
>
>                 Key: IGNITE-5593
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5593
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 1.7
>            Reporter: Alexey Goncharuk
>            Assignee: Andrew Mashenkov
>            Priority: Critical
>             Fix For: 2.1
>
>
> When late affinity assignment is enabled, we complete the exchange future with custom discovery event. Since discovery topology events usually are much faster than exchange futures completion, it is possible that a newly joined node can 'see' the affinity change messages that are related to previous topology versions when this node even was not present in the topology.
> When this message is received, an exchange future is created and this message is added to discoEvts list. However, this future never completes on this node because init() is never called. This means that this exchange future sits in the exchange set with the affinity change message.
> Since the number of topology changes (and, thus, messages) can be quite large, this leads to excessive memory consumption on the starting node. I've observed ~3Gb of heap wasted on one of the nodes when > 200 nodes were restarted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)