You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/07/30 12:16:02 UTC
[GitHub] [unomi] sergehuber commented on a change in pull request #329: UNOMI-338, UNOMI-482: better implementation for lastVisit, firstVisit…
sergehuber commented on a change in pull request #329:
URL: https://github.com/apache/unomi/pull/329#discussion_r679876215
##########
File path: itests/src/test/java/org/apache/unomi/itests/BasicIT.java
##########
@@ -265,7 +278,7 @@ private ContextRequest getContextRequestWithLoginEvent(CustomItem sourceSite, Ma
contextRequest.setSource(sourceSite);
contextRequest.setRequireSegments(false);
contextRequest.setEvents(Collections.singletonList(loginEvent));
- contextRequest.setRequiredProfileProperties(Arrays.asList(FIRST_NAME, LAST_NAME, EMAIL));
+ contextRequest.setRequiredProfileProperties(Arrays.asList(FIRST_NAME, LAST_NAME, EMAIL, "firstVisit", "lastVisit", "previousVisit"));
Review comment:
Could we use constants for those property names too ?
##########
File path: itests/src/test/java/org/apache/unomi/itests/BasicIT.java
##########
@@ -290,7 +303,7 @@ private ContextRequest getContextRequestWithPageViewEvent(CustomItem sourceSite,
contextRequest.setSource(customPageItem);
contextRequest.setRequireSegments(false);
contextRequest.setEvents(Collections.singletonList(pageViewEvent));
- contextRequest.setRequiredProfileProperties(Arrays.asList(FIRST_NAME, LAST_NAME, EMAIL));
+ contextRequest.setRequiredProfileProperties(Arrays.asList(FIRST_NAME, LAST_NAME, EMAIL, "firstVisit", "lastVisit", "previousVisit"));
Review comment:
Some comments as before, maybe use constants here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org