You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/02/20 02:03:49 UTC
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/511
CB-10347: Remove 'Add icons and splash screen' article
Icons page cleanup
@nikhilkh @rakatyal @dblotsky Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-docs CB-10347
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #511
----
commit a04c7c8c364c12ad02217ed914c7e825dd10b318
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-02-20T00:56:51Z
CB-10347: Remove 'Add icons and splash screen' article
Icons page cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-188385262
Thank you! :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-188384413
@daserge Link: https://github.com/apache/cordova-plugin-splashscreen/blob/master/README.md This file is downloaded to the site. Agreed that this does not have examples. I will create a JIRA task to add examples to this README.me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542149
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -118,72 +113,8 @@ Windows
<icon src="res/windows/storelogo.png" width="50" height="50" />
</platform>
-## Configuring Splash Screens in the CLI
-
-In the top-level `config.xml` file (not the one in `platforms`), add configuration elements like those specified here.
-
-# Example configuration
-
-Please notice that the value of the "src" attribute is relative to the project directory and not to the www directory.
-You can name the source image whatever you like. The internal name in the app are determined by Cordova.
-
- <platform name="android">
- <!-- you can use any density that exists in the Android project -->
- <splash src="res/screen/android/splash-land-hdpi.png" density="land-hdpi"/>
- <splash src="res/screen/android/splash-land-ldpi.png" density="land-ldpi"/>
- <splash src="res/screen/android/splash-land-mdpi.png" density="land-mdpi"/>
- <splash src="res/screen/android/splash-land-xhdpi.png" density="land-xhdpi"/>
-
- <splash src="res/screen/android/splash-port-hdpi.png" density="port-hdpi"/>
- <splash src="res/screen/android/splash-port-ldpi.png" density="port-ldpi"/>
- <splash src="res/screen/android/splash-port-mdpi.png" density="port-mdpi"/>
- <splash src="res/screen/android/splash-port-xhdpi.png" density="port-xhdpi"/>
- </platform>
-
- <platform name="ios">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/ios/Default~iphone.png" width="320" height="480"/>
- <splash src="res/screen/ios/Default@2x~iphone.png" width="640" height="960"/>
- <splash src="res/screen/ios/Default-Portrait~ipad.png" width="768" height="1024"/>
- <splash src="res/screen/ios/Default-Portrait@2x~ipad.png" width="1536" height="2048"/>
- <splash src="res/screen/ios/Default-Landscape~ipad.png" width="1024" height="768"/>
- <splash src="res/screen/ios/Default-Landscape@2x~ipad.png" width="2048" height="1536"/>
- <splash src="res/screen/ios/Default-568h@2x~iphone.png" width="640" height="1136"/>
- <splash src="res/screen/ios/Default-667h.png" width="750" height="1334"/>
- <splash src="res/screen/ios/Default-736h.png" width="1242" height="2208"/>
- <splash src="res/screen/ios/Default-Landscape-736h.png" width="2208" height="1242"/>
- </platform>
-
- <platform name="wp8">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/wp8/SplashScreenImage.jpg" width="768" height="1280"/>
- </platform>
-
- <platform name="windows">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/windows/splashscreen.png" width="620" height="300"/>
- </platform>
-
- <platform name="blackberry10">
- <!-- Add a rim:splash element for each resolution and locale you wish -->
- <!-- http://developer.blackberry.com/html5/documentation/rim_splash_element.html -->
- <rim:splash src="res/screen/blackberry10/splashscreen.png"/>
- </platform>
-
-
- <preference name="SplashScreenDelay" value="10000" />
-
-# Supported platforms
-
-As of now (Cordova 3.5.0 July 2014) the following platforms support splash screens.
-
- android
- ios
- wp8
- windows
- blackberry10
-# Splashscreen Plugin
+Looking for Splash screen configuration? Visit [Splashscreen plugin][splashscreen_plugin].
--- End diff --
I wouldn't start with "Looking for ...". Just say that the splashscreen plugin gives more nuanced configuration options and maybe list a few examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53732947
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -61,17 +57,16 @@ Android
<icon src="res/android/xhdpi.png" density="xhdpi" />
</platform>
-BlackBerry10
+##BlackBerry10
--- End diff --
Nitpick: for consistency with other headings, please add a space after the `#`s.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-187503334
@daserge Can you please review? As per the splashscreen plugin docs, I do not see it has the docs that you just deleted. Do you have another task to track that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53738539
--- Diff: www/_data/toc/en-dev-manual.yml ---
@@ -25,12 +25,12 @@
- name: "Windows"
url: "guide/platforms/win8/index.html"
- name: "WP8"
- url: "guide/platforms/wp8/home.html"
+ url: "guide/platforms/wp8/home.html"
- name: "Manage versions and platforms"
url: "platform_plugin_versioning_ref/index.html"
- name: "Debug and test"
url:
- - name: "Use icons and splash screens"
+ - name: "Use Icons"
--- End diff --
Aren't there other languages that need an update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53748431
--- Diff: www/_data/toc/en-dev-manual.yml ---
@@ -25,12 +25,12 @@
- name: "Windows"
url: "guide/platforms/win8/index.html"
- name: "WP8"
- url: "guide/platforms/wp8/home.html"
+ url: "guide/platforms/wp8/home.html"
- name: "Manage versions and platforms"
url: "platform_plugin_versioning_ref/index.html"
- name: "Debug and test"
url:
- - name: "Use icons and splash screens"
+ - name: "Use Icons"
--- End diff --
@nikhilkh it's not strictly necessary right now, since they're untranslated in other languages. But if it's not too much work, I guess @rakatyal please do update the other languages as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-188382947
@sarangan12, I looked but was not able to find `## Configuring Splash Screens in the CLI` and `# Example configuration` substitutes.
Could you please share a link to the new location of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-187299157
@riknoll Fixes added for your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53740043
--- Diff: www/_data/toc/en-dev-manual.yml ---
@@ -25,12 +25,12 @@
- name: "Windows"
url: "guide/platforms/win8/index.html"
- name: "WP8"
- url: "guide/platforms/wp8/home.html"
+ url: "guide/platforms/wp8/home.html"
- name: "Manage versions and platforms"
url: "platform_plugin_versioning_ref/index.html"
- name: "Debug and test"
url:
- - name: "Use icons and splash screens"
+ - name: "Use Icons"
--- End diff --
Yes it should be updated for other languages as well in the dev version. I missed this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542087
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -34,15 +31,14 @@ If you do not specify an icon then the Apache Cordova logo is used.
<icon src="res/ios/icon.png" platform="ios" width="57" height="57" density="mdpi" />
-src: (required) specifies the location of the image file, relative to your project directory
+Attribute | Requirement | Description
--- End diff --
The requirement information should be listed in the description column. See the example here: https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53666318
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -118,72 +113,8 @@ Windows
<icon src="res/windows/storelogo.png" width="50" height="50" />
</platform>
-## Configuring Splash Screens in the CLI
-
-In the top-level `config.xml` file (not the one in `platforms`), add configuration elements like those specified here.
-
-# Example configuration
-
-Please notice that the value of the "src" attribute is relative to the project directory and not to the www directory.
-You can name the source image whatever you like. The internal name in the app are determined by Cordova.
-
- <platform name="android">
- <!-- you can use any density that exists in the Android project -->
- <splash src="res/screen/android/splash-land-hdpi.png" density="land-hdpi"/>
- <splash src="res/screen/android/splash-land-ldpi.png" density="land-ldpi"/>
- <splash src="res/screen/android/splash-land-mdpi.png" density="land-mdpi"/>
- <splash src="res/screen/android/splash-land-xhdpi.png" density="land-xhdpi"/>
-
- <splash src="res/screen/android/splash-port-hdpi.png" density="port-hdpi"/>
- <splash src="res/screen/android/splash-port-ldpi.png" density="port-ldpi"/>
- <splash src="res/screen/android/splash-port-mdpi.png" density="port-mdpi"/>
- <splash src="res/screen/android/splash-port-xhdpi.png" density="port-xhdpi"/>
- </platform>
-
- <platform name="ios">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/ios/Default~iphone.png" width="320" height="480"/>
- <splash src="res/screen/ios/Default@2x~iphone.png" width="640" height="960"/>
- <splash src="res/screen/ios/Default-Portrait~ipad.png" width="768" height="1024"/>
- <splash src="res/screen/ios/Default-Portrait@2x~ipad.png" width="1536" height="2048"/>
- <splash src="res/screen/ios/Default-Landscape~ipad.png" width="1024" height="768"/>
- <splash src="res/screen/ios/Default-Landscape@2x~ipad.png" width="2048" height="1536"/>
- <splash src="res/screen/ios/Default-568h@2x~iphone.png" width="640" height="1136"/>
- <splash src="res/screen/ios/Default-667h.png" width="750" height="1334"/>
- <splash src="res/screen/ios/Default-736h.png" width="1242" height="2208"/>
- <splash src="res/screen/ios/Default-Landscape-736h.png" width="2208" height="1242"/>
- </platform>
-
- <platform name="wp8">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/wp8/SplashScreenImage.jpg" width="768" height="1280"/>
- </platform>
-
- <platform name="windows">
- <!-- images are determined by width and height. The following are supported -->
- <splash src="res/screen/windows/splashscreen.png" width="620" height="300"/>
- </platform>
-
- <platform name="blackberry10">
- <!-- Add a rim:splash element for each resolution and locale you wish -->
- <!-- http://developer.blackberry.com/html5/documentation/rim_splash_element.html -->
- <rim:splash src="res/screen/blackberry10/splashscreen.png"/>
- </platform>
-
-
- <preference name="SplashScreenDelay" value="10000" />
-
-# Supported platforms
-
-As of now (Cordova 3.5.0 July 2014) the following platforms support splash screens.
-
- android
- ios
- wp8
- windows
- blackberry10
-# Splashscreen Plugin
+The splash screen configuration information could be found at [Splashscreen plugin docs][splashscreen_plugin].
--- End diff --
Grammar:
Additional splash screen configuration options _can_ be found _in the_ Splashscreen Plugin docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-188380902
@daserge As part of plugin pull task, the details are already available on the readme file of splashscreen plugin and available in our site. The link (in the current page) point to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-187387691
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-187306258
@riknoll Changed that line. Not adding 'additional' there. As there is no splashcreen information prior to the line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542106
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -52,7 +48,7 @@ which will be used for all platforms.
For each platform you can also define a pixel-perfect icons set to fit
different screen resolutions.
-Android
+**Android**
--- End diff --
Why not headings for these instead of bold?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-docs/pull/511#issuecomment-188146084
@sarangan12, do you plan to move splashscreen-related configuration docs to cordova-plugin-splashscreen?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org