You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/11/30 20:28:24 UTC
Review Request 64223: Oozie Fails To Restart During Upgrade Because of
Missing ExtJS Library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-22568
https://issues.apache.org/jira/browse/AMBARI-22568
Repository: ambari
Description
-------
1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
2) Express upgrade to target version 2.6.4.0-52
Oozie Server Restart fails with below error:
```
Traceback (most recent call last):
...
File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
```
This is because we have removed the requirement of having ExtJS in the cluster.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
Diff: https://reviews.apache.org/r/64223/diff/1/
Testing
-------
Upgraded Oozie
----------------------------------------------------------------------
Total run:1196
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58.251 s
[INFO] Finished at: 2017-11-30T15:16:50-05:00
[INFO] Final Memory: 21M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192364
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 30, 2017, 3:28 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 3:28 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
>
> Oozie Server Restart fails with below error:
>
> ```
> Traceback (most recent call last):
> ...
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
> ```
>
> This is because we have removed the requirement of having ExtJS in the cluster.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
>
>
> Diff: https://reviews.apache.org/r/64223/diff/1/
>
>
> Testing
> -------
>
> Upgraded Oozie
>
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192471
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 30, 2017, 11:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 11:18 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
>
> Oozie Server Restart fails with below error:
>
> ```
> Traceback (most recent call last):
> ...
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
> ```
>
> This is because we have removed the requirement of having ExtJS in the cluster.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
>
>
> Diff: https://reviews.apache.org/r/64223/diff/2/
>
>
> Testing
> -------
>
> Upgraded Oozie
>
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192369
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On Nov. 30, 2017, 9:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 9:18 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
>
> Oozie Server Restart fails with below error:
>
> ```
> Traceback (most recent call last):
> ...
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
> ```
>
> This is because we have removed the requirement of having ExtJS in the cluster.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
>
>
> Diff: https://reviews.apache.org/r/64223/diff/2/
>
>
> Testing
> -------
>
> Upgraded Oozie
>
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/
-----------------------------------------------------------
(Updated Nov. 30, 2017, 4:18 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-22568
https://issues.apache.org/jira/browse/AMBARI-22568
Repository: ambari
Description
-------
1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
2) Express upgrade to target version 2.6.4.0-52
Oozie Server Restart fails with below error:
```
Traceback (most recent call last):
...
File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
```
This is because we have removed the requirement of having ExtJS in the cluster.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
Diff: https://reviews.apache.org/r/64223/diff/2/
Changes: https://reviews.apache.org/r/64223/diff/1-2/
Testing
-------
Upgraded Oozie
----------------------------------------------------------------------
Total run:1196
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58.251 s
[INFO] Finished at: 2017-11-30T15:16:50-05:00
[INFO] Final Memory: 21M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Nov. 30, 2017, 3:35 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> > Line 123 (original), 123 (patched)
> > <https://reviews.apache.org/r/64223/diff/1/?file=1904822#file1904822line123>
> >
> > is coma needed here? python may think that this is tuple declaration
Nope, merge conflict
> On Nov. 30, 2017, 3:35 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/64223/diff/1/?file=1904823#file1904823line71>
> >
> > filles - prolly typo?
Fixed.
> On Nov. 30, 2017, 3:35 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py
> > Lines 1186 (patched)
> > <https://reviews.apache.org/r/64223/diff/1/?file=1904825#file1904825line1186>
> >
> > can we remove this?
done.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192357
-----------------------------------------------------------
On Nov. 30, 2017, 3:28 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 3:28 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
>
> Oozie Server Restart fails with below error:
>
> ```
> Traceback (most recent call last):
> ...
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
> ```
>
> This is because we have removed the requirement of having ExtJS in the cluster.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
>
>
> Diff: https://reviews.apache.org/r/64223/diff/1/
>
>
> Testing
> -------
>
> Upgraded Oozie
>
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 64223: Oozie Fails To Restart During Upgrade
Because of Missing ExtJS Library
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192357
-----------------------------------------------------------
Fix it, then Ship it!
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
Line 123 (original), 123 (patched)
<https://reviews.apache.org/r/64223/#comment270458>
is coma needed here? python may think that this is tuple declaration
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
Lines 71 (patched)
<https://reviews.apache.org/r/64223/#comment270459>
filles - prolly typo?
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py
Lines 1186 (patched)
<https://reviews.apache.org/r/64223/#comment270460>
can we remove this?
- Dmytro Grinenko
On Nov. 30, 2017, 8:28 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 8:28 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
>
> Oozie Server Restart fails with below error:
>
> ```
> Traceback (most recent call last):
> ...
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py", line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', '/var/lib/oozie/ext-2.2.zip']
> ```
>
> This is because we have removed the requirement of having ExtJS in the cluster.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py b81186144c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 2109a5d5e9
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4d94723bbf
>
>
> Diff: https://reviews.apache.org/r/64223/diff/1/
>
>
> Testing
> -------
>
> Upgraded Oozie
>
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>